From nobody@FreeBSD.org  Thu Jan  3 15:42:19 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 3AD4C3B1
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  3 Jan 2013 15:42:19 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 13BC0F88
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  3 Jan 2013 15:42:19 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r03FgIhw023199
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 3 Jan 2013 15:42:18 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r03FgIf8023198;
	Thu, 3 Jan 2013 15:42:18 GMT
	(envelope-from nobody)
Message-Id: <201301031542.r03FgIf8023198@red.freebsd.org>
Date: Thu, 3 Jan 2013 15:42:18 GMT
From: Sandra <littlesandra88@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ZFS ACL: rwxp required to mkdir. p should not be required.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         174949
>Category:       kern
>Synopsis:       [zfs] ZFS ACL: rwxp required to mkdir. p should not be required.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    trasz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 03 15:50:02 UTC 2013
>Closed-Date:    Mon Apr 01 13:00:35 UTC 2013
>Last-Modified:  Mon Apr 01 13:00:35 UTC 2013
>Originator:     Sandra
>Release:        
>Organization:
>Environment:
>Description:
ZFS ACL.

p is suppose to be permission to append to files, and also not being implemented.

For some reason p is required to mkdir.


This is the output from the script in "How to repeat the problem" which shows this bug.


p="/tank/project1"
d="$p/test3"
u="user1"

rm -rf $f $d $e $g
setfacl -b $p

setfacl -m group@::fd:allow $p || exit 1
setfacl -m everyone@::fd:allow $p || exit 1
setfacl -m owner@:rwx:fd:allow $p || exit 1
setfacl -m u:$u:rwx:fd:allow $p || exit 1
getfacl $p
# file: /tank/project1
# owner: root
# group: wheel
        user:user1:rwx-----------:fd----:allow
            owner@:rwx-----------:fd----:allow
            group@:--------------:fd----:allow
         everyone@:--------------:fd----:allow

su -m $u -c "mkdir $d"
mkdir: /tank/project1/test3: Permission denied

setfacl -m u:$u:rwxp:fd:allow $p || exit 1
su -m $u -c "mkdir $d"

getfacl $d
# file: /tank/project1/test3
# owner: user1
# group: wheel
        user:user1:rwxp----------:fd----:allow
            owner@:rwx-----------:fd----:allow
            group@:--------------:fd----:allow
         everyone@:--------------:fd----:allow

# all expect p
rm -rf $d

setfacl -m u:$u:rwxDdaARWcCos:fd:allow $p || exit 1
su -m $u -c "mkdir $d"
mkdir: /tank/project1/test3: Permission denied

getfacl $d
getfacl: /tank/project1/test3: stat() failed: No such file or directory

>How-To-Repeat:
p="/tank/project1"
d="$p/test3"
u="user1"

rm -rf $d
setfacl -b $p

setfacl -m group@::fd:allow $p || exit 1
setfacl -m everyone@::fd:allow $p || exit 1
setfacl -m owner@:rwx:fd:allow $p || exit 1
setfacl -m u:$u:rwx:fd:allow $p || exit 1
getfacl $p

su -m $u -c "mkdir $d"

setfacl -m u:$u:rwxp:fd:allow $p || exit 1
su -m $u -c "mkdir $d"

getfacl $d

# all expect p                                                                                            
rm -rf $d

setfacl -m u:$u:rwxDdaARWcCos:fd:allow $p || exit 1
su -m $u -c "mkdir $d"

getfacl $d

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Jan 7 03:59:39 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174949 
Responsible-Changed-From-To: freebsd-fs->trasz 
Responsible-Changed-By: trasz 
Responsible-Changed-When: Tue Jan 15 16:57:16 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174949 
State-Changed-From-To: open->closed 
State-Changed-By: trasz 
State-Changed-When: Mon Apr 1 13:00:34 UTC 2013 
State-Changed-Why:  
This is the valid behaviour - 'append_data', in SunOS also called 
'add_subdirectory', is what's required to create subdirectories. 
'write_file', aka 'add_file', permits creation of files. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174949 
>Unformatted:
