From kubito@gmail.com  Tue Dec 25 21:39:03 2012
Return-Path: <kubito@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 737B35AD
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Dec 2012 21:39:03 +0000 (UTC)
	(envelope-from kubito@gmail.com)
Received: from mail-la0-f50.google.com (mail-la0-f50.google.com [209.85.215.50])
	by mx1.freebsd.org (Postfix) with ESMTP id D91FF8FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Dec 2012 21:39:02 +0000 (UTC)
Received: by mail-la0-f50.google.com with SMTP id c1so9709382lah.23
        for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Dec 2012 13:39:01 -0800 (PST)
Received: from localhost (a91-154-115-217.elisa-laajakaista.fi. [91.154.115.217])
        by mx.google.com with ESMTPS id f8sm1904458lbg.2.2012.12.25.13.38.59
        (version=TLSv1/SSLv3 cipher=OTHER);
        Tue, 25 Dec 2012 13:39:00 -0800 (PST)
Message-Id: <50da1cf4.e819700a.2eec.55fe@mx.google.com>
Date: Tue, 25 Dec 2012 13:39:00 -0800 (PST)
From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
Sender: Raphael Kubo da Costa <kubito@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: freebsd-usb@FreeBSD.org, freebsd-bluetooth@FreeBSD.org
Subject: [PATCH] ng_ubt: Add vendor IDs for Broadcom USB dongles (BCM20702)
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         174707
>Category:       kern
>Synopsis:       [ng_ubt] [patch] Add vendor IDs for Broadcom USB dongles (BCM20702)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rakuco
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 25 21:40:00 UTC 2012
>Closed-Date:    Thu Apr 04 20:20:23 UTC 2013
>Last-Modified:  Thu Apr 11 22:20:00 UTC 2013
>Originator:     Raphael Kubo da Costa
>Release:        FreeBSD 9.1-PRERELEASE amd64
>Organization:
FreeBSD Project
>Environment:
System: FreeBSD gibbon 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #66: Tue Dec 25 20:12:02 EET 2012 root@gibbon:/usr/obj/usr/src/sys/GIBBON amd64


	
>Description:
	There are a few Broadcom USB-Bluetooth modules out there in the wild that currently fail to be recognized by ng_ubt.

	They all have the same vendor ID and the product IDs are all quite
	similar (mine is 0x21e8, for example). Instead of adding several
	entries, it is possible to match all devices by checking the vendor and
	interface class/subclass/protocol, which are always the same.
>How-To-Repeat:
	
>Fix:
Patch (which can be easily MFCed) attached.

--- ng_ubt-bcm-entries.diff begins here ---
Index: netgraph/bluetooth/drivers/ubt/ng_ubt.c
===================================================================
--- netgraph/bluetooth/drivers/ubt/ng_ubt.c	(revision 244687)
+++ netgraph/bluetooth/drivers/ubt/ng_ubt.c	(working copy)
@@ -398,6 +398,10 @@
 
 	/* AVM USB Bluetooth-Adapter BlueFritz! v2.0 */
 	{ USB_VPI(USB_VENDOR_AVM, 0x3800, 0) },
+
+	/* Broadcom USB dongles, mostly BCM20702 and BCM20702A0 */
+	{ USB_VENDOR(USB_VENDOR_BROADCOM),
+	  USB_IF_CSI(UICLASS_VENDOR, 0x01, 0x01) },
 };
 
 /*
--- ng_ubt-bcm-entries.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Dec 26 13:28:25 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174707 
State-Changed-From-To: open->patched 
State-Changed-By: glebius 
State-Changed-When: Wed Dec 26 15:04:32 UTC 2012 
State-Changed-Why:  
Committed, thanks! 


Responsible-Changed-From-To: freebsd-net->glebius 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Wed Dec 26 15:04:32 UTC 2012 
Responsible-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174707 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/174707: commit references a PR
Date: Wed, 26 Dec 2012 15:10:28 +0000 (UTC)

 Author: glebius
 Date: Wed Dec 26 15:10:20 2012
 New Revision: 244704
 URL: http://svnweb.freebsd.org/changeset/base/244704
 
 Log:
   Add vendor IDs for Broadcom USB dongles (BCM20702).
   
   PR:		kern/174707
   Submitted by:	rakuco
 
 Modified:
   head/share/man/man4/ng_ubt.4
   head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
 
 Modified: head/share/man/man4/ng_ubt.4
 ==============================================================================
 --- head/share/man/man4/ng_ubt.4	Wed Dec 26 15:07:23 2012	(r244703)
 +++ head/share/man/man4/ng_ubt.4	Wed Dec 26 15:10:20 2012	(r244704)
 @@ -25,7 +25,7 @@
  .\" $Id: ng_ubt.4,v 1.3 2003/05/21 19:37:35 max Exp $
  .\" $FreeBSD$
  .\"
 -.Dd September 13, 2004
 +.Dd December 26, 2012
  .Dt NG_UBT 4
  .Os
  .Sh NAME
 @@ -73,6 +73,8 @@ Mitsumi Bluetooth USB adapter
  MSI MS-6967
  .It
  TDK Bluetooth USB adapter
 +.It
 +Broadcom Bluetooth USB adapter
  .El
  .Sh HOOKS
  This node type supports the following hooks:
 
 Modified: head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
 ==============================================================================
 --- head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c	Wed Dec 26 15:07:23 2012	(r244703)
 +++ head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c	Wed Dec 26 15:10:20 2012	(r244704)
 @@ -398,6 +398,10 @@ static const STRUCT_USB_HOST_ID ubt_devs
  
  	/* AVM USB Bluetooth-Adapter BlueFritz! v2.0 */
  	{ USB_VPI(USB_VENDOR_AVM, 0x3800, 0) },
 +
 +	/* Broadcom USB dongles, mostly BCM20702 and BCM20702A0 */
 +	{ USB_VENDOR(USB_VENDOR_BROADCOM),
 +	  USB_IF_CSI(UICLASS_VENDOR, 0x01, 0x01) },
  };
  
  /*
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/174707: commit references a PR
Date: Wed, 26 Dec 2012 19:12:37 +0000 (UTC)

 Author: rakuco (ports committer)
 Date: Wed Dec 26 19:12:31 2012
 New Revision: 244714
 URL: http://svnweb.freebsd.org/changeset/base/244714
 
 Log:
   Use the correct USB interface macros instead of USB_IF_CSI.
   
   As pointed out by hselasky@, USB_IF_CSI is the wrong macro here since we want
   to declare the device's interface class, subclass and protocol, not class,
   subclass and driver info.
   
   Follow-up to r244704.
   
   PR:		kern/174707
   Approved by:	glebius
   MFC after:	1 week
 
 Modified:
   head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
 
 Modified: head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
 ==============================================================================
 --- head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c	Wed Dec 26 18:51:37 2012	(r244713)
 +++ head/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c	Wed Dec 26 19:12:31 2012	(r244714)
 @@ -401,7 +401,9 @@ static const STRUCT_USB_HOST_ID ubt_devs
  
  	/* Broadcom USB dongles, mostly BCM20702 and BCM20702A0 */
  	{ USB_VENDOR(USB_VENDOR_BROADCOM),
 -	  USB_IF_CSI(UICLASS_VENDOR, 0x01, 0x01) },
 +	  USB_IFACE_CLASS(UICLASS_VENDOR),
 +	  USB_IFACE_SUBCLASS(UDSUBCLASS_RF),
 +	  USB_IFACE_PROTOCOL(UDPROTO_BLUETOOTH) },
  };
  
  /*
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/174707: commit references a PR
Date: Wed,  2 Jan 2013 07:33:28 +0000 (UTC)

 Author: hselasky
 Date: Wed Jan  2 07:33:19 2013
 New Revision: 244956
 URL: http://svnweb.freebsd.org/changeset/base/244956
 
 Log:
   MFC r244704, r244714 and r244715:
   Add vendor IDs for Broadcom USB dongles (BCM20702).
   
   PR:		kern/174707
 
 Modified:
   stable/9/share/man/man4/ng_ubt.4
   stable/9/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
 Directory Properties:
   stable/9/share/   (props changed)
   stable/9/share/man/   (props changed)
   stable/9/share/man/man4/   (props changed)
   stable/9/sys/   (props changed)
 
 Modified: stable/9/share/man/man4/ng_ubt.4
 ==============================================================================
 --- stable/9/share/man/man4/ng_ubt.4	Wed Jan  2 04:29:35 2013	(r244955)
 +++ stable/9/share/man/man4/ng_ubt.4	Wed Jan  2 07:33:19 2013	(r244956)
 @@ -25,7 +25,7 @@
  .\" $Id: ng_ubt.4,v 1.3 2003/05/21 19:37:35 max Exp $
  .\" $FreeBSD$
  .\"
 -.Dd September 13, 2004
 +.Dd December 26, 2012
  .Dt NG_UBT 4
  .Os
  .Sh NAME
 @@ -73,6 +73,8 @@ Mitsumi Bluetooth USB adapter
  MSI MS-6967
  .It
  TDK Bluetooth USB adapter
 +.It
 +Broadcom Bluetooth USB adapter
  .El
  .Sh HOOKS
  This node type supports the following hooks:
 
 Modified: stable/9/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
 ==============================================================================
 --- stable/9/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c	Wed Jan  2 04:29:35 2013	(r244955)
 +++ stable/9/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c	Wed Jan  2 07:33:19 2013	(r244956)
 @@ -398,6 +398,12 @@ static const STRUCT_USB_HOST_ID ubt_devs
  
  	/* AVM USB Bluetooth-Adapter BlueFritz! v2.0 */
  	{ USB_VPI(USB_VENDOR_AVM, 0x3800, 0) },
 +
 +	/* Broadcom USB dongles, mostly BCM20702 and BCM20702A0 */
 +	{ USB_VENDOR(USB_VENDOR_BROADCOM),
 +	  USB_IFACE_CLASS(UICLASS_VENDOR),
 +	  USB_IFACE_SUBCLASS(UDSUBCLASS_RF),
 +	  USB_IFACE_PROTOCOL(UDPROTO_BLUETOOTH) },
  };
  
  /*
 @@ -1748,7 +1754,7 @@ static device_method_t	ubt_methods[] =
  	DEVMETHOD(device_probe,	ubt_probe),
  	DEVMETHOD(device_attach, ubt_attach),
  	DEVMETHOD(device_detach, ubt_detach),
 -	{ 0, 0 }
 +	DEVMETHOD_END
  };
  
  static driver_t		ubt_driver =
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
Responsible-Changed-From-To: glebius->rakuco 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Sun Jan 20 07:33:56 UTC 2013 
Responsible-Changed-Why:  
Let Raphael handle the MFC. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174707 

From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
To: glebius@FreeBSD.org
Cc: bug-followup@FreeBSD.org, freebsd-net@FreeBSD.org
Subject: Re: kern/174707: [ng_ubt] [patch] Add vendor IDs for Broadcom USB dongles (BCM20702)
Date: Sun, 20 Jan 2013 08:24:36 -0200

 glebius@FreeBSD.org writes:
 
 > Synopsis: [ng_ubt] [patch] Add vendor IDs for Broadcom USB dongles (BCM20702)
 >
 > Responsible-Changed-From-To: glebius->rakuco
 > Responsible-Changed-By: glebius
 > Responsible-Changed-When: Sun Jan 20 07:33:56 UTC 2013
 > Responsible-Changed-Why:
 > Let Raphael handle the MFC.
 
 hselasky@ has already MFC'ed this to 9 a while ago. Do you think it is
 safe enough to MFC to 8 and 7?

From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Raphael Kubo da Costa <rakuco@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, freebsd-net@FreeBSD.org
Subject: Re: kern/174707: [ng_ubt] [patch] Add vendor IDs for Broadcom USB
 dongles (BCM20702)
Date: Sun, 20 Jan 2013 14:45:26 +0400

 On Sun, Jan 20, 2013 at 08:24:36AM -0200, Raphael Kubo da Costa wrote:
 R> glebius@FreeBSD.org writes:
 R> 
 R> > Synopsis: [ng_ubt] [patch] Add vendor IDs for Broadcom USB dongles (BCM20702)
 R> >
 R> > Responsible-Changed-From-To: glebius->rakuco
 R> > Responsible-Changed-By: glebius
 R> > Responsible-Changed-When: Sun Jan 20 07:33:56 UTC 2013
 R> > Responsible-Changed-Why:
 R> > Let Raphael handle the MFC.
 R> 
 R> hselasky@ has already MFC'ed this to 9 a while ago. Do you think it is
 R> safe enough to MFC to 8 and 7?
 
 You and Hans decide.
 
 The PR can be closed since fix already reached a stable branch.
 
 -- 
 Totus tuus, Glebius.

From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
To: hselasky@FreeBSD.org
Cc: bug-followup@FreeBSD.org,  freebsd-net@FreeBSD.org
Subject: Re: kern/174707: [ng_ubt] [patch] Add vendor IDs for Broadcom USB dongles (BCM20702)
Date: Sun, 27 Jan 2013 15:15:53 +0200

 Gleb Smirnoff <glebius@FreeBSD.org> writes:
 
 > On Sun, Jan 20, 2013 at 08:24:36AM -0200, Raphael Kubo da Costa wrote:
 > R> glebius@FreeBSD.org writes:
 > R> 
 > R> > Synopsis: [ng_ubt] [patch] Add vendor IDs for Broadcom USB
 > R> > dongles (BCM20702)
 > R> >
 > R> > Responsible-Changed-From-To: glebius->rakuco
 > R> > Responsible-Changed-By: glebius
 > R> > Responsible-Changed-When: Sun Jan 20 07:33:56 UTC 2013
 > R> > Responsible-Changed-Why:
 > R> > Let Raphael handle the MFC.
 > R> 
 > R> hselasky@ has already MFC'ed this to 9 a while ago. Do you think it is
 > R> safe enough to MFC to 8 and 7?
 >
 > You and Hans decide.
 >
 > The PR can be closed since fix already reached a stable branch.
 
 Hans, do you think it makes sense to MFC this to the other stable
 branches? I don't have 7 and 8 systems at hand to test this patch, so
 I'd like your feedback on the issue.
 
 Thanks.

From: Hans Petter Selasky <hselasky@c2i.net>
To: Raphael Kubo da Costa <rakuco@freebsd.org>
Cc: bug-followup@freebsd.org,
 freebsd-net@freebsd.org
Subject: Re: kern/174707: [ng_ubt] [patch] Add vendor IDs for Broadcom USB dongles (BCM20702)
Date: Sun, 27 Jan 2013 17:10:37 +0100

 On Sunday 27 January 2013 14:15:53 Raphael Kubo da Costa wrote:
 > Gleb Smirnoff <glebius@FreeBSD.org> writes:
 > > On Sun, Jan 20, 2013 at 08:24:36AM -0200, Raphael Kubo da Costa wrote:
 > > R> glebius@FreeBSD.org writes:
 > > R>
 > > R> > Synopsis: [ng_ubt] [patch] Add vendor IDs for Broadcom USB
 > > R> > dongles (BCM20702)
 > > R> >
 > > R> > Responsible-Changed-From-To: glebius->rakuco
 > > R> > Responsible-Changed-By: glebius
 > > R> > Responsible-Changed-When: Sun Jan 20 07:33:56 UTC 2013
 > > R> > Responsible-Changed-Why:
 > > R> > Let Raphael handle the MFC.
 > > R>
 > > R> hselasky@ has already MFC'ed this to 9 a while ago. Do you think it is
 > > R> safe enough to MFC to 8 and 7?
 > > 
 > > You and Hans decide.
 > > 
 > > The PR can be closed since fix already reached a stable branch.
 > 
 > Hans, do you think it makes sense to MFC this to the other stable
 > branches? I don't have 7 and 8 systems at hand to test this patch, so
 > I'd like your feedback on the issue.
 
 Yes, 8 at least. Could try 7 too, but then you need to translate the patch 
 into the old USB stack.
 
 --HPS

From: Raphael Kubo da Costa <rakuco@freebsd.org>
To: Hans Petter Selasky <hselasky@c2i.net>
Cc: bug-followup@freebsd.org,  freebsd-net@freebsd.org
Subject: Re: kern/174707: [ng_ubt] [patch] Add vendor IDs for Broadcom USB dongles (BCM20702)
Date: Sun, 27 Jan 2013 20:29:48 +0200

 Hans Petter Selasky <hselasky@c2i.net> writes:
 
 >> Hans, do you think it makes sense to MFC this to the other stable
 >> branches? I don't have 7 and 8 systems at hand to test this patch, so
 >> I'd like your feedback on the issue.
 >
 > Yes, 8 at least. Could try 7 too, but then you need to translate the patch
 > into the old USB stack.
 
 Right, I guess it's OK to leave 7 out. Are you willing to perform the
 MFC or would you like me to take care of it?

From: Hans Petter Selasky <hselasky@c2i.net>
To: Raphael Kubo da Costa <rakuco@freebsd.org>
Cc: bug-followup@freebsd.org,
 freebsd-net@freebsd.org
Subject: Re: kern/174707: [ng_ubt] [patch] Add vendor IDs for Broadcom USB dongles (BCM20702)
Date: Sun, 27 Jan 2013 20:08:24 +0100

 On Sunday 27 January 2013 19:29:48 Raphael Kubo da Costa wrote:
 > Hans Petter Selasky <hselasky@c2i.net> writes:
 > >> Hans, do you think it makes sense to MFC this to the other stable
 > >> branches? I don't have 7 and 8 systems at hand to test this patch, so
 > >> I'd like your feedback on the issue.
 > > 
 > > Yes, 8 at least. Could try 7 too, but then you need to translate the
 > > patch into the old USB stack.
 > 
 > Right, I guess it's OK to leave 7 out. Are you willing to perform the
 > MFC or would you like me to take care of it?
 
 Please do the MFC! I'm quite busy and might forget to do such stuff :-)
 
 --HPS

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/174707: commit references a PR
Date: Thu,  4 Apr 2013 19:31:37 +0000 (UTC)

 Author: rakuco (ports committer)
 Date: Thu Apr  4 19:31:19 2013
 New Revision: 249107
 URL: http://svnweb.freebsd.org/changeset/base/249107
 
 Log:
   MFC r244704, r244714 and r244715:
   Add vendor IDs for Broadcom USB dongles (BCM20702).
   
   PR:		kern/174707
   Approved by:	glebius
 
 Modified:
   stable/8/share/man/man4/ng_ubt.4
   stable/8/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
 Directory Properties:
   stable/8/share/man/man4/   (props changed)
   stable/8/sys/   (props changed)
   stable/8/sys/netgraph/   (props changed)
 
 Modified: stable/8/share/man/man4/ng_ubt.4
 ==============================================================================
 --- stable/8/share/man/man4/ng_ubt.4	Thu Apr  4 19:07:37 2013	(r249106)
 +++ stable/8/share/man/man4/ng_ubt.4	Thu Apr  4 19:31:19 2013	(r249107)
 @@ -25,7 +25,7 @@
  .\" $Id: ng_ubt.4,v 1.3 2003/05/21 19:37:35 max Exp $
  .\" $FreeBSD$
  .\"
 -.Dd September 13, 2004
 +.Dd December 26, 2012
  .Dt NG_UBT 4
  .Os
  .Sh NAME
 @@ -73,6 +73,8 @@ Mitsumi Bluetooth USB adapter
  MSI MS-6967
  .It
  TDK Bluetooth USB adapter
 +.It
 +Broadcom Bluetooth USB adapter
  .El
  .Sh HOOKS
  This node type supports the following hooks:
 
 Modified: stable/8/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
 ==============================================================================
 --- stable/8/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c	Thu Apr  4 19:07:37 2013	(r249106)
 +++ stable/8/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c	Thu Apr  4 19:31:19 2013	(r249107)
 @@ -398,6 +398,12 @@ static const STRUCT_USB_HOST_ID ubt_devs
  
  	/* AVM USB Bluetooth-Adapter BlueFritz! v2.0 */
  	{ USB_VPI(USB_VENDOR_AVM, 0x3800, 0) },
 +
 +	/* Broadcom USB dongles, mostly BCM20702 and BCM20702A0 */
 +	{ USB_VENDOR(USB_VENDOR_BROADCOM),
 +	  USB_IFACE_CLASS(UICLASS_VENDOR),
 +	  USB_IFACE_SUBCLASS(UDSUBCLASS_RF),
 +	  USB_IFACE_PROTOCOL(UDPROTO_BLUETOOTH) },
  };
  
  /*
 @@ -1748,7 +1754,7 @@ static device_method_t	ubt_methods[] =
  	DEVMETHOD(device_probe,	ubt_probe),
  	DEVMETHOD(device_attach, ubt_attach),
  	DEVMETHOD(device_detach, ubt_detach),
 -	{ 0, 0 }
 +	DEVMETHOD_END
  };
  
  static driver_t		ubt_driver =
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: rakuco 
State-Changed-When: Thu Apr 4 20:20:23 UTC 2013 
State-Changed-Why:  
Finally merged into 8 :-) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174707 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/174707: commit references a PR
Date: Thu, 11 Apr 2013 22:10:24 +0000 (UTC)

 Author: rakuco (ports committer)
 Date: Thu Apr 11 22:10:15 2013
 New Revision: 249389
 URL: http://svnweb.freebsd.org/changeset/base/249389
 
 Log:
   MFS8 r249107:
   Add vendor IDs for Broadcom USB dongles (BCM20702).
   
   PR:		kern/174707
   Approved by:	re (kib), glebius
 
 Modified:
   releng/8.4/share/man/man4/ng_ubt.4
   releng/8.4/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
 Directory Properties:
   releng/8.4/share/man/man4/   (props changed)
   releng/8.4/sys/   (props changed)
   releng/8.4/sys/netgraph/   (props changed)
 
 Modified: releng/8.4/share/man/man4/ng_ubt.4
 ==============================================================================
 --- releng/8.4/share/man/man4/ng_ubt.4	Thu Apr 11 22:08:59 2013	(r249388)
 +++ releng/8.4/share/man/man4/ng_ubt.4	Thu Apr 11 22:10:15 2013	(r249389)
 @@ -25,7 +25,7 @@
  .\" $Id: ng_ubt.4,v 1.3 2003/05/21 19:37:35 max Exp $
  .\" $FreeBSD$
  .\"
 -.Dd September 13, 2004
 +.Dd December 26, 2012
  .Dt NG_UBT 4
  .Os
  .Sh NAME
 @@ -73,6 +73,8 @@ Mitsumi Bluetooth USB adapter
  MSI MS-6967
  .It
  TDK Bluetooth USB adapter
 +.It
 +Broadcom Bluetooth USB adapter
  .El
  .Sh HOOKS
  This node type supports the following hooks:
 
 Modified: releng/8.4/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
 ==============================================================================
 --- releng/8.4/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c	Thu Apr 11 22:08:59 2013	(r249388)
 +++ releng/8.4/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c	Thu Apr 11 22:10:15 2013	(r249389)
 @@ -398,6 +398,12 @@ static const STRUCT_USB_HOST_ID ubt_devs
  
  	/* AVM USB Bluetooth-Adapter BlueFritz! v2.0 */
  	{ USB_VPI(USB_VENDOR_AVM, 0x3800, 0) },
 +
 +	/* Broadcom USB dongles, mostly BCM20702 and BCM20702A0 */
 +	{ USB_VENDOR(USB_VENDOR_BROADCOM),
 +	  USB_IFACE_CLASS(UICLASS_VENDOR),
 +	  USB_IFACE_SUBCLASS(UDSUBCLASS_RF),
 +	  USB_IFACE_PROTOCOL(UDPROTO_BLUETOOTH) },
  };
  
  /*
 @@ -1748,7 +1754,7 @@ static device_method_t	ubt_methods[] =
  	DEVMETHOD(device_probe,	ubt_probe),
  	DEVMETHOD(device_attach, ubt_attach),
  	DEVMETHOD(device_detach, ubt_detach),
 -	{ 0, 0 }
 +	DEVMETHOD_END
  };
  
  static driver_t		ubt_driver =
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
