From nobody@FreeBSD.org  Sat Nov 24 21:51:46 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9EA09E40
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 24 Nov 2012 21:51:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 83F0F8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 24 Nov 2012 21:51:46 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id qAOLpjt7076533
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 24 Nov 2012 21:51:45 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id qAOLpjVg076526;
	Sat, 24 Nov 2012 21:51:45 GMT
	(envelope-from nobody)
Message-Id: <201211242151.qAOLpjVg076526@red.freebsd.org>
Date: Sat, 24 Nov 2012 21:51:45 GMT
From: Johannes Meixner <xmj@chaot.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: iwn(4) DOES support 6235 chip.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         173898
>Category:       kern
>Synopsis:       [iwn] [patch] iwn(4) DOES support 6235 chip.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-wireless
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 24 22:00:00 UTC 2012
>Closed-Date:    Tue Feb 11 05:27:10 UTC 2014
>Last-Modified:  Tue Feb 11 05:27:10 UTC 2014
>Originator:     Johannes Meixner
>Release:        10.0-CURRENT
>Organization:
Goldener Grund O
>Environment:
FreeBSD 10.0-CURRENT #7 r243502M: Sat Nov 24 22:51:00 EET 2012
>Description:
As a follow-up to 

kern/169433: iwn(4) doesn't support 6235 chip.

and

http://forums.freebsd.org/showthread.php?t=35467 

I managed to get WiFi running on my Intel Centrino Advanced-N 6235 chip 
on the newest firmware downloaded from http://intellinuxwireless.org/ . After finding out the chip's numbers with pciconf -lbcev I added one line to if_iwn.c, recompiled the module and it worked. 

Please find attached the output from `svn diff` in /usr/src.

Required steps in order to get it working are documented in the forum post mentioned above.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: sys/dev/iwn/if_iwn.c
===================================================================
--- sys/dev/iwn/if_iwn.c	(revision 243502)
+++ sys/dev/iwn/if_iwn.c	(working copy)
@@ -93,6 +93,7 @@
 	{ 0x8086, 0x0886, "Intel Centrino Wireless-N + WiMAX 6150"	},
 	{ 0x8086, 0x0896, "Intel Centrino Wireless-N 130"		},
 	{ 0x8086, 0x0887, "Intel Centrino Wireless-N 130"		},
+	{ 0x8086, 0x088e, "Intel Centrino Advanced-N 6235"              },
 	{ 0x8086, 0x08ae, "Intel Centrino Wireless-N 100"		},
 	{ 0x8086, 0x08af, "Intel Centrino Wireless-N 100"		},
 	{ 0x8086, 0x4229, "Intel Wireless WiFi Link 4965"		},
Index: sys/modules/iwnfw/iwn6000g2b/Makefile
===================================================================
--- sys/modules/iwnfw/iwn6000g2b/Makefile	(revision 243502)
+++ sys/modules/iwnfw/iwn6000g2b/Makefile	(working copy)
@@ -1,6 +1,6 @@
 # $FreeBSD$
 
 KMOD=	iwn6000g2bfw
-IMG=	iwlwifi-6000g2b-17.168.5.2
+IMG=	iwlwifi-6000g2b-18.168.6.1
 
 .include <bsd.kmod.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-wireless 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Nov 24 22:21:03 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173898 
Responsible-Changed-From-To: freebsd-wireless->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Fri Nov 30 23:25:59 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173898 

From: Eitan Adler <eadler@freebsd.org>
To: Adrian Chadd <adrian@freebsd.org>, davide@freebsd.org
Cc: freebsd-wireless@freebsd.org, bug-followup@freebsd.org
Subject: Re: kern/173898: [iwn] [patch] iwn(4) DOES support 6235 chip.
Date: Fri, 30 Nov 2012 23:59:22 -0500

 On 30 November 2012 20:28, Adrian Chadd <adrian@freebsd.org> wrote:
 > It's not that simple. Speak to bernhard.
 
 
 Davide, You mention some issues and I asked you to follow up to the
 PR.  Can you please explain them?
 
 > There are other issues that he knows about. I don't know if he's
 > replied to the email or not; poke him on irc.
 
 IRC doesn't help as the record does not go into the PR
 
 
 -- 
 Eitan Adler
 Source, Ports, Doc committer
 Bugmeister, Ports Security teams

From: Bernhard Schmidt <bschmidt@freebsd.org>
To: freebsd-wireless@freebsd.org,
 bug-followup@freebsd.org
Cc: Eitan Adler <eadler@freebsd.org>,
 Adrian Chadd <adrian@freebsd.org>,
 davide@freebsd.org
Subject: Re: kern/173898: [iwn] [patch] iwn(4) DOES support 6235 chip.
Date: Wed, 12 Dec 2012 22:38:59 +0100

 On Saturday 01 December 2012 05:59:22 Eitan Adler wrote:
 > On 30 November 2012 20:28, Adrian Chadd <adrian@freebsd.org> wrote:
 > > It's not that simple. Speak to bernhard.
 > 
 > 
 > Davide, You mention some issues and I asked you to follow up to the
 > PR.  Can you please explain them?
 > 
 > > There are other issues that he knows about. I don't know if he's
 > > replied to the email or not; poke him on irc.
 > 
 > IRC doesn't help as the record does not go into the PR
 
 For the record.. I thought I mentioned this in another PR already.
 
 Using the new firmware and adding the PCI IDs is enough to detect
 the cards and get some basic stuff working. The major part of the
 features is not though. At least on 11n HT40 you will definitely
 get a firmware crash. Also, the throughput sucks, even in legacy
 mode.
 
 I'm not able to pin the cause, working on it. Johannes is also
 looking into it.
 
 -- 
 Bernhard
Responsible-Changed-From-To: eadler->freebsd-wireless 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Thu Jan 31 13:58:15 UTC 2013 
Responsible-Changed-Why:  
sorry I held on to this for so long;   at the moment I have no time to 
look at this PR so return to the pool 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173898 

From: Ahmed Charles <ahmedcharles@gmail.com>
To: bug-followup@FreeBSD.org, xmj@chaot.net
Cc:  
Subject: Re: kern/173898: [iwn] [patch] iwn(4) DOES support 6235 chip.
Date: Mon, 11 Feb 2013 11:22:05 -0800

 Note: There is also a reference to the firmware in sys/conf/files.
 
 -- 
 Ahmed Charles
State-Changed-From-To: open->closed 
State-Changed-By: adrian 
State-Changed-When: Tue Feb 11 05:26:58 UTC 2014 
State-Changed-Why:  
Fixed in- HEAD 


http://www.freebsd.org/cgi/query-pr.cgi?pr=173898 
>Unformatted:
