From pete@zfsmaster.secroom.net  Wed Nov  7 10:13:12 2012
Return-Path: <pete@zfsmaster.secroom.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0948DBE4
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Nov 2012 10:13:12 +0000 (UTC)
	(envelope-from pete@zfsmaster.secroom.net)
Received: from zfsmaster.secroom.net (r068.secroom.net [193.19.137.68])
	by mx1.freebsd.org (Postfix) with ESMTP id 8E6408FC14
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Nov 2012 10:13:10 +0000 (UTC)
Received: from zfsmaster.secroom.net (localhost [127.0.0.1])
	by zfsmaster.secroom.net (8.14.5/8.14.5) with ESMTP id qA76is7I006116
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 7 Nov 2012 06:44:54 GMT
	(envelope-from pete@zfsmaster.secroom.net)
Received: (from root@localhost)
	by zfsmaster.secroom.net (8.14.5/8.14.5/Submit) id qA76irdQ006115;
	Wed, 7 Nov 2012 06:44:53 GMT
	(envelope-from pete)
Message-Id: <201211070644.qA76irdQ006115@zfsmaster.secroom.net>
Date: Wed, 7 Nov 2012 06:44:53 GMT
From: Petri Helenius <pete@secroom.com>
Reply-To: Petri Helenius <pete@secroom.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: ZFS ZVOL snapshot device nodes are not removed
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         173442
>Category:       kern
>Synopsis:       [zfs] ZFS ZVOL snapshot device nodes are not removed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    avg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 07 10:20:00 UTC 2012
>Closed-Date:    Sat Dec 01 18:24:07 UTC 2012
>Last-Modified:  Sat Dec 01 18:24:07 UTC 2012
>Originator:     Petri Helenius
>Release:        FreeBSD 9.1-RC2 amd64
>Organization:
>Environment:
System: FreeBSD zfsmaster.secroom.net 9.1-RC2 FreeBSD 9.1-RC2 #0: Sun Oct 28 09:06:44 UTC 2012 pete@zfsmaster.secroom.net:/usr/obj/usr/src/sys/XENSR amd64


>Description:
	The zvol snapshots are not removed from /dev/zvol until reboot
>How-To-Repeat:
zfsmaster# zfs create  zroot/iscsi
zfsmaster# zfs create -V 50M zroot/iscsi/test1
zfsmaster# zfs create -V 50M zroot/iscsi/test2
zfsmaster# cd /dev/zvol/zroot/
zfsmaster# cd /dev/zvol/zroot/
iscsi/  swap%   swap@1% swap@3% swap@6% 
zfsmaster# cd /dev/zvol/zroot/iscsi/
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
zfsmaster# zfs snapshot -r zroot/iscsi@snap1
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
zfsmaster# zfs snapshot -r zroot/iscsi@snap2
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
zfsmaster# zfs snapshot -r zroot/iscsi@snap3
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 107 Nov  7 06:36 test1@snap3
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
crw-r-----  1 root  operator    0, 108 Nov  7 06:36 test2@snap3
zfsmaster# zfs snapshot -r zroot/iscsi@snap4
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 107 Nov  7 06:36 test1@snap3
crw-r-----  1 root  operator    0, 109 Nov  7 06:36 test1@snap4
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
crw-r-----  1 root  operator    0, 108 Nov  7 06:36 test2@snap3
crw-r-----  1 root  operator    0, 110 Nov  7 06:36 test2@snap4
zfsmaster# zfs destroy -r zroot/iscsi@snap2
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 107 Nov  7 06:36 test1@snap3
crw-r-----  1 root  operator    0, 109 Nov  7 06:36 test1@snap4
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
crw-r-----  1 root  operator    0, 108 Nov  7 06:36 test2@snap3
crw-r-----  1 root  operator    0, 110 Nov  7 06:36 test2@snap4
zfsmaster# zfs destroy -r zroot/iscsi@snap1
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 107 Nov  7 06:36 test1@snap3
crw-r-----  1 root  operator    0, 109 Nov  7 06:36 test1@snap4
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
crw-r-----  1 root  operator    0, 108 Nov  7 06:36 test2@snap3
crw-r-----  1 root  operator    0, 110 Nov  7 06:36 test2@snap4
zfsmaster# zfs destroy -r zroot/iscsi@snap3
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 107 Nov  7 06:36 test1@snap3
crw-r-----  1 root  operator    0, 109 Nov  7 06:36 test1@snap4
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
crw-r-----  1 root  operator    0, 108 Nov  7 06:36 test2@snap3
crw-r-----  1 root  operator    0, 110 Nov  7 06:36 test2@snap4
zfsmaster# zfs destroy -r zroot/iscsi@snap4
zfsmaster# ls -l
total 0
crw-r-----  1 root  operator    0, 100 Nov  7 06:35 test1
crw-r-----  1 root  operator    0, 103 Nov  7 06:36 test1@snap1
crw-r-----  1 root  operator    0, 105 Nov  7 06:36 test1@snap2
crw-r-----  1 root  operator    0, 107 Nov  7 06:36 test1@snap3
crw-r-----  1 root  operator    0, 109 Nov  7 06:36 test1@snap4
crw-r-----  1 root  operator    0, 102 Nov  7 06:35 test2
crw-r-----  1 root  operator    0, 104 Nov  7 06:36 test2@snap1
crw-r-----  1 root  operator    0, 106 Nov  7 06:36 test2@snap2
crw-r-----  1 root  operator    0, 108 Nov  7 06:36 test2@snap3
crw-r-----  1 root  operator    0, 110 Nov  7 06:36 test2@snap4
zfsmaster# dd if=test1@snap1 of=/dev/null
dd: test1@snap1: No such file or directory
zfsmaster# zfs snapshot -r zroot/iscsi@snap5
zfsmaster# dd if=test1@snap5 of=/dev/null
102400+0 records in
102400+0 records out
52428800 bytes transferred in 2.021984 secs (25929383 bytes/sec)
zfsmaster# 

>Fix:

	


>Release-Note:
>Audit-Trail:

From: Petri Helenius <petri@helenius.fi>
To: bug-followup@FreeBSD.org,
 pete@secroom.com
Cc:  
Subject: Re: kern/173442: ZFS ZVOL snapshot device nodes are not removed
Date: Wed, 7 Nov 2012 12:53:23 +0200

 https://www.illumos.org/issues/3170
 

From: Andriy Gapon <avg@FreeBSD.org>
To: bug-followup@FreeBSD.org, pete@secroom.com
Cc:  
Subject: Re: kern/173442: ZFS ZVOL snapshot device nodes are not removed
Date: Wed, 07 Nov 2012 22:29:27 +0200

 Can you confirm that the proposed fix in the Illumos bug report works for you?
 
 -- 
 Andriy Gapon

From: Petri Helenius <petri@helenius.fi>
To: bug-followup@FreeBSD.org,
 pete@secroom.com
Cc:  
Subject: Re: kern/173442: ZFS ZVOL snapshot device nodes are not removed
Date: Thu, 8 Nov 2012 08:28:17 +0200

 On 9.1-RC3 it works for me.
 
 Pete
 
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Nov 8 23:50:02 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173442 
Responsible-Changed-From-To: freebsd-fs->avg 
Responsible-Changed-By: avg 
Responsible-Changed-When: Sat Nov 10 12:34:30 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173442 
State-Changed-From-To: open->patched 
State-Changed-By: avg 
State-Changed-When: Mon Nov 19 12:40:07 UTC 2012 
State-Changed-Why:  
Patched in head. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173442 
State-Changed-From-To: patched->closed 
State-Changed-By: avg 
State-Changed-When: Sat Dec 1 18:23:56 UTC 2012 
State-Changed-Why:  
Should be fixed now. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173442 
>Unformatted:
