From nobody@FreeBSD.org  Fri Nov  2 09:37:18 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 49E98123
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  2 Nov 2012 09:37:18 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 327C78FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  2 Nov 2012 09:37:18 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id qA29bHRX057285
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 2 Nov 2012 09:37:17 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id qA29bHfB057284;
	Fri, 2 Nov 2012 09:37:17 GMT
	(envelope-from nobody)
Message-Id: <201211020937.qA29bHfB057284@red.freebsd.org>
Date: Fri, 2 Nov 2012 09:37:17 GMT
From: Steven Hartland <steven.hartland@multiplay.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Add deviceid to mfi disk startup output (patch included)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         173290
>Category:       kern
>Synopsis:       [mfi] [patch] Add deviceid to mfi disk startup output (patch included)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 02 09:40:00 UTC 2012
>Closed-Date:    Mon Feb 04 00:39:35 UTC 2013
>Last-Modified:  Mon Feb 04 00:39:35 UTC 2013
>Originator:     Steven Hartland
>Release:        8.3-RELEASE
>Organization:
Multiplay
>Environment:
FreeBSD dev 8.3-RELEASE-p4 FreeBSD 8.3-RELEASE-p4 #22: Mon Sep 17 17:18:32 UTC 2012     root@dev:/usr/obj/usr/src/sys/MULTIPLAY  amd64
>Description:
Adds deviceid to the disk output on boot which is extremely useful in correlating mfi drive in mfiutil / MegaCli to OS device
>How-To-Repeat:
N/A
>Fix:
Apply the attached patch

Patch attached with submission follows:

--- sys/dev/mfi/mfi_syspd.c.orig	2012-10-31 12:59:47.552155217 +0000
+++ sys/dev/mfi/mfi_syspd.c	2012-10-31 13:03:43.566282448 +0000
@@ -116,8 +116,8 @@
 	mtx_lock(&sc->pd_controller->mfi_io_lock);
 	TAILQ_INSERT_TAIL(&sc->pd_controller->mfi_syspd_tqh, sc, pd_link);
 	mtx_unlock(&sc->pd_controller->mfi_io_lock);
-	device_printf(dev, "%juMB (%ju sectors) SYSPD volume\n",
-		      sectors / (1024 * 1024 / secsize), sectors);
+	device_printf(dev, "%juMB (%ju sectors) SYSPD volume (deviceid: %d)\n",
+		      sectors / (1024 * 1024 / secsize), sectors, sc->pd_id);
 	sc->pd_disk = disk_alloc();
 	sc->pd_disk->d_drv1 = sc;
 	sc->pd_disk->d_maxsize = sc->pd_controller->mfi_max_io * secsize;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Fri Nov 9 01:56:23 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173290 
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Fri Nov 9 12:44:41 UTC 2012 
State-Changed-Why:  
awaiting approval or review prior to commit (no action needed from 
submitter) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173290 
State-Changed-From-To: analyzed->patched 
State-Changed-By: eadler 
State-Changed-When: Thu Nov 15 18:35:57 UTC 2012 
State-Changed-Why:  
committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173290 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Mon Feb 4 00:39:33 UTC 2013 
State-Changed-Why:  
MFCed/fixed by now or it will never be MFCed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173290 
>Unformatted:
