From nobody@FreeBSD.org  Sat Sep 29 14:04:44 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9511D106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 29 Sep 2012 14:04:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 7FE3E8FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 29 Sep 2012 14:04:44 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q8TE4hFu005291
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 29 Sep 2012 14:04:43 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id q8TE4hQS005290;
	Sat, 29 Sep 2012 14:04:43 GMT
	(envelope-from nobody)
Message-Id: <201209291404.q8TE4hQS005290@red.freebsd.org>
Date: Sat, 29 Sep 2012 14:04:43 GMT
From: Petr Lampa <lampa@fit.vutbr.cz>
To: freebsd-gnats-submit@FreeBSD.org
Subject: 1.95.2.2 revision of amr.c breaks amrstat
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         172160
>Category:       kern
>Synopsis:       1.95.2.2 revision of amr.c breaks amrstat
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jhb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 29 14:10:04 UTC 2012
>Closed-Date:    Mon Mar 04 18:58:54 UTC 2013
>Last-Modified:  Mon Mar 04 18:58:54 UTC 2013
>Originator:     Petr Lampa
>Release:        9.1-PRERELEASE
>Organization:
BUT FIT
>Environment:
FreeBSD xxx 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #1: Sat Sep 29 10:39:13 CEST 2012     eeee:/usr/src/sys/amd64/compile/KAZI  amd64

>Description:
amrstat stopped working at all after 1.95.2.2 revision of amr.c




>How-To-Repeat:

>Fix:
this change seems to be sufficient to get amrstat working again:

*** amr.c       2012-05-30 18:13:10.000000000 +0200
--- amr.c.my    2012-09-21 10:12:37.000000000 +0200
***************
*** 919,925 ****

      /* build the command */
      ac->ac_data = dp;
!     ac->ac_length = real_length;
      ac->ac_flags |= AMR_CMD_DATAIN|AMR_CMD_DATAOUT;

      /* run the command */
--- 919,925 ----

      /* build the command */
      ac->ac_data = dp;
!     ac->ac_length = au_length;
      ac->ac_flags |= AMR_CMD_DATAIN|AMR_CMD_DATAOUT;

      /* run the command */


>Release-Note:
>Audit-Trail:

From: Thomas Johnson <tom@claimlynx.com>
To: bug-followup@FreeBSD.org, lampa@fit.vutbr.cz
Cc: root <root@claimlynx.com>
Subject: Re: kern/172160: 1.95.2.2 revision of amr.c breaks amrstat
Date: Fri, 7 Dec 2012 08:12:29 -0600

 --047d7b2ed6b9564c4a04d043ce61
 Content-Type: text/plain; charset=ISO-8859-1
 
 We encountered the same/similar behavior on a pair of Dell 1750 servers
 (i386). In our experience, amrstat works intermittently, with no apparent
 cause for it to work/not work.
 
 We applied the suggested patch on 12/3/12, and have not seen any issues
 since.
 
 --047d7b2ed6b9564c4a04d043ce61
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 We encountered the same/similar behavior on a pair of Dell 1750 servers (i3=
 86). In our experience, amrstat works intermittently, with no apparent caus=
 e for it to work/not work.<br><br>We applied the suggested patch on 12/3/12=
 , and have not seen any issues since.<br>
 
 
 --047d7b2ed6b9564c4a04d043ce61--
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Fri Dec 7 16:12:25 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172160 

From: John Baldwin <jhb@FreeBSD.org>
To: bug-followup@FreeBSD.org, lampa@fit.vutbr.cz
Cc:  
Subject: Re: kern/172160: 1.95.2.2 revision of amr.c breaks amrstat
Date: Fri, 07 Dec 2012 15:48:55 -0500

 That patch does not fix this.  It just reverts the bug fix exposing you
 to all the previous problems.  The proper fix is to backport r240692 and
 r241228 from HEAD to 9.  Please see the original PR kern/155658 for more
 discussion on this.
 
 -- 
 John Baldwin
Responsible-Changed-From-To: eadler->jhb 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sun Dec 9 00:53:12 UTC 2012 
Responsible-Changed-Why:  
per discussion - see kern/155658 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172160 
State-Changed-From-To: open->closed 
State-Changed-By: jhb 
State-Changed-When: Mon Mar 4 18:58:36 UTC 2013 
State-Changed-Why:  
The fix was merged to 8 and 9 last week. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172160 
>Unformatted:
