From emaste@FreeBSD.org  Tue Sep 25 20:40:45 2012
Return-Path: <emaste@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A0A8A106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Sep 2012 20:40:45 +0000 (UTC)
	(envelope-from emaste@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 8C07D8FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Sep 2012 20:40:45 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q8PKejLk072823
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Sep 2012 20:40:45 GMT
	(envelope-from emaste@freefall.freebsd.org)
Received: (from emaste@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q8PKejqJ072822;
	Tue, 25 Sep 2012 20:40:45 GMT
	(envelope-from emaste)
Message-Id: <201209252040.q8PKejqJ072822@freefall.freebsd.org>
Date: Tue, 25 Sep 2012 20:40:45 GMT
From: Ed Maste <emaste@FreeBSD.org>
Reply-To: Ed Maste <emaste@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: panic if an in-use tap interface is destroyed
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         172075
>Category:       kern
>Synopsis:       [tap] [panic] panic if an in-use tap interface is destroyed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    emaste
>State:          patched
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 25 20:50:09 UTC 2012
>Closed-Date:    
>Last-Modified:  Fri Nov 30 14:40:35 UTC 2012
>Originator:     Ed Maste
>Release:        FreeBSD 9.0-STABLE i386
>Organization:
FreeBSD
>Environment:
System: FreeBSD freefall.freebsd.org 9.0-STABLE FreeBSD 9.0-STABLE #6 r235139: Tue May 8 21:19:03 UTC 2012 simon@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL i386

>Description:

tap_destroy contains an assertion that the tap device
is not open, which causes a panic if attempting to
destroy that tap device.

   211  static void
   212  tap_destroy(struct tap_softc *tp)
   213  {
   214          struct ifnet *ifp = tp->tap_ifp;
   215  
   216          /* Unlocked read. */
   217          KASSERT(!(tp->tap_flags & TAP_OPEN),
   218                  ("%s flags is out of sync", ifp->if_xname));

>How-To-Repeat:

# ifconfig tap0 create
# cat /dev/tap0 &
# ifconfig tap0 destroy

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->emaste 
Responsible-Changed-By: emaste 
Responsible-Changed-When: Tue Sep 25 21:17:03 UTC 2012 
Responsible-Changed-Why:  
I am going to fix it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172075 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/172075: commit references a PR
Date: Wed, 26 Sep 2012 00:25:23 +0000 (UTC)

 Author: emaste
 Date: Wed Sep 26 00:25:09 2012
 New Revision: 240944
 URL: http://svn.freebsd.org/changeset/base/240944
 
 Log:
   Add regression test for kern/172075.
   
   Sponsored by:	ADARA Networks
   PR:		kern/172075
 
 Added:
   head/tools/regression/net/
   head/tools/regression/net/if_tap/
   head/tools/regression/net/if_tap/test-tap.sh   (contents, props changed)
 
 Added: head/tools/regression/net/if_tap/test-tap.sh
 ==============================================================================
 --- /dev/null	00:00:00 1970	(empty, because file is newly added)
 +++ head/tools/regression/net/if_tap/test-tap.sh	Wed Sep 26 00:25:09 2012	(r240944)
 @@ -0,0 +1,59 @@
 +#!/bin/sh
 +
 +# Copyright (C) 2012 ADARA Networks.  All rights reserved.
 +#
 +# Redistribution and use in source and binary forms, with or without
 +# modification, are permitted provided that the following conditions
 +# are met:
 +# 1. Redistributions of source code must retain the above copyright
 +#    notice, this list of conditions and the following disclaimer.
 +# 2. Redistributions in binary form must reproduce the above copyright
 +#    notice, this list of conditions and the following disclaimer in the
 +#    documentation and/or other materials provided with the distribution.
 +#
 +# THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
 +# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
 +# ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
 +# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 +# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
 +# OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 +# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 +# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
 +# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 +# SUCH DAMAGE.
 +#
 +# $FreeBSD$
 +
 +tap_exists()
 +{
 +	ls -1 /dev | grep -q "$1"
 +}
 +
 +if [ $(id -u) -ne 0 ]; then
 +	echo "Must be root" >&2
 +	exit 1
 +fi
 +
 +set -e
 +
 +# Base case create & destroy
 +tap=$(ifconfig tap create)
 +tap_exists $tap
 +ifconfig $tap destroy
 +! tap_exists $tap
 +
 +# kern/172075: INVARIANTS kernel panicked when destroying an in-use tap(4) 
 +# Fixed in HEAD r240938.
 +tap=$(ifconfig tap create)
 +tap_exists $tap
 +cat /dev/$tap > /dev/null &
 +catpid=$!
 +sleep 0.1
 +ifconfig $tap destroy &
 +sleep 0.1
 +kill $catpid
 +! tap_exists $tap
 +
 +echo PASS
 +exit 0
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: emaste 
State-Changed-When: Fri Nov 30 14:24:06 UTC 2012 
State-Changed-Why:  
Fix for INVARIANTS panic committed in r240938.  Still need a change so 
that threads in read() will return upon interface destroy. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172075 
>Unformatted:
