From nobody@FreeBSD.org  Tue Sep 18 16:17:27 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 16BE61065670
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 18 Sep 2012 16:17:27 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id CA4178FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 18 Sep 2012 16:17:26 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q8IGHQB2084533
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 18 Sep 2012 16:17:26 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id q8IGHQNZ084532;
	Tue, 18 Sep 2012 16:17:26 GMT
	(envelope-from nobody)
Message-Id: <201209181617.q8IGHQNZ084532@red.freebsd.org>
Date: Tue, 18 Sep 2012 16:17:26 GMT
From: Terrence Koeman <terrence@mediamonks.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Add support for MosChip MCS9901 based Quad UART PCIe card
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         171746
>Category:       kern
>Synopsis:       [puc] [patch] Add support for MosChip MCS9901 based Quad UART PCIe card
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 18 16:20:07 UTC 2012
>Closed-Date:    
>Last-Modified:  Mon Jun 24 20:29:35 UTC 2013
>Originator:     Terrence Koeman
>Release:        9.1-PRERELEASE
>Organization:
MediaMonks B.V.
>Environment:
FreeBSD xxx 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #15: Tue Sep 18 18:09:19 CEST 2012     terrence@xxx:/usr/obj/usr/src/sys/CONTROL-SMP  amd64
>Description:
The MosChip MCS9901 based Quad UART PCIe card is not detected.
>How-To-Repeat:

>Fix:
See patch.

Patch attached with submission follows:

diff -r -u /usr/src/sys/dev/puc/pucdata.c new/puc/pucdata.c
--- /usr/src/sys/dev/puc/pucdata.c      2012-09-04 17:23:26.000000000 +0200
+++ new/puc/pucdata.c   2012-09-17 18:35:59.000000000 +0200
@@ -1069,6 +1069,12 @@
            PUC_PORT_2P, 0x10, 4, 0,
        },
 
+        {   0x9710, 0x9904, 0xa000, 0x1000,
+            "MosChip MCS9901 based Quad UART",
+            DEFAULT_RCLK,
+            PUC_PORT_4S, 0x10, 4, 0,
+        },
+
        {   0xb00c, 0x021c, 0xffff, 0,
            "IC Book Labs Gunboat x4 Lite",
            DEFAULT_RCLK,
diff -r -u /usr/src/sys/dev/uart/uart_bus_pci.c new/uart/uart_bus_pci.c
--- /usr/src/sys/dev/uart/uart_bus_pci.c        2012-03-18 02:01:41.000000000 +0100
+++ new/uart/uart_bus_pci.c     2012-09-17 18:37:47.000000000 +0200
@@ -127,6 +127,8 @@
        "MosChip MCS9900 PCIe to Peripheral Controller", 0x10 },
 { 0x9710, 0x9901, 0xa000, 0x1000,
        "MosChip MCS9901 PCIe to Peripheral Controller", 0x10 },
+{ 0x9710, 0x9904, 0xa000, 0x1000,
+        "MosChip MCS9901 PCIe to 4 Serial", 0x10 },
 { 0xdeaf, 0x9051, 0xffff, 0, "Middle Digital PC Weasel Serial Port", 0x10 },
 { 0xffff, 0, 0xffff, 0, NULL, 0, 0}
 };
diff -r -u /usr/src/sys/dev/uart/uart_dev_ns8250.c new/uart/uart_dev_ns8250.c
--- /usr/src/sys/dev/uart/uart_dev_ns8250.c     2011-09-23 02:51:37.000000000 +0200
+++ new/uart/uart_dev_ns8250.c  2012-09-17 18:41:39.000000000 +0200
@@ -747,6 +747,9 @@
        } else if (count >= 112 && count <= 128) {
                sc->sc_rxfifosz = 128;
                device_set_desc(sc->sc_dev, "16950 or compatible");
+        } else if (count >= 224 && count <= 256) {
+                sc->sc_rxfifosz = 256;
+                device_set_desc(sc->sc_dev, "16650 or compatible with 256byte FIFOs");
        } else {
                sc->sc_rxfifosz = 16;
                device_set_desc(sc->sc_dev,


>Release-Note:
>Audit-Trail:

From: "Terrence Koeman" <terrence@mediamonks.net>
To: "bug-followup@FreeBSD.org" <bug-followup@FreeBSD.org>
Cc:  
Subject: Re: amd64/171746: Add support for MosChip MCS9901 based Quad UART PCIe card
Date: Wed, 19 Sep 2012 16:19:49 +0200

 This is a multi-part message in MIME format.
 
 ------_=_NextPart_6334_00018467.00000041
 Content-Type: text/plain;
  charset="us-ascii"
 Content-Transfer-Encoding: quoted-printable
 
 I accidentally rolled two patches into one, the changes to pucdata.c aren't=
  needed and don't work.
 
 Attached is the correct patch file.
 
 -- 
 Regards,
 T. Koeman, MTh/BSc/BPsy; Chief Technical Monk
 
 MediaMonks B.V. (www.mediamonks.com)
 Please quote relevant replies in correspondence.
 
 
 
 
 ------_=_NextPart_6334_00018467.00000041
 Content-Type: text/plain;
  name="moschip2.txt"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="moschip2.txt"
 
 ZGlmZiAtciAtdSAvdXNyL3NyYy9zeXMvZGV2L3VhcnQvdWFydF9idXNfcGNpLmMgbmV3L3VhcnQv
 dWFydF9idXNfcGNpLmMNCi0tLSAvdXNyL3NyYy9zeXMvZGV2L3VhcnQvdWFydF9idXNfcGNpLmMg
 ICAgICAgIDIwMTItMDMtMTggMDI6MDE6NDEuMDAwMDAwMDAwICswMTAwDQorKysgbmV3L3VhcnQv
 dWFydF9idXNfcGNpLmMgICAgIDIwMTItMDktMTcgMTg6Mzc6NDcuMDAwMDAwMDAwICswMjAwDQpA
 QCAtMTI3LDYgKzEyNyw4IEBADQogICAgICAgICJNb3NDaGlwIE1DUzk5MDAgUENJZSB0byBQZXJp
 cGhlcmFsIENvbnRyb2xsZXIiLCAweDEwIH0sDQogeyAweDk3MTAsIDB4OTkwMSwgMHhhMDAwLCAw
 eDEwMDAsDQogICAgICAgICJNb3NDaGlwIE1DUzk5MDEgUENJZSB0byBQZXJpcGhlcmFsIENvbnRy
 b2xsZXIiLCAweDEwIH0sDQoreyAweDk3MTAsIDB4OTkwNCwgMHhhMDAwLCAweDEwMDAsDQorICAg
 ICAgICAiTW9zQ2hpcCBNQ1M5OTAxIFBDSWUgdG8gNCBTZXJpYWwiLCAweDEwIH0sDQogeyAweGRl
 YWYsIDB4OTA1MSwgMHhmZmZmLCAwLCAiTWlkZGxlIERpZ2l0YWwgUEMgV2Vhc2VsIFNlcmlhbCBQ
 b3J0IiwgMHgxMCB9LA0KIHsgMHhmZmZmLCAwLCAweGZmZmYsIDAsIE5VTEwsIDAsIDB9DQogfTsN
 CmRpZmYgLXIgLXUgL3Vzci9zcmMvc3lzL2Rldi91YXJ0L3VhcnRfZGV2X25zODI1MC5jIG5ldy91
 YXJ0L3VhcnRfZGV2X25zODI1MC5jDQotLS0gL3Vzci9zcmMvc3lzL2Rldi91YXJ0L3VhcnRfZGV2
 X25zODI1MC5jICAgICAyMDExLTA5LTIzIDAyOjUxOjM3LjAwMDAwMDAwMCArMDIwMA0KKysrIG5l
 dy91YXJ0L3VhcnRfZGV2X25zODI1MC5jICAyMDEyLTA5LTE3IDE4OjQxOjM5LjAwMDAwMDAwMCAr
 MDIwMA0KQEAgLTc0Nyw2ICs3NDcsOSBAQA0KICAgICAgICB9IGVsc2UgaWYgKGNvdW50ID49IDEx
 MiAmJiBjb3VudCA8PSAxMjgpIHsNCiAgICAgICAgICAgICAgICBzYy0+c2NfcnhmaWZvc3ogPSAx
 Mjg7DQogICAgICAgICAgICAgICAgZGV2aWNlX3NldF9kZXNjKHNjLT5zY19kZXYsICIxNjk1MCBv
 ciBjb21wYXRpYmxlIik7DQorICAgICAgICB9IGVsc2UgaWYgKGNvdW50ID49IDIyNCAmJiBjb3Vu
 dCA8PSAyNTYpIHsNCisgICAgICAgICAgICAgICAgc2MtPnNjX3J4Zmlmb3N6ID0gMjU2Ow0KKyAg
 ICAgICAgICAgICAgICBkZXZpY2Vfc2V0X2Rlc2Moc2MtPnNjX2RldiwgIjE2NjUwIG9yIGNvbXBh
 dGlibGUgd2l0aCAyNTZieXRlIEZJRk9zIik7DQogICAgICAgIH0gZWxzZSB7DQogICAgICAgICAg
 ICAgICAgc2MtPnNjX3J4Zmlmb3N6ID0gMTY7DQogICAgICAgICAgICAgICAgZGV2aWNlX3NldF9k
 ZXNjKHNjLT5zY19kZXYsDQo=
 
 ------_=_NextPart_6334_00018467.00000041--
 
 
Responsible-Changed-From-To: freebsd-amd64->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Oct 5 03:47:27 UTC 2012 
Responsible-Changed-Why:  
reclassify. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171746 
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Fri Nov 9 01:55:21 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171746 
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Fri Nov 9 03:47:13 UTC 2012 
State-Changed-Why:  
awaiting approval or review prior to commit (no action needed from 
submitter) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171746 
State-Changed-From-To: analyzed->feedback 
State-Changed-By: eadler 
State-Changed-When: Sun Feb 3 17:12:30 UTC 2013 
State-Changed-Why:  
Err, why would you want uart to probe this directly if you are adding it 
to PUC?  As far as the last change to uart_ns8250.c, you will need to 
ask Marcel to review that. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171746 

From: Terrence Koeman <terrence@mediamonks.net>
To: "'bug-followup@FreeBSD.org'" <bug-followup@FreeBSD.org>, 
    "'terrence@mediamonks.net'" <terrence@mediamonks.net>
Cc:  
Subject: Re: kern/171746: [puc] [patch] Add support for MosChip MCS9901 based Quad UART PCIe card
Date: Sun, 03 Feb 2013 18:25:00 +0100

 I'm not adding it to PUC, see my followup with the correct patch.
 
 --=20
 Terrence
 
 
 
State-Changed-From-To: feedback->open 
State-Changed-By: eadler 
State-Changed-When: Sun Feb 3 17:35:05 UTC 2013 
State-Changed-Why:  
Submitter provided requested information 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171746 
Responsible-Changed-From-To: eadler->freebsd-bugs 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Mon Jun 24 20:29:08 UTC 2013 
Responsible-Changed-Why:  
sorry for droping the ball here, but I have no time to look into this atm 


http://www.freebsd.org/cgi/query-pr.cgi?pr=171746 
>Unformatted:
