From nobody@FreeBSD.org  Tue Aug  7 00:39:21 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9F07A1065674
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  7 Aug 2012 00:39:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8A7588FC18
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  7 Aug 2012 00:39:21 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q770dLh6007245
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 7 Aug 2012 00:39:21 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q770dL6o007244;
	Tue, 7 Aug 2012 00:39:21 GMT
	(envelope-from nobody)
Message-Id: <201208070039.q770dL6o007244@red.freebsd.org>
Date: Tue, 7 Aug 2012 00:39:21 GMT
From: Adrian Chadd <adrian@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [ath] TX hang after a stuck beacon message with active traffic
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         170433
>Category:       kern
>Synopsis:       [ath] TX hang after a stuck beacon message with active traffic
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-wireless
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 07 00:40:03 UTC 2012
>Closed-Date:    
>Last-Modified:  Tue Aug  7 00:50:04 UTC 2012
>Originator:     Adrian Chadd
>Release:        9.0-STABLE, HEAD net80211/ath
>Organization:
>Environment:
>Description:
When doing iperf tests to a FreeBSD AP in 2.4GHz, a stuck beacon event would result in traffic stalls.

This can be flushed by one or more "sysctl dev.ath.X.forcebstuck=1" commands.

IT didn't show up in 5GHz mode because I never saw a stuck beacon issue.
>How-To-Repeat:

>Fix:

The problem is in ath_legacy_tx_dma_restart(). It was initialising the wrong link pointer and so the TX queue would end up with incorrect link information.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-wireless 
Responsible-Changed-By: adrian 
Responsible-Changed-When: Tue Aug 7 00:40:38 UTC 2012 
Responsible-Changed-Why:  
Flip 


http://www.freebsd.org/cgi/query-pr.cgi?pr=170433 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/170433: commit references a PR
Date: Tue,  7 Aug 2012 00:43:00 +0000 (UTC)

 Author: adrian
 Date: Tue Aug  7 00:42:46 2012
 New Revision: 239120
 URL: http://svn.freebsd.org/changeset/base/239120
 
 Log:
   Correct re-initialise the link pointer to be the final descriptor in
   the last buffer.
   
   This fixes traffic stalls that were occuring with stuck beacon events.
   
   PR:		kern/170433
 
 Modified:
   head/sys/dev/ath/if_ath_tx.c
 
 Modified: head/sys/dev/ath/if_ath_tx.c
 ==============================================================================
 --- head/sys/dev/ath/if_ath_tx.c	Tue Aug  7 00:34:15 2012	(r239119)
 +++ head/sys/dev/ath/if_ath_tx.c	Tue Aug  7 00:42:46 2012	(r239120)
 @@ -751,7 +751,7 @@ ath_legacy_tx_dma_restart(struct ath_sof
  		return;
  
  	ath_hal_puttxbuf(ah, txq->axq_qnum, bf->bf_daddr);
 -	ath_hal_gettxdesclinkptr(ah, bf->bf_lastds, &txq->axq_link);
 +	ath_hal_gettxdesclinkptr(ah, bf_last->bf_lastds, &txq->axq_link);
  	ath_hal_txstart(ah, txq->axq_qnum);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
