From nobody@FreeBSD.org  Thu Jul 26 17:07:38 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 50A99106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 26 Jul 2012 17:07:38 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 238E28FC1B
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 26 Jul 2012 17:07:38 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q6QH7bjN063710
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 26 Jul 2012 17:07:37 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q6QH7bd2063709;
	Thu, 26 Jul 2012 17:07:37 GMT
	(envelope-from nobody)
Message-Id: <201207261707.q6QH7bd2063709@red.freebsd.org>
Date: Thu, 26 Jul 2012 17:07:37 GMT
From: Marcelo Gondim <gondim@bsdinfo.com.br>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Kernel Panic in GEOM_VIRSTOR
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         170199
>Category:       kern
>Synopsis:       [geom] [panic] Kernel Panic in GEOM_VIRSTOR
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jimharris
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 26 17:10:09 UTC 2012
>Closed-Date:    Wed Aug 29 04:15:55 UTC 2012
>Last-Modified:  Wed Aug 29 04:15:55 UTC 2012
>Originator:     Marcelo Gondim
>Release:        FreeBSD 9-STABLE
>Organization:
>Environment:
FreeBSD lab7.bh.freebsdbrasil.com.br 9.0-STABLE FreeBSD 9.0-STABLE #0: Thu Jul 19 09:11:11 BRT 2012     root@lab.bh.freebsdbrasil.com.br:/usr/obj/usr/src/sys/SEE  i386
>Description:
System executes a kernel panic when running a destroy non-existent name in GEOM_VIRSTOR.

>How-To-Repeat:
How to play:

# gvirstor load
# gvirstor status
#

gv0 dont exist.

Now execute:

# gvirstor destroy gv0
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-geom 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Jul 27 21:28:34 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170199 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/170199: commit references a PR
Date: Fri,  3 Aug 2012 20:24:31 +0000 (UTC)

 Author: jimharris
 Date: Fri Aug  3 20:24:16 2012
 New Revision: 239021
 URL: http://svn.freebsd.org/changeset/base/239021
 
 Log:
   In virstor_ctl_stop(), check for a valid softc before trying to update
    metadata.
   
   Sponsored by:		Intel
   Reported and tested by:	Marcelo Gondim <gondim at bsdinfo dot com dot br>
   PR:			kern/170199
   MFC after:		3 days
 
 Modified:
   head/sys/geom/virstor/g_virstor.c
 
 Modified: head/sys/geom/virstor/g_virstor.c
 ==============================================================================
 --- head/sys/geom/virstor/g_virstor.c	Fri Aug  3 18:40:44 2012	(r239020)
 +++ head/sys/geom/virstor/g_virstor.c	Fri Aug  3 20:24:16 2012	(r239021)
 @@ -235,6 +235,12 @@ virstor_ctl_stop(struct gctl_req *req, s
  			return;
  		}
  		sc = virstor_find_geom(cp, name);
 +		if (sc == NULL) {
 +			gctl_error(req, "Don't know anything about '%s'", name);
 +			g_topology_unlock();
 +			return;
 +		}
 +
  		LOG_MSG(LVL_INFO, "Stopping %s by the userland command",
  		    sc->geom->name);
  		update_metadata(sc);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: ae 
State-Changed-When: Tue Aug 7 19:30:04 UTC 2012 
State-Changed-Why:  
Patched in head/. 


Responsible-Changed-From-To: freebsd-geom->jimharris 
Responsible-Changed-By: ae 
Responsible-Changed-When: Tue Aug 7 19:30:04 UTC 2012 
Responsible-Changed-Why:  
Reassign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170199 
State-Changed-From-To: patched->closed 
State-Changed-By: jimharris 
State-Changed-When: Wed Aug 29 04:14:46 UTC 2012 
State-Changed-Why:  
MFC'd to stable/9 in r239441. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=170199 
>Unformatted:
