From nobody@FreeBSD.org  Tue Jul 10 13:12:22 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B174C106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Jul 2012 13:12:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 9B5348FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Jul 2012 13:12:22 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q6ADCMar088499
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Jul 2012 13:12:22 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q6ADCMZS088498;
	Tue, 10 Jul 2012 13:12:22 GMT
	(envelope-from nobody)
Message-Id: <201207101312.q6ADCMZS088498@red.freebsd.org>
Date: Tue, 10 Jul 2012 13:12:22 GMT
From: Steven Hartland <steven.hartland@multiplay.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Patch to rename da_send_ordered to match other sysctls
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         169765
>Category:       kern
>Synopsis:       Patch to rename da_send_ordered to match other sysctls
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 10 13:20:09 UTC 2012
>Closed-Date:    Thu Jul 12 01:01:15 CEST 2012
>Last-Modified:  Thu Feb 21 17:10:01 UTC 2013
>Originator:     Steven Hartland
>Release:        8.3-RELEASE
>Organization:
Multiplay
>Environment:
FreeBSD build 8.3-RELEASE-p3 FreeBSD 8.3-RELEASE-p3 #3: Tue Jul  3 13:16:31 UTC 2012     root@build:/usr/obj/usr/src/sys/MULTIPLAY  amd64
>Description:
Patch to rename kern.cam.da.da_send_ordered -> kern.cam.da.send_ordered to match all the other da sysctls
>How-To-Repeat:
N/A
>Fix:
Apply the attached patch

Patch attached with submission follows:

Renamed kern.cam.da.da_send_ordered -> kern.cam.da.send_ordered to
match all the other da sysctls
--- sys/cam/scsi/scsi_da.c.orig	2012-07-10 13:07:39.615700131 +0000
+++ sys/cam/scsi/scsi_da.c	2012-03-03 06:15:13.000000000 +0000
@@ -832,9 +832,9 @@
 SYSCTL_INT(_kern_cam_da, OID_AUTO, default_timeout, CTLFLAG_RW,
            &da_default_timeout, 0, "Normal I/O timeout (in seconds)");
 TUNABLE_INT("kern.cam.da.default_timeout", &da_default_timeout);
-SYSCTL_INT(_kern_cam_da, OID_AUTO, send_ordered, CTLFLAG_RW,
+SYSCTL_INT(_kern_cam_da, OID_AUTO, da_send_ordered, CTLFLAG_RW,
            &da_send_ordered, 0, "Send Ordered Tags");
-TUNABLE_INT("kern.cam.da.send_ordered", &da_send_ordered);
+TUNABLE_INT("kern.cam.da.da_send_ordered", &da_send_ordered);
 
 /*
  * DA_ORDEREDTAG_INTERVAL determines how often, relative


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: brueffer 
State-Changed-When: Thu Jul 12 01:00:33 CEST 2012 
State-Changed-Why:  
Committed, thanks! 


Responsible-Changed-From-To: freebsd-bugs->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Thu Jul 12 01:00:33 CEST 2012 
Responsible-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169765 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/169765: commit references a PR
Date: Wed, 11 Jul 2012 23:00:38 +0000 (UTC)

 Author: brueffer
 Date: Wed Jul 11 23:00:26 2012
 New Revision: 238379
 URL: http://svn.freebsd.org/changeset/base/238379
 
 Log:
   Renamed the kern.cam.da.da_send_ordered sysctl and tunable to
   kern.cam.da.send_ordered, more in line with the other da sysctls/tunables.
   
   PR:		169765
   Submitted by:	Steven Hartland <steven.hartland@multiplay.co.uk>
   Reviewed by:	mav
 
 Modified:
   head/sys/cam/scsi/scsi_da.c
 
 Modified: head/sys/cam/scsi/scsi_da.c
 ==============================================================================
 --- head/sys/cam/scsi/scsi_da.c	Wed Jul 11 22:20:19 2012	(r238378)
 +++ head/sys/cam/scsi/scsi_da.c	Wed Jul 11 23:00:26 2012	(r238379)
 @@ -883,9 +883,9 @@ TUNABLE_INT("kern.cam.da.retry_count", &
  SYSCTL_INT(_kern_cam_da, OID_AUTO, default_timeout, CTLFLAG_RW,
             &da_default_timeout, 0, "Normal I/O timeout (in seconds)");
  TUNABLE_INT("kern.cam.da.default_timeout", &da_default_timeout);
 -SYSCTL_INT(_kern_cam_da, OID_AUTO, da_send_ordered, CTLFLAG_RW,
 +SYSCTL_INT(_kern_cam_da, OID_AUTO, send_ordered, CTLFLAG_RW,
             &da_send_ordered, 0, "Send Ordered Tags");
 -TUNABLE_INT("kern.cam.da.da_send_ordered", &da_send_ordered);
 +TUNABLE_INT("kern.cam.da.send_ordered", &da_send_ordered);
  
  /*
   * DA_ORDEREDTAG_INTERVAL determines how often, relative
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/169765: commit references a PR
Date: Thu, 21 Feb 2013 16:59:42 +0000 (UTC)

 Author: mav
 Date: Thu Feb 21 16:59:28 2013
 New Revision: 247103
 URL: http://svnweb.freebsd.org/changeset/base/247103
 
 Log:
   MFC r238379, r238382 (by bruefer):
   Renamed the kern.cam.da.da_send_ordered sysctl and tunable to
   kern.cam.da.send_ordered, more in line with the other da sysctls/tunables.
   Renamed the kern.cam.ada.ada_send_ordered sysctl and tunable to
   kern.cam.ada.send_ordered, more in line with the other da sysctls/tunables.
   
   PR:		169765
 
 Modified:
   stable/9/sys/cam/ata/ata_da.c
   stable/9/sys/cam/scsi/scsi_da.c
 Directory Properties:
   stable/9/sys/   (props changed)
 
 Modified: stable/9/sys/cam/ata/ata_da.c
 ==============================================================================
 --- stable/9/sys/cam/ata/ata_da.c	Thu Feb 21 15:41:09 2013	(r247102)
 +++ stable/9/sys/cam/ata/ata_da.c	Thu Feb 21 16:59:28 2013	(r247103)
 @@ -478,9 +478,9 @@ TUNABLE_INT("kern.cam.ada.retry_count", 
  SYSCTL_INT(_kern_cam_ada, OID_AUTO, default_timeout, CTLFLAG_RW,
             &ada_default_timeout, 0, "Normal I/O timeout (in seconds)");
  TUNABLE_INT("kern.cam.ada.default_timeout", &ada_default_timeout);
 -SYSCTL_INT(_kern_cam_ada, OID_AUTO, ada_send_ordered, CTLFLAG_RW,
 +SYSCTL_INT(_kern_cam_ada, OID_AUTO, send_ordered, CTLFLAG_RW,
             &ada_send_ordered, 0, "Send Ordered Tags");
 -TUNABLE_INT("kern.cam.ada.ada_send_ordered", &ada_send_ordered);
 +TUNABLE_INT("kern.cam.ada.send_ordered", &ada_send_ordered);
  SYSCTL_INT(_kern_cam_ada, OID_AUTO, spindown_shutdown, CTLFLAG_RW,
             &ada_spindown_shutdown, 0, "Spin down upon shutdown");
  TUNABLE_INT("kern.cam.ada.spindown_shutdown", &ada_spindown_shutdown);
 
 Modified: stable/9/sys/cam/scsi/scsi_da.c
 ==============================================================================
 --- stable/9/sys/cam/scsi/scsi_da.c	Thu Feb 21 15:41:09 2013	(r247102)
 +++ stable/9/sys/cam/scsi/scsi_da.c	Thu Feb 21 16:59:28 2013	(r247103)
 @@ -897,9 +897,9 @@ TUNABLE_INT("kern.cam.da.retry_count", &
  SYSCTL_INT(_kern_cam_da, OID_AUTO, default_timeout, CTLFLAG_RW,
             &da_default_timeout, 0, "Normal I/O timeout (in seconds)");
  TUNABLE_INT("kern.cam.da.default_timeout", &da_default_timeout);
 -SYSCTL_INT(_kern_cam_da, OID_AUTO, da_send_ordered, CTLFLAG_RW,
 +SYSCTL_INT(_kern_cam_da, OID_AUTO, send_ordered, CTLFLAG_RW,
             &da_send_ordered, 0, "Send Ordered Tags");
 -TUNABLE_INT("kern.cam.da.da_send_ordered", &da_send_ordered);
 +TUNABLE_INT("kern.cam.da.send_ordered", &da_send_ordered);
  
  /*
   * DA_ORDEREDTAG_INTERVAL determines how often, relative
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/169765: commit references a PR
Date: Thu, 21 Feb 2013 17:00:58 +0000 (UTC)

 Author: mav
 Date: Thu Feb 21 17:00:37 2013
 New Revision: 247105
 URL: http://svnweb.freebsd.org/changeset/base/247105
 
 Log:
   MFC r238379, r238382 (by bruefer):
   Renamed the kern.cam.da.da_send_ordered sysctl and tunable to
   kern.cam.da.send_ordered, more in line with the other da sysctls/tunables.
   Renamed the kern.cam.ada.ada_send_ordered sysctl and tunable to
   kern.cam.ada.send_ordered, more in line with the other da sysctls/tunables.
   
   PR:             169765
 
 Modified:
   stable/8/sys/cam/ata/ata_da.c
   stable/8/sys/cam/scsi/scsi_da.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/cam/   (props changed)
 
 Modified: stable/8/sys/cam/ata/ata_da.c
 ==============================================================================
 --- stable/8/sys/cam/ata/ata_da.c	Thu Feb 21 17:00:35 2013	(r247104)
 +++ stable/8/sys/cam/ata/ata_da.c	Thu Feb 21 17:00:37 2013	(r247105)
 @@ -471,9 +471,9 @@ TUNABLE_INT("kern.cam.ada.retry_count", 
  SYSCTL_INT(_kern_cam_ada, OID_AUTO, default_timeout, CTLFLAG_RW,
             &ada_default_timeout, 0, "Normal I/O timeout (in seconds)");
  TUNABLE_INT("kern.cam.ada.default_timeout", &ada_default_timeout);
 -SYSCTL_INT(_kern_cam_ada, OID_AUTO, ada_send_ordered, CTLFLAG_RW,
 +SYSCTL_INT(_kern_cam_ada, OID_AUTO, send_ordered, CTLFLAG_RW,
             &ada_send_ordered, 0, "Send Ordered Tags");
 -TUNABLE_INT("kern.cam.ada.ada_send_ordered", &ada_send_ordered);
 +TUNABLE_INT("kern.cam.ada.send_ordered", &ada_send_ordered);
  SYSCTL_INT(_kern_cam_ada, OID_AUTO, spindown_shutdown, CTLFLAG_RW,
             &ada_spindown_shutdown, 0, "Spin down upon shutdown");
  TUNABLE_INT("kern.cam.ada.spindown_shutdown", &ada_spindown_shutdown);
 
 Modified: stable/8/sys/cam/scsi/scsi_da.c
 ==============================================================================
 --- stable/8/sys/cam/scsi/scsi_da.c	Thu Feb 21 17:00:35 2013	(r247104)
 +++ stable/8/sys/cam/scsi/scsi_da.c	Thu Feb 21 17:00:37 2013	(r247105)
 @@ -873,9 +873,9 @@ TUNABLE_INT("kern.cam.da.retry_count", &
  SYSCTL_INT(_kern_cam_da, OID_AUTO, default_timeout, CTLFLAG_RW,
             &da_default_timeout, 0, "Normal I/O timeout (in seconds)");
  TUNABLE_INT("kern.cam.da.default_timeout", &da_default_timeout);
 -SYSCTL_INT(_kern_cam_da, OID_AUTO, da_send_ordered, CTLFLAG_RW,
 +SYSCTL_INT(_kern_cam_da, OID_AUTO, send_ordered, CTLFLAG_RW,
             &da_send_ordered, 0, "Send Ordered Tags");
 -TUNABLE_INT("kern.cam.da.da_send_ordered", &da_send_ordered);
 +TUNABLE_INT("kern.cam.da.send_ordered", &da_send_ordered);
  
  /*
   * DA_ORDEREDTAG_INTERVAL determines how often, relative
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
