From nobody@FreeBSD.org  Tue Jul 10 12:32:06 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 744BC106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Jul 2012 12:32:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 5F2018FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Jul 2012 12:32:06 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q6ACW5bO028555
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Jul 2012 12:32:05 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q6ACW54Q028554;
	Tue, 10 Jul 2012 12:32:05 GMT
	(envelope-from nobody)
Message-Id: <201207101232.q6ACW54Q028554@red.freebsd.org>
Date: Tue, 10 Jul 2012 12:32:05 GMT
From: Steven Hartland <steven.hartland@multiplay.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Incorrect description of ata security freeze
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         169763
>Category:       kern
>Synopsis:       Incorrect description of ata security freeze
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 10 12:40:09 UTC 2012
>Closed-Date:    Wed Jul 18 13:37:37 CEST 2012
>Last-Modified:  Wed Jul 18 13:37:37 CEST 2012
>Originator:     Steven Hartland
>Release:        8.3-RELEASE
>Organization:
Multiplay
>Environment:
FreeBSD build 8.3-RELEASE-p3 FreeBSD 8.3-RELEASE-p3 #3: Tue Jul  3 13:16:31 UTC 2012     root@build:/usr/obj/usr/src/sys/MULTIPLAY  amd64
>Description:
Simple fix for incorrect description of ata security freeze option
>How-To-Repeat:
N/A
>Fix:
Apply the attached patch

Patch attached with submission follows:

--- ../src-8.3/sys/cam/ata/ata_all.c	2012-03-03 06:15:13.000000000 +0000
+++ ata_all.c	2012-07-10 12:27:27.881899885 +0000
@@ -161,7 +161,7 @@
 	case 0xf2: return ("SECURITY_UNLOCK");
 	case 0xf3: return ("SECURITY_ERASE_PREPARE");
 	case 0xf4: return ("SECURITY_ERASE_UNIT");
-	case 0xf5: return ("SECURITY_FREE_LOCK");
+	case 0xf5: return ("SECURITY_FREEZE_LOCK");
 	case 0xf6: return ("SECURITY DISABLE PASSWORD");
 	case 0xf8: return ("READ_NATIVE_MAX_ADDRESS");
 	case 0xf9: return ("SET_MAX_ADDRESS");


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Wed Jul 11 09:55:04 CEST 2012 
Responsible-Changed-Why:  
Grab. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169763 
State-Changed-From-To: open->patched 
State-Changed-By: brueffer 
State-Changed-When: Wed Jul 11 10:24:37 CEST 2012 
State-Changed-Why:  
Fixed in HEAD, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169763 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/169763: commit references a PR
Date: Wed, 11 Jul 2012 08:24:40 +0000 (UTC)

 Author: brueffer
 Date: Wed Jul 11 08:24:30 2012
 New Revision: 238363
 URL: http://svn.freebsd.org/changeset/base/238363
 
 Log:
   - fix description of SECURITY_FREEZE_LOCK (1)
   - add missing underscores to SECURITY_DISABLE_PASSWORD
   
   PR:		169763 (1)
   Submitted by:	Steven Hartland <steven.hartland@multiplay.co.uk>
   Reviewed by:	mav
   MFC after:	1 week
 
 Modified:
   head/sys/cam/ata/ata_all.c
 
 Modified: head/sys/cam/ata/ata_all.c
 ==============================================================================
 --- head/sys/cam/ata/ata_all.c	Wed Jul 11 03:49:05 2012	(r238362)
 +++ head/sys/cam/ata/ata_all.c	Wed Jul 11 08:24:30 2012	(r238363)
 @@ -171,8 +171,8 @@ ata_op_string(struct ata_cmd *cmd)
  	case 0xf2: return ("SECURITY_UNLOCK");
  	case 0xf3: return ("SECURITY_ERASE_PREPARE");
  	case 0xf4: return ("SECURITY_ERASE_UNIT");
 -	case 0xf5: return ("SECURITY_FREE_LOCK");
 -	case 0xf6: return ("SECURITY DISABLE PASSWORD");
 +	case 0xf5: return ("SECURITY_FREEZE_LOCK");
 +	case 0xf6: return ("SECURITY_DISABLE_PASSWORD");
  	case 0xf8: return ("READ_NATIVE_MAX_ADDRESS");
  	case 0xf9: return ("SET_MAX_ADDRESS");
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brueffer 
State-Changed-When: Wed Jul 18 13:37:16 CEST 2012 
State-Changed-Why:  
MFCs done. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169763 
>Unformatted:
