From nobody@FreeBSD.org  Mon Jun 11 23:37:23 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 540E4106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Jun 2012 23:37:23 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id EEBDF8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Jun 2012 23:37:22 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q5BNbKJh020612
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Jun 2012 23:37:20 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q5BNbKMF020611;
	Mon, 11 Jun 2012 23:37:20 GMT
	(envelope-from nobody)
Message-Id: <201206112337.q5BNbKMF020611@red.freebsd.org>
Date: Mon, 11 Jun 2012 23:37:20 GMT
From: fuzhli <fuzl@arraynetworks.com.cn>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ixgbe driver compile failure for DEBUGOUT6 not defined 
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         168967
>Category:       kern
>Synopsis:       ixgbe driver compile failure for DEBUGOUT6 not defined
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 11 23:40:07 UTC 2012
>Closed-Date:    Tue Sep 25 01:34:15 UTC 2012
>Last-Modified:  Tue Sep 25 01:34:15 UTC 2012
>Originator:     fuzhli
>Release:        current
>Organization:
array networks
>Environment:
%uname -a
FreeBSD Array.arraynetworks.net 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 10:35:36 UTC 2008 root@driscoll.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
ixgbe driver compile failure when change macro DBG to non-zero value in src/sys/dev/ixgbe/ixgbe_osdep.h, the error is:

cc -c -O2 -frename-registers -pipe -fno-strict-aliasing   -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc  -I. -I/export/home/fuzl/amp/FreeBSD/src/sys -I/export/home/fuzl/amp/FreeBSD/src/sys/contrib/altq -I/usr/include -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -DCLICKTCP -DCLICKBUF -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -DFWLB  -fno-omit-frame-pointer -D__amd64__ -mcmodel=kernel -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow  -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Werror  /export/home/fuzl/amp/FreeBSD/src/sys/dev/ixgbe/ixgbe_api.c -I/export/home/fuzl/amp/FreeBSD/src/sys/dev/ixgbe
cc -c -O2 -frename-registers -pipe -fno-strict-aliasing   -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc  -I. -I/export/home/fuzl/amp/FreeBSD/src/sys -I/export/home/fuzl/amp/FreeBSD/src/sys/contrib/altq -I/usr/include -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -DCLICKTCP -DCLICKBUF -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -DFWLB  -fno-omit-frame-pointer -D__amd64__ -mcmodel=kernel -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow  -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Werror  /export/home/fuzl/amp/FreeBSD/src/sys/dev/ixgbe/ixgbe_common.c -I/export/home/fuzl/amp/FreeBSD/src/sys/dev/ixgbe
cc1: warnings being treated as errors
/export/home/fuzl/amp/FreeBSD/src/sys/dev/ixgbe/ixgbe_common.c: In function 'ixgbe_add_uc_addr':
/export/home/fuzl/amp/FreeBSD/src/sys/dev/ixgbe/ixgbe_common.c:1459: warning: implicit declaration of function 'DEBUGOUT6'
/export/home/fuzl/amp/FreeBSD/src/sys/dev/ixgbe/ixgbe_common.c:1459: warning: nested extern declaration of 'DEBUGOUT6'
*** Error code 1

>How-To-Repeat:
change DBG to non-zero value in src/sys/dev/ixgbe/ixgbe_osdep.h, then compile kernel.
>Fix:
Define DEBUGOUT6 if DBG is not zero.:

Index: src/sys/dev/ixgbe/ixgbe_osdep.h
===================================================================
RCS file: /home/fuzl/src/sys/dev/ixgbe/ixgbe_osdep.h,v
retrieving revision 1.2
diff -u -p -r1.2 ixgbe_osdep.h
--- src/sys/dev/ixgbe/ixgbe_osdep.h     29 Jun 2011 09:40:25 -0000      1.2
+++ src/sys/dev/ixgbe/ixgbe_osdep.h     11 Jun 2012 23:30:30 -0000
@@ -67,6 +67,7 @@
        #define DEBUGOUT1(S,A)      printf(S "\n",A)
        #define DEBUGOUT2(S,A,B)    printf(S "\n",A,B)
        #define DEBUGOUT3(S,A,B,C)  printf(S "\n",A,B,C)
+       #define DEBUGOUT6(S,A,B,C,D,E,F)  printf(S "\n",A,B,C,D,E,F)
        #define DEBUGOUT7(S,A,B,C,D,E,F,G)  printf(S "\n",A,B,C,D,E,F,G)
 #else
        #define DEBUGOUT(S)


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Mon Jul 9 00:13:11 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168967 
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Mon Sep 3 04:00:19 UTC 2012 
State-Changed-Why:  
awaiting approval 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168967 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168967: commit references a PR
Date: Thu, 13 Sep 2012 14:40:40 +0000 (UTC)

 Author: eadler
 Date: Thu Sep 13 14:40:24 2012
 New Revision: 240466
 URL: http://svn.freebsd.org/changeset/base/240466
 
 Log:
   Define missing DEBUGOUT# macros. DEBUGOUT[45] are not yet used but are
   being defined pre-emptively to avoid future build breakage
   
   PR:		kern/168967
   Submitted by:	fuzhli <fuzl@arraynetworks.com.cn>
   Approved by:	cperciva
   MFC after:	1 week
 
 Modified:
   head/sys/dev/ixgbe/ixgbe_osdep.h
 
 Modified: head/sys/dev/ixgbe/ixgbe_osdep.h
 ==============================================================================
 --- head/sys/dev/ixgbe/ixgbe_osdep.h	Thu Sep 13 13:27:09 2012	(r240465)
 +++ head/sys/dev/ixgbe/ixgbe_osdep.h	Thu Sep 13 14:40:24 2012	(r240466)
 @@ -69,12 +69,17 @@
  	#define DEBUGOUT1(S,A)      printf(S "\n",A)
  	#define DEBUGOUT2(S,A,B)    printf(S "\n",A,B)
  	#define DEBUGOUT3(S,A,B,C)  printf(S "\n",A,B,C)
 +	#define DEBUGOUT4(S,A,B,C,D)  printf(S "\n",A,B,C,D)
 +	#define DEBUGOUT5(S,A,B,C,D,E)  printf(S "\n",A,B,C,D,E)
 +	#define DEBUGOUT6(S,A,B,C,D,E,F)  printf(S "\n",A,B,C,D,E,F)
  	#define DEBUGOUT7(S,A,B,C,D,E,F,G)  printf(S "\n",A,B,C,D,E,F,G)
  #else
  	#define DEBUGOUT(S)
  	#define DEBUGOUT1(S,A)
  	#define DEBUGOUT2(S,A,B)
  	#define DEBUGOUT3(S,A,B,C)
 +	#define DEBUGOUT4(S,A,B,C,D)
 +	#define DEBUGOUT5(S,A,B,C,D,E)
  	#define DEBUGOUT6(S,A,B,C,D,E,F)
  	#define DEBUGOUT7(S,A,B,C,D,E,F,G)
  #endif
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->patched 
State-Changed-By: eadler 
State-Changed-When: Thu Sep 13 14:52:12 UTC 2012 
State-Changed-Why:  
committed in r240466 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168967 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168967: commit references a PR
Date: Tue, 25 Sep 2012 01:28:24 +0000 (UTC)

 Author: eadler
 Date: Tue Sep 25 01:28:13 2012
 New Revision: 240903
 URL: http://svn.freebsd.org/changeset/base/240903
 
 Log:
   MFC r240466:
   	Define missing DEBUGOUT# macros. DEBUGOUT[45] are not yet used but are
   	being defined pre-emptively to avoid future build breakage
   
   PR:		kern/168967
   Approved by:	cperciva (implicit)
 
 Modified:
   stable/8/sys/dev/ixgbe/ixgbe_osdep.h
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/dev/   (props changed)
   stable/8/sys/dev/ixgbe/   (props changed)
 
 Modified: stable/8/sys/dev/ixgbe/ixgbe_osdep.h
 ==============================================================================
 --- stable/8/sys/dev/ixgbe/ixgbe_osdep.h	Mon Sep 24 23:57:16 2012	(r240902)
 +++ stable/8/sys/dev/ixgbe/ixgbe_osdep.h	Tue Sep 25 01:28:13 2012	(r240903)
 @@ -68,12 +68,17 @@
  	#define DEBUGOUT1(S,A)      printf(S "\n",A)
  	#define DEBUGOUT2(S,A,B)    printf(S "\n",A,B)
  	#define DEBUGOUT3(S,A,B,C)  printf(S "\n",A,B,C)
 +	#define DEBUGOUT4(S,A,B,C,D)  printf(S "\n",A,B,C,D)
 +	#define DEBUGOUT5(S,A,B,C,D,E)  printf(S "\n",A,B,C,D,E)
 +	#define DEBUGOUT6(S,A,B,C,D,E,F)  printf(S "\n",A,B,C,D,E,F)
  	#define DEBUGOUT7(S,A,B,C,D,E,F,G)  printf(S "\n",A,B,C,D,E,F,G)
  #else
  	#define DEBUGOUT(S)
  	#define DEBUGOUT1(S,A)
  	#define DEBUGOUT2(S,A,B)
  	#define DEBUGOUT3(S,A,B,C)
 +	#define DEBUGOUT4(S,A,B,C,D)
 +	#define DEBUGOUT5(S,A,B,C,D,E)
  	#define DEBUGOUT6(S,A,B,C,D,E,F)
  	#define DEBUGOUT7(S,A,B,C,D,E,F,G)
  #endif
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168967: commit references a PR
Date: Tue, 25 Sep 2012 01:28:48 +0000 (UTC)

 Author: eadler
 Date: Tue Sep 25 01:28:14 2012
 New Revision: 240904
 URL: http://svn.freebsd.org/changeset/base/240904
 
 Log:
   MFC r240466:
   	Define missing DEBUGOUT# macros. DEBUGOUT[45] are not yet used but are
   	being defined pre-emptively to avoid future build breakage
   
   PR:		kern/168967
   Approved by:	cperciva (implicit)
 
 Modified:
   stable/9/sys/dev/ixgbe/ixgbe_osdep.h
 Directory Properties:
   stable/9/sys/   (props changed)
   stable/9/sys/dev/   (props changed)
   stable/9/sys/dev/ixgbe/   (props changed)
 
 Modified: stable/9/sys/dev/ixgbe/ixgbe_osdep.h
 ==============================================================================
 --- stable/9/sys/dev/ixgbe/ixgbe_osdep.h	Tue Sep 25 01:28:13 2012	(r240903)
 +++ stable/9/sys/dev/ixgbe/ixgbe_osdep.h	Tue Sep 25 01:28:14 2012	(r240904)
 @@ -69,12 +69,17 @@
  	#define DEBUGOUT1(S,A)      printf(S "\n",A)
  	#define DEBUGOUT2(S,A,B)    printf(S "\n",A,B)
  	#define DEBUGOUT3(S,A,B,C)  printf(S "\n",A,B,C)
 +	#define DEBUGOUT4(S,A,B,C,D)  printf(S "\n",A,B,C,D)
 +	#define DEBUGOUT5(S,A,B,C,D,E)  printf(S "\n",A,B,C,D,E)
 +	#define DEBUGOUT6(S,A,B,C,D,E,F)  printf(S "\n",A,B,C,D,E,F)
  	#define DEBUGOUT7(S,A,B,C,D,E,F,G)  printf(S "\n",A,B,C,D,E,F,G)
  #else
  	#define DEBUGOUT(S)
  	#define DEBUGOUT1(S,A)
  	#define DEBUGOUT2(S,A,B)
  	#define DEBUGOUT3(S,A,B,C)
 +	#define DEBUGOUT4(S,A,B,C,D)
 +	#define DEBUGOUT5(S,A,B,C,D,E)
  	#define DEBUGOUT6(S,A,B,C,D,E,F)
  	#define DEBUGOUT7(S,A,B,C,D,E,F,G)
  #endif
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168967: commit references a PR
Date: Tue, 25 Sep 2012 01:28:55 +0000 (UTC)

 Author: eadler
 Date: Tue Sep 25 01:28:15 2012
 New Revision: 240905
 URL: http://svn.freebsd.org/changeset/base/240905
 
 Log:
   MFC r240466:
   	Define missing DEBUGOUT# macros. DEBUGOUT[45] are not yet used but are
   	being defined pre-emptively to avoid future build breakage
   
   PR:		kern/168967
   Approved by:	cperciva (implicit)
 
 Modified:
   stable/7/sys/dev/ixgbe/ixgbe_osdep.h
 Directory Properties:
   stable/7/sys/   (props changed)
 
 Modified: stable/7/sys/dev/ixgbe/ixgbe_osdep.h
 ==============================================================================
 --- stable/7/sys/dev/ixgbe/ixgbe_osdep.h	Tue Sep 25 01:28:14 2012	(r240904)
 +++ stable/7/sys/dev/ixgbe/ixgbe_osdep.h	Tue Sep 25 01:28:15 2012	(r240905)
 @@ -67,12 +67,17 @@
  	#define DEBUGOUT1(S,A)      printf(S "\n",A)
  	#define DEBUGOUT2(S,A,B)    printf(S "\n",A,B)
  	#define DEBUGOUT3(S,A,B,C)  printf(S "\n",A,B,C)
 +	#define DEBUGOUT4(S,A,B,C,D)  printf(S "\n",A,B,C,D)
 +	#define DEBUGOUT5(S,A,B,C,D,E)  printf(S "\n",A,B,C,D,E)
 +	#define DEBUGOUT6(S,A,B,C,D,E,F)  printf(S "\n",A,B,C,D,E,F)
  	#define DEBUGOUT7(S,A,B,C,D,E,F,G)  printf(S "\n",A,B,C,D,E,F,G)
  #else
  	#define DEBUGOUT(S)
  	#define DEBUGOUT1(S,A)
  	#define DEBUGOUT2(S,A,B)
  	#define DEBUGOUT3(S,A,B,C)
 +	#define DEBUGOUT4(S,A,B,C,D)
 +	#define DEBUGOUT5(S,A,B,C,D,E)
  	#define DEBUGOUT6(S,A,B,C,D,E,F)
  	#define DEBUGOUT7(S,A,B,C,D,E,F,G)
  #endif
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Tue Sep 25 01:34:13 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168967 
>Unformatted:
