From nobody@FreeBSD.org  Sun Jun 10 06:19:31 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9C864106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 10 Jun 2012 06:19:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 6E5318FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 10 Jun 2012 06:19:31 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q5A6JVjh078378
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 10 Jun 2012 06:19:31 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q5A6JV0Y078377;
	Sun, 10 Jun 2012 06:19:31 GMT
	(envelope-from nobody)
Message-Id: <201206100619.q5A6JV0Y078377@red.freebsd.org>
Date: Sun, 10 Jun 2012 06:19:31 GMT
From: Richard Yao <ryao@gentoo.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: hptrr is incompatible with Marvel SATA controllers
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         168910
>Category:       kern
>Synopsis:       [hptrr] hptrr is incompatible with Marvel SATA controllers
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 10 06:20:04 UTC 2012
>Closed-Date:    Sun Jul 01 00:53:05 UTC 2012
>Last-Modified:  Sun Sep  2 18:50:30 UTC 2012
>Originator:     Richard Yao
>Release:        9-RELEASE
>Organization:
Gentoo
>Environment:
FreeBSD gfreebsd 9.0-r3-Gentoo FreeBSD Gentoo 9.0-r3 #0: Sun May 27 20:29:34 EDT 2012     root@gfreebsd:/usr/src/sys/amd64/compile/GENERIC  amd64
>Description:
The hptrr driver is incompatible with the Marvel MV88SXxxxx, but it disregards the pci vendor id, attaching to it anyway. This behavior seems to have been caused by a combination of lack of hardware for testing and a desire to provide RAID-capable drivers for as much hardware as possible.

The attach_generic module option was implemented in FreeBSD 8.0 with notes about non-high point controllers, but it was set on by default, presumably to prevent the use of ata, which is slow. The mvs driver was introduced in FreeBSD 8.1 to replace the hptrr driver on non-highpoint controllers, but the default setting for attach_generic was left unchanged.

This lead to a Gentoo user encountering issues with the Marvel MV88SXxxxx in Gentoo FreeBSD 9.0. Debugging on IRC lead to the discovery that setting hptrr.attach_generic=0 in /boot/loader.conf solved it.

I initilally patched the driver to exclude Marvell's devices from attach_generic, but I realized that is the wrong solution. A driver should only claim devices it knows it can support, rather than blindly guess. I have therefore revised my patch to disable generic_attach by default.
>How-To-Repeat:
1. Boot a LiveCD on a system with disks attached to a Marvel MV88SXxxxx.
2. Observe that no disks attached to the controller have block devices in /dev
>Fix:
Apply this patch:

diff -upNr a/share/man/man4/hptrr.4 b/share/man/man4/hptrr.4
--- a/share/man/man4/hptrr.4	2012-06-04 01:04:23.603262299 -0400
+++ b/share/man/man4/hptrr.4	2012-06-04 01:13:29.983218866 -0400
@@ -50,8 +50,8 @@ hptrr_load="YES"
 The following tunables are settable from the loader:
 .Bl -ohang
 .It Va hw.hptrr.attach_generic
-set to 0 to deny driver attach to chips with generic Marvell (non-HighPoint)
-PCI identification. These chips are also supported by ata(4).
+set to 1 to permit driver attach to chips with generic Marvell (non-HighPoint)
+PCI identification. These chips are also supported by ata(4) and mvs(4).
 Some vendors are using same chips, but without providing RAID BIOS.
 .El
 .Sh DESCRIPTION
@@ -112,7 +112,8 @@ This driver supersedes the older rr232x
 .Xr ata 4 ,
 .Xr cam 4 ,
 .Xr hptmv 4 ,
-.Xr loader 8
+.Xr loader 8 ,
+.Xr mvs 4
 .Sh HISTORY
 The
 .Nm
diff -upNr a/sys/dev/hptrr/hptrr_osm_bsd.c b/sys/dev/hptrr/hptrr_osm_bsd.c
--- a/sys/dev/hptrr/hptrr_osm_bsd.c	2012-06-04 00:41:57.387011767 -0400
+++ b/sys/dev/hptrr/hptrr_osm_bsd.c	2012-06-04 01:08:37.113299728 -0400
@@ -34,7 +34,7 @@
 #include <dev/hptrr/os_bsd.h>
 #include <dev/hptrr/hptintf.h>
 
-static int attach_generic = 1;
+static int attach_generic = 0;
 TUNABLE_INT("hw.hptrr.attach_generic", &attach_generic);
 
 static int hpt_probe(device_t dev)

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sun Jun 10 06:21:57 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168910 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168910: commit references a PR
Date: Sun, 17 Jun 2012 02:46:37 +0000 (UTC)

 Author: eadler
 Date: Sun Jun 17 02:46:27 2012
 New Revision: 237178
 URL: http://svn.freebsd.org/changeset/base/237178
 
 Log:
   attach_generic causes missing devices in /dev when the driver
   interacts with some non-highpoint controollers. Change attach_generic to
   be off by default.
   
   PR:		kern/168910
   Submitted by:	Richard Yao <ryao@gentoo.org>
   Approved by:	cperciva
   No objections by:	-hackers
   Obtained from:	Gentoo FreeBSD
   MFC after:	2 weeks
 
 Modified:
   head/share/man/man4/hptrr.4
   head/sys/dev/hptrr/hptrr_osm_bsd.c
 
 Modified: head/share/man/man4/hptrr.4
 ==============================================================================
 --- head/share/man/man4/hptrr.4	Sun Jun 17 00:28:57 2012	(r237177)
 +++ head/share/man/man4/hptrr.4	Sun Jun 17 02:46:27 2012	(r237178)
 @@ -50,8 +50,8 @@ hptrr_load="YES"
  The following tunables are settable from the loader:
  .Bl -ohang
  .It Va hw.hptrr.attach_generic
 -set to 0 to deny driver attach to chips with generic Marvell (non-HighPoint)
 -PCI identification. These chips are also supported by ata(4).
 +set to 1 to permit driver attach to chips with generic Marvell (non-HighPoint)
 +PCI identification. These chips are also supported by ata(4) and mvs(4).
  Some vendors are using same chips, but without providing RAID BIOS.
  .El
  .Sh DESCRIPTION
 @@ -112,7 +112,8 @@ This driver supersedes the older rr232x 
  .Xr ata 4 ,
  .Xr cam 4 ,
  .Xr hptmv 4 ,
 -.Xr loader 8
 +.Xr loader 8 ,
 +.Xr mvs 4
  .Sh HISTORY
  The
  .Nm
 
 Modified: head/sys/dev/hptrr/hptrr_osm_bsd.c
 ==============================================================================
 --- head/sys/dev/hptrr/hptrr_osm_bsd.c	Sun Jun 17 00:28:57 2012	(r237177)
 +++ head/sys/dev/hptrr/hptrr_osm_bsd.c	Sun Jun 17 02:46:27 2012	(r237178)
 @@ -36,7 +36,7 @@ __FBSDID("$FreeBSD$");
  #include <dev/hptrr/os_bsd.h>
  #include <dev/hptrr/hptintf.h>
  
 -static int attach_generic = 1;
 +static int attach_generic = 0;
  TUNABLE_INT("hw.hptrr.attach_generic", &attach_generic);
  
  static int hpt_probe(device_t dev)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: eadler 
State-Changed-When: Sun Jun 17 03:55:11 UTC 2012 
State-Changed-Why:  
committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168910 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168910: commit references a PR
Date: Sun, 17 Jun 2012 03:54:21 +0000 (UTC)

 Author: eadler
 Date: Sun Jun 17 03:54:10 2012
 New Revision: 237180
 URL: http://svn.freebsd.org/changeset/base/237180
 
 Log:
   Fix mdoc style nits
   
   PR:		kern/168910
   Submitted by:	gjb
   Approved by:	gjb
   MFC after:	3 days
   X-MFC-With:	r237178
 
 Modified:
   head/share/man/man4/hptrr.4
 
 Modified: head/share/man/man4/hptrr.4
 ==============================================================================
 --- head/share/man/man4/hptrr.4	Sun Jun 17 03:08:33 2012	(r237179)
 +++ head/share/man/man4/hptrr.4	Sun Jun 17 03:54:10 2012	(r237180)
 @@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd November 8, 2009
 +.Dd June 6, 2012
  .Dt HPTRR 4
  .Os
  .Sh NAME
 @@ -51,7 +51,10 @@ The following tunables are settable from
  .Bl -ohang
  .It Va hw.hptrr.attach_generic
  set to 1 to permit driver attach to chips with generic Marvell (non-HighPoint)
 -PCI identification. These chips are also supported by ata(4) and mvs(4).
 +PCI identification. These chips are also supported by
 +.Xr ata 4
 +and
 +.Xr mvs 4 .
  Some vendors are using same chips, but without providing RAID BIOS.
  .El
  .Sh DESCRIPTION
 @@ -112,8 +115,8 @@ This driver supersedes the older rr232x 
  .Xr ata 4 ,
  .Xr cam 4 ,
  .Xr hptmv 4 ,
 -.Xr loader 8 ,
 -.Xr mvs 4
 +.Xr mvs 4 ,
 +.Xr loader 8
  .Sh HISTORY
  The
  .Nm
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168910: commit references a PR
Date: Sun,  1 Jul 2012 00:40:27 +0000 (UTC)

 Author: eadler
 Date: Sun Jul  1 00:40:09 2012
 New Revision: 237861
 URL: http://svn.freebsd.org/changeset/base/237861
 
 Log:
   MFC r237178:
   	attach_generic causes missing devices in /dev when the driver interacts with some non-highpoint controollers. Change attach_generic to be off by default.
   
   PR:		kern/168910
   Approved by:	cperciva (implicit)
 
 Modified:
   stable/9/share/man/man4/hptrr.4
   stable/9/sys/dev/hptrr/hptrr_osm_bsd.c
 Directory Properties:
   stable/9/share/man/man4/   (props changed)
   stable/9/sys/   (props changed)
   stable/9/sys/dev/   (props changed)
 
 Modified: stable/9/share/man/man4/hptrr.4
 ==============================================================================
 --- stable/9/share/man/man4/hptrr.4	Sun Jul  1 00:36:07 2012	(r237860)
 +++ stable/9/share/man/man4/hptrr.4	Sun Jul  1 00:40:09 2012	(r237861)
 @@ -50,8 +50,8 @@ hptrr_load="YES"
  The following tunables are settable from the loader:
  .Bl -ohang
  .It Va hw.hptrr.attach_generic
 -set to 0 to deny driver attach to chips with generic Marvell (non-HighPoint)
 -PCI identification. These chips are also supported by ata(4).
 +set to 1 to permit driver attach to chips with generic Marvell (non-HighPoint)
 +PCI identification. These chips are also supported by ata(4) and mvs(4).
  Some vendors are using same chips, but without providing RAID BIOS.
  .El
  .Sh DESCRIPTION
 @@ -112,7 +112,8 @@ This driver supersedes the older rr232x 
  .Xr ata 4 ,
  .Xr cam 4 ,
  .Xr hptmv 4 ,
 -.Xr loader 8
 +.Xr loader 8 ,
 +.Xr mvs 4
  .Sh HISTORY
  The
  .Nm
 
 Modified: stable/9/sys/dev/hptrr/hptrr_osm_bsd.c
 ==============================================================================
 --- stable/9/sys/dev/hptrr/hptrr_osm_bsd.c	Sun Jul  1 00:36:07 2012	(r237860)
 +++ stable/9/sys/dev/hptrr/hptrr_osm_bsd.c	Sun Jul  1 00:40:09 2012	(r237861)
 @@ -36,7 +36,7 @@ __FBSDID("$FreeBSD$");
  #include <dev/hptrr/os_bsd.h>
  #include <dev/hptrr/hptintf.h>
  
 -static int attach_generic = 1;
 +static int attach_generic = 0;
  TUNABLE_INT("hw.hptrr.attach_generic", &attach_generic);
  
  static int hpt_probe(device_t dev)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168910: commit references a PR
Date: Sun,  1 Jul 2012 00:40:52 +0000 (UTC)

 Author: eadler
 Date: Sun Jul  1 00:40:37 2012
 New Revision: 237862
 URL: http://svn.freebsd.org/changeset/base/237862
 
 Log:
   MFC r237178:
   	attach_generic causes missing devices in /dev when the driver interacts with some non-highpoint controollers. Change attach_generic to be off by default.
   
   PR:		kern/168910
   Approved by:	cperciva (implicit)
 
 Modified:
   stable/8/share/man/man4/hptrr.4
   stable/8/sys/dev/hptrr/hptrr_osm_bsd.c
 Directory Properties:
   stable/8/share/man/man4/   (props changed)
   stable/8/sys/   (props changed)
 
 Modified: stable/8/share/man/man4/hptrr.4
 ==============================================================================
 --- stable/8/share/man/man4/hptrr.4	Sun Jul  1 00:40:09 2012	(r237861)
 +++ stable/8/share/man/man4/hptrr.4	Sun Jul  1 00:40:37 2012	(r237862)
 @@ -50,8 +50,8 @@ hptrr_load="YES"
  The following tunables are settable from the loader:
  .Bl -ohang
  .It Va hw.hptrr.attach_generic
 -set to 0 to deny driver attach to chips with generic Marvell (non-HighPoint)
 -PCI identification. These chips are also supported by ata(4).
 +set to 1 to permit driver attach to chips with generic Marvell (non-HighPoint)
 +PCI identification. These chips are also supported by ata(4) and mvs(4).
  Some vendors are using same chips, but without providing RAID BIOS.
  .El
  .Sh DESCRIPTION
 @@ -112,7 +112,8 @@ This driver supersedes the older rr232x 
  .Xr ata 4 ,
  .Xr cam 4 ,
  .Xr hptmv 4 ,
 -.Xr loader 8
 +.Xr loader 8 ,
 +.Xr mvs 4
  .Sh HISTORY
  The
  .Nm
 
 Modified: stable/8/sys/dev/hptrr/hptrr_osm_bsd.c
 ==============================================================================
 --- stable/8/sys/dev/hptrr/hptrr_osm_bsd.c	Sun Jul  1 00:40:09 2012	(r237861)
 +++ stable/8/sys/dev/hptrr/hptrr_osm_bsd.c	Sun Jul  1 00:40:37 2012	(r237862)
 @@ -36,7 +36,7 @@ __FBSDID("$FreeBSD$");
  #include <dev/hptrr/os_bsd.h>
  #include <dev/hptrr/hptintf.h>
  
 -static int attach_generic = 1;
 +static int attach_generic = 0;
  TUNABLE_INT("hw.hptrr.attach_generic", &attach_generic);
  
  static int hpt_probe(device_t dev)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168910: commit references a PR
Date: Sun,  1 Jul 2012 00:41:07 +0000 (UTC)

 Author: eadler
 Date: Sun Jul  1 00:40:56 2012
 New Revision: 237863
 URL: http://svn.freebsd.org/changeset/base/237863
 
 Log:
   MFC r237178:
   	attach_generic causes missing devices in /dev when the driver interacts with some non-highpoint controollers. Change attach_generic to be off by default.
   
   PR:		kern/168910
   Approved by:	cperciva (implicit)
 
 Modified:
   stable/7/share/man/man4/hptrr.4
   stable/7/sys/dev/hptrr/hptrr_osm_bsd.c
 Directory Properties:
   stable/7/share/man/man4/   (props changed)
   stable/7/sys/   (props changed)
 
 Modified: stable/7/share/man/man4/hptrr.4
 ==============================================================================
 --- stable/7/share/man/man4/hptrr.4	Sun Jul  1 00:40:37 2012	(r237862)
 +++ stable/7/share/man/man4/hptrr.4	Sun Jul  1 00:40:56 2012	(r237863)
 @@ -50,8 +50,8 @@ hptrr_load="YES"
  The following tunables are settable from the loader:
  .Bl -ohang
  .It Va hw.hptrr.attach_generic
 -set to 0 to deny driver attach to chips with generic Marvell (non-HighPoint)
 -PCI identification. These chips are also supported by ata(4).
 +set to 1 to permit driver attach to chips with generic Marvell (non-HighPoint)
 +PCI identification. These chips are also supported by ata(4) and mvs(4).
  Some vendors are using same chips, but without providing RAID BIOS.
  .El
  .Sh DESCRIPTION
 @@ -112,7 +112,8 @@ This driver supersedes the older rr232x 
  .Xr ata 4 ,
  .Xr cam 4 ,
  .Xr hptmv 4 ,
 -.Xr loader 8
 +.Xr loader 8 ,
 +.Xr mvs 4
  .Sh HISTORY
  The
  .Nm
 
 Modified: stable/7/sys/dev/hptrr/hptrr_osm_bsd.c
 ==============================================================================
 --- stable/7/sys/dev/hptrr/hptrr_osm_bsd.c	Sun Jul  1 00:40:37 2012	(r237862)
 +++ stable/7/sys/dev/hptrr/hptrr_osm_bsd.c	Sun Jul  1 00:40:56 2012	(r237863)
 @@ -34,7 +34,7 @@
  #include <dev/hptrr/os_bsd.h>
  #include <dev/hptrr/hptintf.h>
  
 -static int attach_generic = 1;
 +static int attach_generic = 0;
  TUNABLE_INT("hw.hptrr.attach_generic", &attach_generic);
  
  static int hpt_probe(device_t dev)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Sun Jul 1 00:53:03 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168910 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168910: commit references a PR
Date: Sun,  2 Sep 2012 18:44:50 +0000 (UTC)

 Author: eadler
 Date: Sun Sep  2 18:44:40 2012
 New Revision: 240054
 URL: http://svn.freebsd.org/changeset/base/240054
 
 Log:
   MFC r237178,r237180:
   	Fix mdoc style nits
   
   PR:		kern/168910
   Approved by:	cperciva (implicit)
 
 Modified:
   stable/7/share/man/man4/hptrr.4
 Directory Properties:
   stable/7/share/man/man4/   (props changed)
 
 Modified: stable/7/share/man/man4/hptrr.4
 ==============================================================================
 --- stable/7/share/man/man4/hptrr.4	Sun Sep  2 18:40:17 2012	(r240053)
 +++ stable/7/share/man/man4/hptrr.4	Sun Sep  2 18:44:40 2012	(r240054)
 @@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd November 8, 2009
 +.Dd June 6, 2012
  .Dt HPTRR 4
  .Os
  .Sh NAME
 @@ -51,7 +51,10 @@ The following tunables are settable from
  .Bl -ohang
  .It Va hw.hptrr.attach_generic
  set to 1 to permit driver attach to chips with generic Marvell (non-HighPoint)
 -PCI identification. These chips are also supported by ata(4) and mvs(4).
 +PCI identification. These chips are also supported by
 +.Xr ata 4
 +and
 +.Xr mvs 4 .
  Some vendors are using same chips, but without providing RAID BIOS.
  .El
  .Sh DESCRIPTION
 @@ -112,8 +115,8 @@ This driver supersedes the older rr232x 
  .Xr ata 4 ,
  .Xr cam 4 ,
  .Xr hptmv 4 ,
 -.Xr loader 8 ,
 -.Xr mvs 4
 +.Xr mvs 4 ,
 +.Xr loader 8
  .Sh HISTORY
  The
  .Nm
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168910: commit references a PR
Date: Sun,  2 Sep 2012 18:45:16 +0000 (UTC)

 Author: eadler
 Date: Sun Sep  2 18:44:43 2012
 New Revision: 240055
 URL: http://svn.freebsd.org/changeset/base/240055
 
 Log:
   MFC r237178,r237180:
   	Fix mdoc style nits
   
   PR:		kern/168910
   Approved by:	cperciva (implicit)
 
 Modified:
   stable/8/share/man/man4/hptrr.4
 Directory Properties:
   stable/8/share/man/man4/   (props changed)
 
 Modified: stable/8/share/man/man4/hptrr.4
 ==============================================================================
 --- stable/8/share/man/man4/hptrr.4	Sun Sep  2 18:44:40 2012	(r240054)
 +++ stable/8/share/man/man4/hptrr.4	Sun Sep  2 18:44:43 2012	(r240055)
 @@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd November 8, 2009
 +.Dd June 6, 2012
  .Dt HPTRR 4
  .Os
  .Sh NAME
 @@ -51,7 +51,10 @@ The following tunables are settable from
  .Bl -ohang
  .It Va hw.hptrr.attach_generic
  set to 1 to permit driver attach to chips with generic Marvell (non-HighPoint)
 -PCI identification. These chips are also supported by ata(4) and mvs(4).
 +PCI identification. These chips are also supported by
 +.Xr ata 4
 +and
 +.Xr mvs 4 .
  Some vendors are using same chips, but without providing RAID BIOS.
  .El
  .Sh DESCRIPTION
 @@ -112,8 +115,8 @@ This driver supersedes the older rr232x 
  .Xr ata 4 ,
  .Xr cam 4 ,
  .Xr hptmv 4 ,
 -.Xr loader 8 ,
 -.Xr mvs 4
 +.Xr mvs 4 ,
 +.Xr loader 8
  .Sh HISTORY
  The
  .Nm
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168910: commit references a PR
Date: Sun,  2 Sep 2012 18:45:22 +0000 (UTC)

 Author: eadler
 Date: Sun Sep  2 18:44:47 2012
 New Revision: 240056
 URL: http://svn.freebsd.org/changeset/base/240056
 
 Log:
   MFC r237178,r237180:
   	Fix mdoc style nits
   
   PR:		kern/168910
   Approved by:	cperciva (implicit)
 
 Modified:
   stable/9/share/man/man4/hptrr.4
 Directory Properties:
   stable/9/share/man/man4/   (props changed)
 
 Modified: stable/9/share/man/man4/hptrr.4
 ==============================================================================
 --- stable/9/share/man/man4/hptrr.4	Sun Sep  2 18:44:43 2012	(r240055)
 +++ stable/9/share/man/man4/hptrr.4	Sun Sep  2 18:44:47 2012	(r240056)
 @@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd November 8, 2009
 +.Dd June 6, 2012
  .Dt HPTRR 4
  .Os
  .Sh NAME
 @@ -51,7 +51,10 @@ The following tunables are settable from
  .Bl -ohang
  .It Va hw.hptrr.attach_generic
  set to 1 to permit driver attach to chips with generic Marvell (non-HighPoint)
 -PCI identification. These chips are also supported by ata(4) and mvs(4).
 +PCI identification. These chips are also supported by
 +.Xr ata 4
 +and
 +.Xr mvs 4 .
  Some vendors are using same chips, but without providing RAID BIOS.
  .El
  .Sh DESCRIPTION
 @@ -112,8 +115,8 @@ This driver supersedes the older rr232x 
  .Xr ata 4 ,
  .Xr cam 4 ,
  .Xr hptmv 4 ,
 -.Xr loader 8 ,
 -.Xr mvs 4
 +.Xr mvs 4 ,
 +.Xr loader 8
  .Sh HISTORY
  The
  .Nm
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
