From nobody@FreeBSD.org  Tue May 29 16:58:20 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 06F1F106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 May 2012 16:58:20 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id E66808FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 May 2012 16:58:19 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q4TGwJ9P044576
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 May 2012 16:58:19 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q4TGwJBP044575;
	Tue, 29 May 2012 16:58:19 GMT
	(envelope-from nobody)
Message-Id: <201205291658.q4TGwJBP044575@red.freebsd.org>
Date: Tue, 29 May 2012 16:58:19 GMT
From: Petr Lampa <lampa@fit.vutbr.cz>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ixgbe flow control tunable regression
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         168440
>Category:       kern
>Synopsis:       [ixgbe] [patch] ixgbe flow control tunable regression
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-net
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 29 17:00:10 UTC 2012
>Closed-Date:    
>Last-Modified:  Sun Apr 20 02:53:17 UTC 2014
>Originator:     Petr Lampa
>Release:        9.0-STABLE
>Organization:
FIT BUT
>Environment:
FreeBSD xxx 9.0-STABLE FreeBSD 9.0-STABLE #0: Wed May 23 16:32:18 CEST 2012     root@xx:/usr/src/sys/amd64/compile/TEMP  amd64
>Description:
hw.ixgbe.flow_control tunable stopped working in the 2.4.5 version, the variable ixgbe_flow_control is not used at all. Previously it was used in ixgbe_set_flowcntl(). Now adapter->fc is used at that place, but it is not initialized properly from the tunable.
>How-To-Repeat:

>Fix:
Change ixgbe_attach() at line 530:

        /* Get Hardware Flow Control setting */
        hw->fc.requested_mode = ixgbe_fc_full;

to:

        /* Get Hardware Flow Control setting */
        hw->fc.requested_mode = ixgbe_flow_control;

The same problem exists in the ixv driver.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Apr 20 02:53:02 UTC 2014 
Responsible-Changed-Why:  
reclassify. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168440 
>Unformatted:
