From nobody@FreeBSD.org  Mon May 28 15:51:46 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 36F5C106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 May 2012 15:51:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 224298FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 May 2012 15:51:46 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q4SFpjXZ068371
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 May 2012 15:51:45 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q4SFpjuM068370;
	Mon, 28 May 2012 15:51:45 GMT
	(envelope-from nobody)
Message-Id: <201205281551.q4SFpjuM068370@red.freebsd.org>
Date: Mon, 28 May 2012 15:51:45 GMT
From: Sergey Budnevitch <sb@waeme.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ixgbe commit r232874 introduces code/comment mismatch
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         168414
>Category:       kern
>Synopsis:       [ixgbe] [patch] ixgbe commit r234137 introduces code/comment mismatch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-net
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 28 16:00:11 UTC 2012
>Closed-Date:    
>Last-Modified:  Sun Apr 20 02:54:03 UTC 2014
>Originator:     Sergey Budnevitch
>Release:        non-applicable
>Organization:
>Environment:
non-applicable
>Description:
Both comment and linux sources say PTHRESH should be 32, but code set it to 16 (according to 82599 datasheet PTHRESH field is the first six bits). Either code or comment should be fixed.
>How-To-Repeat:

>Fix:
--- src/sys/dev/ixgbe/ixgbe.c.orig	2012-05-28 15:46:35.000000000 +0000
+++ src/sys/dev/ixgbe/ixgbe.c	2012-05-28 15:46:57.000000000 +0000
@@ -1152,7 +1152,7 @@
 		 * from the Intel linux driver 3.8.21.
 		 * Prefetching enables tx line rate even with 1 queue.
 		 */
-		txdctl |= (16 << 0) | (1 << 8);
+		txdctl |= (32 << 0) | (1 << 8);
 		IXGBE_WRITE_REG(hw, IXGBE_TXDCTL(i), txdctl);
 	}
 


>Release-Note:
>Audit-Trail:

From: Sergey Budnevitch <sb@waeme.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/168414: ixgbe commit r232874 introduces code/comment mismatch
Date: Mon, 28 May 2012 20:23:55 +0400

 r234137 of course, not r232874.
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Apr 20 02:53:27 UTC 2014 
Responsible-Changed-Why:  
reclassify. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168414 
>Unformatted:
