From nobody@FreeBSD.org  Thu May 24 07:07:12 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 691C8106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 May 2012 07:07:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 53ABF8FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 May 2012 07:07:12 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q4O77BjM013672
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 May 2012 07:07:11 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q4O77BVF013671;
	Thu, 24 May 2012 07:07:11 GMT
	(envelope-from nobody)
Message-Id: <201205240707.q4O77BVF013671@red.freebsd.org>
Date: Thu, 24 May 2012 07:07:11 GMT
From: Sergey Budnevitch <sb@waeme.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ixgbe driver compiled in kernel has no Flow Director support although loaded as a module has one
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         168294
>Category:       kern
>Synopsis:       [ixgbe] [patch] ixgbe driver compiled in kernel has no Flow Director support although loaded as a module has one
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-net
>State:          patched
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 24 07:10:03 UTC 2012
>Closed-Date:    
>Last-Modified:  Sat Jun 02 13:21:29 UTC 2012
>Originator:     Sergey Budnevitch
>Release:        FreeBSD 9.0-RELEASE
>Organization:
>Environment:
FreeBSD fbsd9-amd64-ovl.xxxx.xxx 9.0-RELEASE FreeBSD 9.0-RELEASE #21: Tue May 15 10:26:20 UTC 2012     root@fbsd9-amd64-ovl.xxx.xxx:/usr/obj/usr/src/sys/D  amd64
>Description:
Flow Director support is enabled by defining IXGBE_FDIR. modules/ixgbe/Makefile 
adds -DIXGBE_FDIR to CFLAGS, so Flow Director works with ixgbe loaded as a module,
but built in kernel leave IXGBE_FDIR undefined.
>How-To-Repeat:
compile kernel with
device ixgbe
>Fix:
Coping CFLAGS from modules/ixgbe/Makefile to sys/conf/files fix the problem.

--- sys/conf/files.orig 2012-05-21 14:57:14.000000000 +0000
+++ sys/conf/files      2012-05-21 14:59:13.000000000 +0000
@@ -1366,7 +1366,7 @@
 dev/ixgb/ixgb_ee.c             optional ixgb
 dev/ixgb/ixgb_hw.c             optional ixgb
 dev/ixgbe/ixgbe.c              optional ixgbe inet \
-       compile-with "${NORMAL_C} -I$S/dev/ixgbe"
+       compile-with "${NORMAL_C} -I$S/dev/ixgbe -DSMP -DIXGBE_FDIR"
 dev/ixgbe/ixv.c                        optional ixgbe inet \
        compile-with "${NORMAL_C} -I$S/dev/ixgbe"
 dev/ixgbe/ixgbe_phy.c          optional ixgbe inet \


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu May 24 20:50:32 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168294 
State-Changed-From-To: open->patched 
State-Changed-By: maxim 
State-Changed-When: Sat Jun 2 13:19:59 UTC 2012 
State-Changed-Why:  
jfv@ has committed the patch, see r235920. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=168294 
>Unformatted:
