From nobody@FreeBSD.org  Wed Mar 28 01:35:08 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B174D1065674
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Mar 2012 01:35:08 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 9D8728FC18
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Mar 2012 01:35:08 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q2S1Z7LA036336
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Mar 2012 01:35:07 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q2S1Z7YU036335;
	Wed, 28 Mar 2012 01:35:07 GMT
	(envelope-from nobody)
Message-Id: <201203280135.q2S1Z7YU036335@red.freebsd.org>
Date: Wed, 28 Mar 2012 01:35:07 GMT
From: Kaho Toshikazu <kaho@elam.kais.kyoto-u.ac.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: other id for atkbdc
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         166459
>Category:       kern
>Synopsis:       [atkbdc] [patch] other id for atkbdc
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    jkim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 28 01:40:08 UTC 2012
>Closed-Date:    Mon Apr 02 17:37:43 UTC 2012
>Last-Modified:  Mon Apr 02 17:37:43 UTC 2012
>Originator:     Kaho Toshikazu
>Release:        10-CURRENT
>Organization:
>Environment:
FreeBSD catsidhe.pf2.ed.niigata-u.ac.jp 10.0-CURRENT FreeBSD 10.0-CURRENT #4 r233525M: Tue Mar 27 12:48:27 UTC 2012     kaho@pf2.ed.niigata-u.ac.jp:/usr/obj/usr/src/sys/SOIL  i386

>Description:
atkbdc_isa.c doesn't have a KBC id which is reported from acpi table on
some machines, and PS2 keyboard and mouse are not probed/attached.

`acpidump -dt` showed about "KBC" is :

Device (KBC)
{
  Name (R101, 0x0303D041)
  Name (R106, 0x2003D041)
  Method (_HID, 0, NotSerialized)
  {
    If (SIDF)
    {
      Return (R101)
    }
    Else
    {
      Return (R106)
    }
}

>How-To-Repeat:
Boot FreeBSD 9/10 on some machines, PS2 keyboard and mouse do not do any jobs.
Fujitsu FMV-BIBLO LOOX T70S/V and Sharp PC-CV50 have the problem here, and
google shows some machines have similar acpi table.
>Fix:
Add id.

Index: sys/dev/atkbdc/atkbdc_isa.c
===================================================================
--- sys/dev/atkbdc/atkbdc_isa.c (revision 233525)
+++ sys/dev/atkbdc/atkbdc_isa.c (working copy)
@@ -87,6 +87,7 @@
 
 static struct isa_pnp_id atkbdc_ids[] = {
        { 0x0303d041, "Keyboard controller (i8042)" },  /* PNP0303 */
+       { 0x2003d041, "Keyboard controller (i8042)" },  /* PNP2003 */
        { 0 }
 };


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->jkim 
Responsible-Changed-By: jkim 
Responsible-Changed-When: Wed Mar 28 17:53:08 UTC 2012 
Responsible-Changed-Why:  
I'll take it.  Actually, the PNP ID is PNP0320 (little-endian). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166459 
State-Changed-From-To: open->patched 
State-Changed-By: jkim 
State-Changed-When: Wed Mar 28 17:59:21 UTC 2012 
State-Changed-Why:  
Committed on head with the comment fix. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166459 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/166459: commit references a PR
Date: Wed, 28 Mar 2012 17:58:48 +0000 (UTC)

 Author: jkim
 Date: Wed Mar 28 17:58:37 2012
 New Revision: 233619
 URL: http://svn.freebsd.org/changeset/base/233619
 
 Log:
   Add a PNP ID for Japanese 106-key keyboard.
   
   PR:		kern/166459
   MFC after:	3 days
 
 Modified:
   head/sys/dev/atkbdc/atkbdc_isa.c
 
 Modified: head/sys/dev/atkbdc/atkbdc_isa.c
 ==============================================================================
 --- head/sys/dev/atkbdc/atkbdc_isa.c	Wed Mar 28 17:25:29 2012	(r233618)
 +++ head/sys/dev/atkbdc/atkbdc_isa.c	Wed Mar 28 17:58:37 2012	(r233619)
 @@ -87,6 +87,7 @@ static driver_t atkbdc_isa_driver = {
  
  static struct isa_pnp_id atkbdc_ids[] = {
  	{ 0x0303d041, "Keyboard controller (i8042)" },	/* PNP0303 */
 +	{ 0x2003d041, "Keyboard controller (i8042)" },	/* PNP0320 */
  	{ 0 }
  };
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: Kaho Toshikazu <kaho@elam.kais.kyoto-u.ac.jp>
To: jkim@freebsd.org, bug-followup@freebsd.org
Cc:  
Subject: Re: kern/166459: [atkbdc] [patch] other id for atkbdc
Date: Thu, 29 Mar 2012 09:22:31 +0900

 Hello, Jung-uk Kim
 
 Thank you for correcting comment and committing.
 
 -- 
 Kaho Toshikazu
State-Changed-From-To: patched->closed 
State-Changed-By: jkim 
State-Changed-When: Mon Apr 2 17:36:43 UTC 2012 
State-Changed-Why:  
MFC'ed to all supported branches.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166459 
>Unformatted:
