From eugen@eg.sd.rdtc.ru  Wed Mar  7 06:08:08 2012
Return-Path: <eugen@eg.sd.rdtc.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C81A71065672
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Mar 2012 06:08:08 +0000 (UTC)
	(envelope-from eugen@eg.sd.rdtc.ru)
Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13::5])
	by mx1.freebsd.org (Postfix) with ESMTP id 318F08FC13
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Mar 2012 06:08:07 +0000 (UTC)
Received: from eg.sd.rdtc.ru (localhost [127.0.0.1])
	by eg.sd.rdtc.ru (8.14.5/8.14.5) with ESMTP id q27684dT004161
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 7 Mar 2012 13:08:04 +0700 (NOVT)
	(envelope-from eugen@eg.sd.rdtc.ru)
Received: (from eugen@localhost)
	by eg.sd.rdtc.ru (8.14.5/8.14.5/Submit) id q276843a004160;
	Wed, 7 Mar 2012 13:08:04 +0700 (NOVT)
	(envelope-from eugen)
Message-Id: <201203070608.q276843a004160@eg.sd.rdtc.ru>
Date: Wed, 7 Mar 2012 13:08:04 +0700 (NOVT)
From: Eugene Grosbein <eugen@grosbein.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [uart] [patch] Add support for MosChip MCS9904 PCIe x1 four serial ports controller
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         165804
>Category:       kern
>Synopsis:       [uart] [patch] Add support for MosChip MCS9904 PCIe x1 four serial ports controller
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 07 06:10:08 UTC 2012
>Closed-Date:    Wed Dec 12 07:26:03 UTC 2012
>Last-Modified:  Wed Dec 12 07:30:00 UTC 2012
>Originator:     Eugene Grosbein
>Release:        FreeBSD 8.3-PRERELEASE i386
>Organization:
RDTC JSC
>Environment:
System: FreeBSD eg.sd.rdtc.ru 8.3-PRERELEASE FreeBSD 8.3-PRERELEASE #39: Wed Mar 7 12:16:36 NOVT 2012 root@eg.sd.rdtc.ru:/usr/local/obj/usr/local/src/sys/EG i386

>Description:
	uart(4) supports MosChip MCS9900/MCS9901 based controllers
	but not MCS9904.
	With following patch applied, all four serial ports are attached
	and work just find.

>How-To-Repeat:

	Use MosChip MCS9904-based PCIe x1 4-port serial card,
	ports do not attach:

pcib2: <ACPI PCI-PCI bridge> irq 16 at device 28.0 on pci0
pci2: <ACPI PCI bus> on pcib2
pci2: <simple comms, UART> at device 0.0 (no driver attached)
pci2: <simple comms, UART> at device 0.1 (no driver attached)
pci2: <simple comms, UART> at device 0.2 (no driver attached)
pci2: <simple comms, UART> at device 0.3 (no driver attached)

>Fix:

	Add card's PCI ID to uart(4) driver:

--- sys/dev/uart/uart_bus_pci.c.orig	2012-03-07 12:12:41.000000000 +0700
+++ sys/dev/uart/uart_bus_pci.c	2012-03-07 12:13:44.000000000 +0700
@@ -122,6 +122,8 @@
 	"MosChip MCS9900 PCIe to Peripheral Controller", 0x10 },
 { 0x9710, 0x9901, 0xa000, 0x1000,
 	"MosChip MCS9901 PCIe to Peripheral Controller", 0x10 },
+{ 0x9710, 0x9904, 0xa000, 0x1000,
+	"MosChip MCS9904 PCIe to Peripheral Controller", 0x10 },
 { 0xdeaf, 0x9051, 0xffff, 0, "Middle Digital PC Weasel Serial Port", 0x10 },
 { 0xffff, 0, 0xffff, 0, NULL, 0, 0}
 };


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->remko 
Responsible-Changed-By: remko 
Responsible-Changed-When: Wed Mar 7 06:22:10 UTC 2012 
Responsible-Changed-Why:  
Preparing commit already. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165804 
State-Changed-From-To: open->patched 
State-Changed-By: remko 
State-Changed-When: Wed Mar 7 06:42:30 UTC 2012 
State-Changed-Why:  
Patched in -HEAD, will be MFC'ed after around a week. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165804 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/165804: commit references a PR
Date: Wed,  7 Mar 2012 06:42:31 +0000 (UTC)

 Author: remko
 Date: Wed Mar  7 06:42:21 2012
 New Revision: 232639
 URL: http://svn.freebsd.org/changeset/base/232639
 
 Log:
   Add support for the MosChip MCS9904 four serial ports
   controller.
   
   PR:		165804
   Submitted by:	Eugene Grosbein
   MFC after:	1 week
 
 Modified:
   head/sys/dev/uart/uart_bus_pci.c
 
 Modified: head/sys/dev/uart/uart_bus_pci.c
 ==============================================================================
 --- head/sys/dev/uart/uart_bus_pci.c	Wed Mar  7 06:25:17 2012	(r232638)
 +++ head/sys/dev/uart/uart_bus_pci.c	Wed Mar  7 06:42:21 2012	(r232639)
 @@ -126,6 +126,8 @@ static struct pci_id pci_ns8250_ids[] = 
  	"MosChip MCS9900 PCIe to Peripheral Controller", 0x10 },
  { 0x9710, 0x9901, 0xa000, 0x1000,
  	"MosChip MCS9901 PCIe to Peripheral Controller", 0x10 },
 +{ 0x9710, 0x9904, 0xa000, 0x1000,
 +	"MosChip MCS9904 PCIe to Peripheral Controller", 0x10 },
  { 0xdeaf, 0x9051, 0xffff, 0, "Middle Digital PC Weasel Serial Port", 0x10 },
  { 0xffff, 0, 0xffff, 0, NULL, 0, 0}
  };
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: Eugene Grosbein <eugen@grosbein.net>
To: bug-followup@FreeBSD.ORG
Cc:  
Subject: Re: kern/165804: [uart] [patch] Add support for MosChip MCS9904 PCIe
 x1 four serial ports controller
Date: Wed, 07 Mar 2012 15:32:47 +0700

 Just for archives: trade name of my copy of such card is:
 ST-Lab CP-130 FP PCIe Serial Card 4 Ports with Power.

From: Eugene Grosbein <egrosbein@rdtc.ru>
To: bug-followup@FreeBSD.ORG
Cc: remko@FreeBSD.ORG
Subject: Re: kern/165804: [uart] [patch] Add support for MosChip MCS9904 PCIe
 x1 four serial ports controller
Date: Mon, 23 Apr 2012 21:42:26 +0700

 Hi!
 
 FreeBSD 8.3 is out and branch is unfrozen. Please perform MFC.
 Thank you.
 
 Eugene Grosbein

From: Remko Lodder <remko@elvandar.org>
To: Eugene Grosbein <egrosbein@rdtc.ru>
Cc: bug-followup@FreeBSD.ORG,
 remko@FreeBSD.ORG
Subject: Re: kern/165804: [uart] [patch] Add support for MosChip MCS9904 PCIe x1 four serial ports controller
Date: Tue, 24 Apr 2012 20:53:57 +0200

 On Apr 23, 2012, at 4:42 PM, Eugene Grosbein wrote:
 
 > Hi!
 
 Hi Eugene,
 
 >=20
 > FreeBSD 8.3 is out and branch is unfrozen. Please perform MFC.
 > Thank you.
 
 Thank you for letting me know, I waited for that moment indeed to =
 perform multiple MFC's that I had been holding off
 to wait for this moment.
 
 I will try to make it happen in the next few days, when I should have =
 the time to do so (including testbuilding the
 changes ofcourse :))
 
 Cheers && thank you for your patience in waiting!
 
 >=20
 > Eugene Grosbein
 
 --=20
 /"\   With kind regards,			| remko@elvandar.org
 \ /   Remko Lodder			| remko@FreeBSD.org
 X    FreeBSD					| =
 http://www.evilcoder.org
 / \   The Power to Serve		| Quis custodiet ipsos custodes
 

From: Eugene Grosbein <egrosbein@rdtc.ru>
To: bug-followup@FreeBSD.ORG
Cc: Remko Lodder <remko@elvandar.org>
Subject: Re: kern/165804: [uart] [patch] Add support for MosChip MCS9904 PCIe
 x1 four serial ports controller
Date: Wed, 12 Dec 2012 14:06:36 +0700

 Hi!
 
 Please perform MFC of the patch to 8.3-STABLE, it waits over half of a year.
 
 Eugene Grosbein
State-Changed-From-To: patched->closed 
State-Changed-By: remko 
State-Changed-When: Wed Dec 12 07:26:01 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165804 

From: Remko Lodder <remko@elvandar.org>
To: Eugene Grosbein <egrosbein@rdtc.ru>
Cc: bug-followup@FreeBSD.ORG
Subject: Re: kern/165804: [uart] [patch] Add support for MosChip MCS9904 PCIe x1 four serial ports controller
Date: Wed, 12 Dec 2012 08:25:31 +0100

 On Dec 12, 2012, at 8:06 AM, Eugene Grosbein <egrosbein@rdtc.ru> wrote:
 
 > Hi!
 
 Hi!
 
 >=20
 > Please perform MFC of the patch to 8.3-STABLE, it waits over half of a =
 year.
 
 Thanks for reminding me, I forgot this. I just committed it to the =
 stable/{7,8,9} branches.
 
 Cheers
 Remko
 
 >=20
 > Eugene Grosbein
 
 --=20
 /"\   With kind regards,			| remko@elvandar.org
 \ /   Remko Lodder			| remko@FreeBSD.org
 X    FreeBSD					| =
 http://www.evilcoder.org
 / \   The Power to Serve		| Quis custodiet ipsos custodes
 
>Unformatted:
