From simon@comsys.ntu-kpi.kiev.ua  Tue Feb 28 11:40:26 2012
Return-Path: <simon@comsys.ntu-kpi.kiev.ua>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2FBCE106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 28 Feb 2012 11:40:26 +0000 (UTC)
	(envelope-from simon@comsys.ntu-kpi.kiev.ua)
Received: from comsys.kpi.ua (comsys.kpi.ua [77.47.192.42])
	by mx1.freebsd.org (Postfix) with ESMTP id D7C768FC18
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 28 Feb 2012 11:40:25 +0000 (UTC)
Received: from pm513-1.comsys.kpi.ua ([10.18.52.101] helo=pm513-1.comsys.ntu-kpi.kiev.ua)
	by comsys.kpi.ua with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.63)
	(envelope-from <simon@comsys.ntu-kpi.kiev.ua>)
	id 1S2LPr-0008LX-9n
	for FreeBSD-gnats-submit@freebsd.org; Tue, 28 Feb 2012 13:40:23 +0200
Received: by pm513-1.comsys.ntu-kpi.kiev.ua (Postfix, from userid 1001)
	id 5A3541CC36; Tue, 28 Feb 2012 13:40:23 +0200 (EET)
Message-Id: <20120228114023.GA68878@pm513-1.comsys.ntu-kpi.kiev.ua>
Date: Tue, 28 Feb 2012 13:40:23 +0200
From: Andrey Simonenko <simon@comsys.ntu-kpi.kiev.ua>
To: FreeBSD-gnats-submit@freebsd.org
Subject: setgroupent() does not make file descrptors opened

>Number:         165527
>Category:       kern
>Synopsis:       [libc] [patch] setgroupent() does not make file descrptors opened
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 28 11:50:08 UTC 2012
>Closed-Date:    
>Last-Modified:  Tue Feb 28 18:58:15 UTC 2012
>Originator:     Andrey Simonenko
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
>Description:

If the setgroupent() library function is called with non-zero argument,
then file descriptors used for accessing databases should be left opened.
Actually this does not work and reduce performance.

>How-To-Repeat:
>Fix:
--- getgrent.c.orig	2007-12-12 12:08:02.000000000 +0200
+++ getgrent.c	2012-02-28 11:00:23.000000000 +0200
@@ -811,6 +811,7 @@ files_setgrent(void *retval, void *mdata
 			rewind(st->fp);
 		else if (stayopen)
 			st->fp = fopen(_PATH_GROUP, "r");
+		st->stayopen = stayopen;
 		break;
 	case ENDGRENT:
 		if (st->fp != NULL) {
@@ -1252,6 +1253,7 @@ compat_setgrent(void *retval, void *mdat
 			rewind(st->fp);
 		else if (stayopen)
 			st->fp = fopen(_PATH_GROUP, "r");
+		st->stayopen = stayopen;
 		set_setent(dtab, mdata);
 		(void)_nsdispatch(NULL, dtab, NSDB_GROUP_COMPAT, "setgrent",
 		    compatsrc, 0);
>Release-Note:
>Audit-Trail:
>Unformatted:
