From sascha@schumann.cx  Sun Feb  6 23:20:25 2000
Return-Path: <sascha@schumann.cx>
Received: from mail.iserlohn.netsurf.de (mail.iserlohn.netsurf.de [194.195.194.253])
	by builder.freebsd.org (Postfix) with ESMTP id F21993E84
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  6 Feb 2000 23:20:23 -0800 (PST)
Received: from schumann.cx (hennen32s.iserlohn.netsurf.de [194.195.194.226])
	by mail.iserlohn.netsurf.de (8.9.1/8.9.1) with SMTP id IAA32573
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 7 Feb 2000 08:21:16 +0100
Received: (qmail 7355 invoked from network); 7 Feb 2000 07:21:03 -0000
Received: from unknown (HELO flaubert.foo.bar) (192.168.0.99)
  by guerilla.foo.bar with SMTP; 7 Feb 2000 07:21:03 -0000
Received: (qmail 6910 invoked by uid 500); 7 Feb 2000 07:21:25 -0000
Received: (qmail 6854 invoked from network); 7 Feb 2000 07:19:31 -0000
Received: from guerilla.foo.bar (HELO schumann.cx) (192.168.0.1)
  by flaubert.foo.bar with SMTP; 7 Feb 2000 07:19:31 -0000
Received: (qmail 7334 invoked by alias); 7 Feb 2000 07:19:09 -0000
Received: (qmail 7330 invoked by uid 500); 7 Feb 2000 07:19:09 -0000
Message-Id: <20000207071909.7329.qmail@schumann.cx>
Date: 7 Feb 2000 07:19:09 -0000
From: sascha@schumann.cx
To: FreeBSD-gnats-submit@freebsd.org
Cc: sascha@schumann.cx
Subject: cosmetic cleanup in sys/dev/ppbus/pcfclock.c
X-Send-Pr-Version: 3.2

>Number:         16551
>Category:       kern
>Synopsis:       cosmetic cleanup in sys/dev/ppbus/pcfclock.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb  6 23:30:01 PST 2000
>Closed-Date:    Wed Jun 6 14:00:07 PDT 2001
>Last-Modified:  Wed Jun 06 14:00:24 PDT 2001
>Originator:     Sascha Schumann
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
>Environment:

	NA

>Description:

	Some minor cleanup

>How-To-Repeat:

	NA

>Fix:

--- /usr/src/sys/dev/ppbus/pcfclock.c	Sun Jan 23 15:41:04 2000
+++ pcfclock.c	Sat Jan 29 12:13:38 2000
@@ -13,7 +13,7 @@
  * THIS SOFTWARE IS PROVIDED BY SASCHA SCHUMANN ``AS IS'' AND ANY EXPRESS OR
  * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.  IN NO
- * EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
  * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA,
  * OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
@@ -52,7 +52,6 @@
 
 struct pcfclock_data {
 	int	count;
-	struct	ppb_device pcfclock_dev;
 };
 
 #define DEVTOSOFTC(dev) \
@@ -126,7 +125,6 @@
 static void
 pcfclock_identify(driver_t *driver, device_t parent)
 {
-
 	BUS_ADD_CHILD(parent, 0, PCFCLOCK_NAME, 0);
 }
 
@@ -186,9 +184,8 @@
 	device_t ppbus = device_get_parent(pcfclockdev);
 
 	sc->count--;
-	if (sc->count == 0) {
+	if (sc->count == 0)
 		ppb_release_bus(ppbus, pcfclockdev);
-	}
 
 	return (0);
 }
@@ -223,6 +220,7 @@
 	year = NR(buf, 14);
 	if (year < 70)
 		year += 100;
+
 	printf(PCFCLOCK_NAME "%d: %02d.%02d.%4d %02d:%02d:%02d, "
 			"battery status: %s\n",
 			unit,

>Release-Note:
>Audit-Trail:

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: sascha@schumann.cx
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: kern/16551: cosmetic cleanup in sys/dev/ppbus/pcfclock.c 
Date: Wed, 16 Feb 2000 10:35:39 +0200

 On 07 Feb 2000 07:19:09 GMT, sascha@schumann.cx wrote:
 
 > 	Some minor cleanup
 
 Once I have your feedback on the severity of PR 16552, I'll ask Jordan
 for permission to commit that patch.  This one can definitely wait 'til
 after 4.0-RELEASE. ;-)
 
 later,
 Sheldon.
 

From: Sascha Schumann <sascha@schumann.cx>
To: Sheldon Hearn <sheldonh@uunet.co.za>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: kern/16551: cosmetic cleanup in sys/dev/ppbus/pcfclock.c
Date: Wed, 16 Feb 2000 12:22:25 +0100

 --Clx92ZfkiYIKRjnr
 Content-Type: text/plain; charset=us-ascii
 Content-Transfer-Encoding: quoted-printable
 
 On Wed, Feb 16, 2000 at 10:35:39AM +0200, Sheldon Hearn wrote:
 >=20
 >=20
 > On 07 Feb 2000 07:19:09 GMT, sascha@schumann.cx wrote:
 >=20
 > > 	Some minor cleanup
 >=20
 > Once I have your feedback on the severity of PR 16552, I'll ask Jordan
 > for permission to commit that patch.  This one can definitely wait 'til
 > after 4.0-RELEASE. ;-)
 
     I agree. Thanks for managing the PRs.
 
 --=20
 
           Regards,
 
                             Sascha Schumann
                                  Consultant
 
 --Clx92ZfkiYIKRjnr
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.0.1 (GNU/Linux)
 Comment: For info see http://www.gnupg.org
 
 iD8DBQE4qohxGBw/Y3qI0yQRAksCAJ0ayX/mAbv8GkANm8W9InFGGmkc4ACeKlqB
 mJG6UhyCvlhwsYuk9uDFXiM=
 =QbNl
 -----END PGP SIGNATURE-----
 
 --Clx92ZfkiYIKRjnr--
 
State-Changed-From-To: open->closed 
State-Changed-By: phk 
State-Changed-When: Wed Jun 6 14:00:07 PDT 2001 
State-Changed-Why:  
fixed, thanks! 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=16551 
>Unformatted:
