From nobody@FreeBSD.org  Mon Jan 16 17:08:53 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 08BDE106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 16 Jan 2012 17:08:53 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id EAAAC8FC19
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 16 Jan 2012 17:08:52 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0GH8qY1072596
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 16 Jan 2012 17:08:52 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q0GH8qOl072595;
	Mon, 16 Jan 2012 17:08:52 GMT
	(envelope-from nobody)
Message-Id: <201201161708.q0GH8qOl072595@red.freebsd.org>
Date: Mon, 16 Jan 2012 17:08:52 GMT
From: Devin Teske <dteske@vicor.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] buildworld WITHOUT_OPENSSL stops at lib/libarchive
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         164206
>Category:       kern
>Synopsis:       [build] [patch] buildworld WITHOUT_OPENSSL stops at lib/libarchive
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kientzle
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 16 17:10:08 UTC 2012
>Closed-Date:    
>Last-Modified:  Thu May 03 22:43:13 UTC 2012
>Originator:     Devin Teske
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
FIS Global, Inc.
>Environment:
FreeBSD scribe.vicor.com 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2010
root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
When performing buildworld while specifying WITHOUT_OPENSSL, the depend target fails during mkdep. Output below:

$ make buildworld -DWITHOUT_OPENSSL
[snip]
===> lib/libarchive (depend)
rm -f .depend
mkdep -f .depend -a -DHAVE_BZLIB_H=1 -DHAVE_LIBLZMA=1 -DHAVE_LZMA_H=1 -DPLATFORM_CONFIG_H=\"/usr/src/lib/libarchive/config_freebsd.h\" -I/usr/obj/usr/src/lib/libarchive /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_check_magic.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_entry.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_entry_copy_stat.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_entry_stat.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_entry_strmode.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_entry_link_resolver.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_entry_xattr.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_data_into_fd.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_disk
 .c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_disk_entry_from_file.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_disk_set_standard_lookup.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_extract.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_open_fd.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_open_file.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_open_filename.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_open_memory.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_all.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_bzip2.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_compress.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive
 /archive_read_support_compression_gzip.c /usr/src/lib/libarc!
 hive/../.../contrib/libarchive/libarchive/archive_read_support_compression_none.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_program.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_rpm.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_uu.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_xz.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_all.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_ar.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_cpio.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_empty.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_iso9660.c /usr/src/lib/libarchive/../../con
 trib/libarchive/libarchive/archive_read_support_format_mtree.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_raw.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_tar.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_xar.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_zip.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_string.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_string_sprintf.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_util.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_virtual.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_disk.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_disk
 _set_standard_lookup.c /usr/src/lib/libarchive/../../contrib!
 /libarchiv!
 e/libarchive/archive_write_open_fd.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_open_file.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_open_filename.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_open_memory.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_compression_bzip2.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_compression_compress.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_compression_gzip.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_compression_none.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_compression_program.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_compression_xz.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_format.c /usr/src/lib/
 libarchive/../../contrib/libarchive/libarchive/archive_write_set_format_ar.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_format_by_name.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_format_cpio.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_format_cpio_newc.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_format_mtree.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_format_pax.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_format_shar.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_format_ustar.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_format_zip.c /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/filter_fork.c
In file included from /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_xar.c:57:
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_hash.h:129:20: error: sha1.h: No such file or directory
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_hash.h:166:20: error: sha2.h: No such file or directory
In file included from /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_set_format_mtree.c:42:
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_hash.h:129:20: error: sha1.h: No such file or directory
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_hash.h:166:20: error: sha2.h: No such file or directory
mkdep: compile failed
>How-To-Repeat:
1. csup RELENG_9
2. cd /usr/src
3. make buildworld -DWITHOUT_OPENSSL
4. See above description for error output
>Fix:
See attached patch.

The fix comes by analyzing the files mentioned in the error (archive_read_support_format_xar.c and archive_write_set_format_mtree.c). These files reveal that it is the definition of the macros in config_freebsd.h which are causing the failure of mkdep. The attached patch allows WITHOUT_OPENSSL to succeed for all stages of make in libarchive.

Patch attached with submission follows:

--- lib/libarchive/config_freebsd.h.orig	2012-01-05 03:44:55.000000000 -0800
+++ lib/libarchive/config_freebsd.h	2012-01-13 18:43:46.000000000 -0800
@@ -176,9 +176,4 @@
 #define	ARCHIVE_HASH_SHA256_OPENSSL 1
 #define	ARCHIVE_HASH_SHA384_OPENSSL 1
 #define	ARCHIVE_HASH_SHA512_OPENSSL 1
-#else
-#define	ARCHIVE_HASH_MD5_LIBC 1
-#define	ARCHIVE_HASH_SHA1_LIBC 1
-#define	ARCHIVE_HASH_SHA256_LIBC 1
-#define	ARCHIVE_HASH_SHA512_LIBC 1
 #endif


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->kientzle 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu May 3 22:42:52 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164206 
>Unformatted:
