From eugen@eg.sd.rdtc.ru  Mon Dec 26 05:36:31 2011
Return-Path: <eugen@eg.sd.rdtc.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 45541106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Dec 2011 05:36:31 +0000 (UTC)
	(envelope-from eugen@eg.sd.rdtc.ru)
Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13::5])
	by mx1.freebsd.org (Postfix) with ESMTP id A21208FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Dec 2011 05:36:30 +0000 (UTC)
Received: from eg.sd.rdtc.ru (localhost [127.0.0.1])
	by eg.sd.rdtc.ru (8.14.5/8.14.5) with ESMTP id pBQ5aRom023761
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Dec 2011 12:36:27 +0700 (NOVT)
	(envelope-from eugen@eg.sd.rdtc.ru)
Received: (from eugen@localhost)
	by eg.sd.rdtc.ru (8.14.5/8.14.5/Submit) id pBQ5aR2s023760;
	Mon, 26 Dec 2011 12:36:27 +0700 (NOVT)
	(envelope-from eugen)
Message-Id: <201112260536.pBQ5aR2s023760@eg.sd.rdtc.ru>
Date: Mon, 26 Dec 2011 12:36:27 +0700 (NOVT)
From: Eugene Grosbein <eugen@eg.sd.rdtc.ru>
Reply-To: Eugene Grosbein <eugen@eg.sd.rdtc.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [kern] sysctl net.inet.icmp.icmplim_output description is misleading
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         163623
>Category:       kern
>Synopsis:       [kernel] sysctl net.inet.icmp.icmplim_output description is misleading
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 26 05:40:12 UTC 2011
>Closed-Date:    Thu Mar 22 03:41:52 UTC 2012
>Last-Modified:  Thu Mar 22 03:41:52 UTC 2012
>Originator:     Eugene Grosbein
>Release:        FreeBSD 8.2-STABLE i386
>Organization:
RDTC JSC
>Environment:
System: FreeBSD eg.sd.rdtc.ru 8.2-STABLE FreeBSD 8.2-STABLE #36: Fri Dec 23 15:04:05 NOVT 2011 root@eg.sd.rdtc.ru:/usr/local/obj/usr/local/src/sys/EG i386

>Description:

	"sysctl -d net.inet.icmp.icmplim_output" says:

net.inet.icmp.icmplim_output: Enable rate limiting of ICMP responses

	In fact, this setting does not control rate limiting of ICMP responses.
	Instead, it controls whether kernel writes log messages
	about this limiting or not.

>How-To-Repeat:

	See above.

>Fix:

	Change wording in src/sys/netinet/ip_icmp.c for this setting.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Mon Dec 26 05:52:26 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163623 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/163623: commit references a PR
Date: Sat,  7 Jan 2012 00:11:45 +0000 (UTC)

 Author: eadler (ports committer)
 Date: Sat Jan  7 00:11:36 2012
 New Revision: 229749
 URL: http://svn.freebsd.org/changeset/base/229749
 
 Log:
   - Fix sysctl description
   
   PR:		163623
   Submitted by:	Eugene Grosbein <eugen@eg.sd.rdtc.ru>
   Approved by:	bz
 
 Modified:
   head/sys/netinet/ip_icmp.c
 
 Modified: head/sys/netinet/ip_icmp.c
 ==============================================================================
 --- head/sys/netinet/ip_icmp.c	Sat Jan  7 00:07:23 2012	(r229748)
 +++ head/sys/netinet/ip_icmp.c	Sat Jan  7 00:11:36 2012	(r229749)
 @@ -89,7 +89,7 @@ static VNET_DEFINE(int, icmplim_output) 
  #define	V_icmplim_output		VNET(icmplim_output)
  SYSCTL_VNET_INT(_net_inet_icmp, OID_AUTO, icmplim_output, CTLFLAG_RW,
  	&VNET_NAME(icmplim_output), 0,
 -	"Enable rate limiting of ICMP responses");
 +	"Enable logging of ICMP response rate limiting");
  
  #ifdef INET
  VNET_DEFINE(struct icmpstat, icmpstat);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: eadler 
State-Changed-When: Sat Jan 7 03:48:19 UTC 2012 
State-Changed-Why:  
committed in r229749 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163623 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Thu Mar 22 03:41:51 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163623 
>Unformatted:
