From nobody@FreeBSD.org  Thu Dec 22 19:54:56 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CD07E10656B2
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Dec 2011 19:54:56 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id AB7458FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Dec 2011 19:54:56 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBMJsuHd047099
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Dec 2011 19:54:56 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pBMJsuwo047098;
	Thu, 22 Dec 2011 19:54:56 GMT
	(envelope-from nobody)
Message-Id: <201112221954.pBMJsuwo047098@red.freebsd.org>
Date: Thu, 22 Dec 2011 19:54:56 GMT
From: Dan McGregor <dan.mcgregor@usask.ca>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Return of uninitialized value in Chelsio T3 driver
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         163545
>Category:       kern
>Synopsis:       [cxgb] [patch] Return of uninitialized value in Chelsio T3 driver
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    np
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 22 20:00:26 UTC 2011
>Closed-Date:    Thu Oct 25 19:11:06 UTC 2012
>Last-Modified:  Thu Oct 25 19:11:06 UTC 2012
>Originator:     Dan McGregor
>Release:        9.0-PRERELEASE
>Organization:
>Environment:
FreeBSD shadrach.dyndns.org 9.0-PRERELEASE FreeBSD 9.0-PRERELEASE #8 r228275: Mon Dec  5 14:05:35 CST 2011     dan@shadrach.dyndns.org:/usr/obj/usr/src9/sys/SHADRACH  amd64

>Description:
In the Chelsio T3 driver there is an uninitialized value returned by
aq100x_power_down in sys/dev/cxgb/common/cxgb_aq100x.c.  It appears that
the intended return value is err, not v.
>How-To-Repeat:
I don't know of any problems that develop because of this problem, though
it seems that it's possible for it to fail.
>Fix:
It looks like the value that should be returned is err, not (v).


Index: sys/dev/cxgb/common/cxgb_aq100x.c
===================================================================
--- sys/dev/cxgb/common/cxgb_aq100x.c   (rvision 228798)
+++ sys/dev/cxgb/common/cxgb_aq100x.c   (copie de travail)
@@ -232,7 +232,7 @@
        err = t3_mdio_change_bits(phy, MDIO_DEV_PMA_PMD, MII_BMCR, BMCR_PDOWN,
            off ? BMCR_PDOWN : 0);
        if (err || off)
-               return (v);
+               return (err);
 
        msleep(300);
        do {


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Dec 22 23:55:33 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163545 
State-Changed-From-To: open->patched 
State-Changed-By: np 
State-Changed-When: Fri Dec 23 01:48:37 UTC 2011 
State-Changed-Why:  
Fixed in r228825. 


Responsible-Changed-From-To: freebsd-net->np 
Responsible-Changed-By: np 
Responsible-Changed-When: Fri Dec 23 01:48:37 UTC 2011 
Responsible-Changed-Why:  
Fixed in r228825. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163545 
State-Changed-From-To: patched->closed 
State-Changed-By: np 
State-Changed-When: Thu Oct 25 19:10:49 UTC 2012 
State-Changed-Why:  
Fixed in r228825. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163545 
>Unformatted:
