From nobody@FreeBSD.org  Mon Nov 21 20:39:20 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4CA9F106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Nov 2011 20:39:20 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 3C6B48FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Nov 2011 20:39:20 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pALKdJlc055432
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Nov 2011 20:39:19 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pALKdJLC055431;
	Mon, 21 Nov 2011 20:39:19 GMT
	(envelope-from nobody)
Message-Id: <201111212039.pALKdJLC055431@red.freebsd.org>
Date: Mon, 21 Nov 2011 20:39:19 GMT
From: Stephen Evans <stephen.evans@recombinant.myzen.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: r214955 (nanobsd) broke build with whitespace in KERNCONFDIR
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         162736
>Category:       kern
>Synopsis:       r214955 (nanobsd) broke build with whitespace in KERNCONFDIR
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    imp
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 21 20:40:11 UTC 2011
>Closed-Date:    Fri Mar 14 14:29:16 MDT 2014
>Last-Modified:  Sun May 11 20:50:01 UTC 2014
>Originator:     Stephen Evans
>Release:        i386 RELENG_8
>Organization:
>Environment:
FreeBSD freebsd.localdomain 8.2-STABLE FreeBSD 8.2-STABLE #2: Mon Nov 21 11:18:37 GMT 2011     root@freebsd.localdomain:/usr/obj/usr/src/sys/P8P67LE  i386
>Description:
r214955 broke my nanobsd build. Solved by a simple rename of the project directory to remove whitespace from the directory path.

Original path of nanobsd configuration file and kernel configuration file (problematic, nanobsd.sh stops in build_kernel):

/home/stephen/ALIX\ Project/

Fixed (now builds):

/home/stephen/ALIX_Project/

r214955 is a definite improvement.



>How-To-Repeat:
Put whitespace in the path of the nanobsd configuration file used with the -c option.

e.g.

cd /home/stephen/ALIX\ Project
/bin/sh nanobsd.sh -c mynano.conf

(nanobsd.sh stops in build_kernel)
>Fix:


>Release-Note:
>Audit-Trail:

From: Garrett Cooper <yanegomi@gmail.com>
To: bug-followup@FreeBSD.org, stephen.evans@recombinant.myzen.co.uk
Cc:  
Subject: Re: kern/162736: r214955 (nanobsd) broke build with whitespace in
 KERNCONFDIR
Date: Mon, 3 Dec 2012 01:36:19 -0800 (PST)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
 
 --967339439-496397275-1354527384=:40482
 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
 
  	This should fix your issue; it won't handle KERNCONFDIRs with 
 spaces in them, but doing that shouldn't be too hard in a future patch.
 HTH,
 -Garrett
 
 PS I've committed this to my github repository (http://github.com/yaneurabeya/freebsd/).
 --967339439-496397275-1354527384=:40482
 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=nanobsd-permit-spaces-in-NANO_KERNEL.patch
 Content-Transfer-Encoding: BASE64
 Content-ID: <alpine.BSF.2.00.1212030136190.40482@toaster.local>
 Content-Description: 
 Content-Disposition: attachment; filename=nanobsd-permit-spaces-in-NANO_KERNEL.patch
 
 ZGlmZiAtLWdpdCBhL3Rvb2xzL3Rvb2xzL25hbm9ic2QvbmFub2JzZC5zaCBi
 L3Rvb2xzL3Rvb2xzL25hbm9ic2QvbmFub2JzZC5zaA0KaW5kZXggNmJkNWMz
 YS4uMTk1YTJmNCAxMDA2NDQNCi0tLSBhL3Rvb2xzL3Rvb2xzL25hbm9ic2Qv
 bmFub2JzZC5zaA0KKysrIGIvdG9vbHMvdG9vbHMvbmFub2JzZC9uYW5vYnNk
 LnNoDQpAQCAtMjI0LDExICsyMjQsMTEgQEAgYnVpbGRfa2VybmVsICggKSAo
 DQogCXBwcmludCAzICJsb2c6ICR7TUFLRU9CSkRJUlBSRUZJWH0vXy5iayIN
 CiANCiAJKA0KLQlpZiBbIC1mICR7TkFOT19LRVJORUx9IF0gOyB0aGVuDQot
 CQlrZXJuY29uZmRpcj0kKHJlYWxwYXRoICQoZGlybmFtZSAke05BTk9fS0VS
 TkVMfSkpDQotCQlrZXJuY29uZj0kKGJhc2VuYW1lICR7TkFOT19LRVJORUx9
 KQ0KKwlpZiBbIC1mICIke05BTk9fS0VSTkVMfSIgXSA7IHRoZW4NCisJCWtl
 cm5jb25mZGlyPSQocmVhbHBhdGggIiQoZGlybmFtZSAiJHtOQU5PX0tFUk5F
 TH0iKSIpDQorCQlrZXJuY29uZj0kKGJhc2VuYW1lICIke05BTk9fS0VSTkVM
 fSIpDQogCWVsc2UNCi0JCWtlcm5jb25mPSR7TkFOT19LRVJORUx9DQorCQlr
 ZXJuY29uZj0iJHtOQU5PX0tFUk5FTH0iDQogCWZpDQogDQogCWNkICR7TkFO
 T19TUkN9Ow0KQEAgLTI0NCw3ICsyNDQsNyBAQCBidWlsZF9rZXJuZWwgKCAp
 ICgNCiAJCSR7TkFOT19QTUFLRX0gXA0KIAkJYnVpbGRrZXJuZWwgXA0KIAkJ
 JHtrZXJuY29uZmRpcjorIktFUk5DT05GRElSPSJ9JHtrZXJuY29uZmRpcn0g
 XA0KLQkJS0VSTkNPTkY9JHtrZXJuY29uZn0gXA0KKwkJIktFUk5DT05GPSR7
 a2VybmNvbmZ9IiBcDQogCQlNT0RVTEVTX09WRVJSSURFPSIke05BTk9fTU9E
 VUxFU30iIFwNCiAJCVNSQ0NPTkY9JHtTUkNDT05GfSBcDQogCQlfX01BS0Vf
 Q09ORj0ke05BTk9fTUFLRV9DT05GX0JVSUxEfSBcDQpAQCAtMzE5LDkgKzMx
 OSw5IEBAIGluc3RhbGxfa2VybmVsICggKSAoDQogCXBwcmludCAzICJsb2c6
 ICR7TkFOT19PQkp9L18uaWsiDQogDQogCSgNCi0JaWYgWyAtZiAke05BTk9f
 S0VSTkVMfSBdIDsgdGhlbg0KLQkJa2VybmNvbmZkaXI9JChyZWFscGF0aCAk
 KGRpcm5hbWUgJHtOQU5PX0tFUk5FTH0pKQ0KLQkJa2VybmNvbmY9JChiYXNl
 bmFtZSAke05BTk9fS0VSTkVMfSkNCisJaWYgWyAtZiAiJHtOQU5PX0tFUk5F
 TH0iIF0gOyB0aGVuDQorCQlrZXJuY29uZmRpcj0kKHJlYWxwYXRoICQoZGly
 bmFtZSAiJHtOQU5PX0tFUk5FTH0iKSkNCisJCWtlcm5jb25mPSQoYmFzZW5h
 bWUgIiR7TkFOT19LRVJORUx9IikNCiAJZWxzZQ0KIAkJa2VybmNvbmY9JHtO
 QU5PX0tFUk5FTH0NCiAJZmkNCkBAIC0zMzUsNyArMzM1LDcgQEAgaW5zdGFs
 bF9rZXJuZWwgKCApICgNCiAJCUlOU1RBTExfTk9ERUJVRz0gXA0KIAkJREVT
 VERJUj0ke05BTk9fV09STERESVJ9IFwNCiAJCSR7a2VybmNvbmZkaXI6KyJL
 RVJOQ09ORkRJUj0ifSR7a2VybmNvbmZkaXJ9IFwNCi0JCUtFUk5DT05GPSR7
 a2VybmNvbmZ9IFwNCisJCSJLRVJOQ09ORj0ke2tlcm5jb25mfSIgXA0KIAkJ
 TU9EVUxFU19PVkVSUklERT0iJHtOQU5PX01PRFVMRVN9Ig0KIAkJU1JDQ09O
 Rj0ke1NSQ0NPTkZ9IFwNCiAJCV9fTUFLRV9DT05GPSR7TkFOT19NQUtFX0NP
 TkZfSU5TVEFMTH0gXA0K
 
 --967339439-496397275-1354527384=:40482--
Responsible-Changed-From-To: freebsd-bugs->imp 
Responsible-Changed-By: imp 
Responsible-Changed-When: Thu Mar 13 22:43:03 MDT 2014 
Responsible-Changed-Why:  
me 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162736 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/162736: commit references a PR
Date: Fri, 14 Mar 2014 19:45:34 +0000 (UTC)

 Author: imp
 Date: Fri Mar 14 19:45:26 2014
 New Revision: 263184
 URL: http://svnweb.freebsd.org/changeset/base/263184
 
 Log:
   Fix build with spaces in names.
   
   PR: 162736
 
 Modified:
   head/tools/tools/nanobsd/nanobsd.sh
 
 Modified: head/tools/tools/nanobsd/nanobsd.sh
 ==============================================================================
 --- head/tools/tools/nanobsd/nanobsd.sh	Fri Mar 14 19:37:37 2014	(r263183)
 +++ head/tools/tools/nanobsd/nanobsd.sh	Fri Mar 14 19:45:26 2014	(r263184)
 @@ -197,12 +197,14 @@ build_world ( ) (
  )
  
  build_kernel ( ) (
 +	local extra
 +
  	pprint 2 "build kernel ($NANO_KERNEL)"
  	pprint 3 "log: ${MAKEOBJDIRPREFIX}/_.bk"
  
  	(
  	if [ -f ${NANO_KERNEL} ] ; then
 -		kernconfdir=$(realpath $(dirname ${NANO_KERNEL}))
 +		extra="KERNCONFDIR=$(realpath $(dirname ${NANO_KERNEL}))"
  		kernconf=$(basename ${NANO_KERNEL})
  	else
  		kernconf=${NANO_KERNEL}
 @@ -216,8 +218,7 @@ build_kernel ( ) (
  	# Note: We intentionally build all modules, not only the ones in
  	# NANO_MODULES so the built world can be reused by multiple images.
  	env TARGET_ARCH=${NANO_ARCH} ${NANO_PMAKE} buildkernel \
 -		__MAKE_CONF=${NANO_MAKE_CONF_BUILD} \
 -		${kernconfdir:+"KERNCONFDIR="}${kernconfdir} \
 +		${extra} __MAKE_CONF=${NANO_MAKE_CONF_BUILD} \
  		KERNCONF=${kernconf}
  	) > ${MAKEOBJDIRPREFIX}/_.bk 2>&1
  )
 @@ -277,12 +278,14 @@ install_etc ( ) (
  )
  
  install_kernel ( ) (
 +	local extra
 +
  	pprint 2 "install kernel ($NANO_KERNEL)"
  	pprint 3 "log: ${NANO_OBJ}/_.ik"
  
  	(
  	if [ -f ${NANO_KERNEL} ] ; then
 -		kernconfdir=$(realpath $(dirname ${NANO_KERNEL}))
 +		extra="KERNCONFDIR=$(realpath $(dirname ${NANO_KERNEL}))"
  		kernconf=$(basename ${NANO_KERNEL})
  	else
  		kernconf=${NANO_KERNEL}
 @@ -291,8 +294,7 @@ install_kernel ( ) (
  	cd ${NANO_SRC}
  	env TARGET_ARCH=${NANO_ARCH} ${NANO_MAKE} installkernel \
  		DESTDIR=${NANO_WORLDDIR} \
 -		__MAKE_CONF=${NANO_MAKE_CONF_INSTALL} \
 -		${kernconfdir:+"KERNCONFDIR="}${kernconfdir} \
 +		${extra} __MAKE_CONF=${NANO_MAKE_CONF_INSTALL} \
  		KERNCONF=${kernconf} \
  		MODULES_OVERRIDE="${NANO_MODULES}"
  	) > ${NANO_OBJ}/_.ik 2>&1
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: imp 
State-Changed-When: Fri Mar 14 14:29:04 MDT 2014 
State-Changed-Why:  
Fixed. Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162736 

From: Thomas Quinot <thomas@FreeBSD.ORG>
To: Warner Losh <imp@FreeBSD.org>, bug-followup@freebsd.org
Cc:  
Subject: Re: kern/162736 svn commit: r263184 - head/tools/tools/nanobsd
Date: Fri, 2 May 2014 13:18:10 +0200

 --1yeeQ81UyVL57Vl7
 Content-Type: text/plain; charset=iso-8859-1
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 * Warner Losh, 2014-03-14 :
 
 > Author: imp
 > Date: Fri Mar 14 19:45:26 2014
 > New Revision: 263184
 > URL: http://svnweb.freebsd.org/changeset/base/263184
 >=20
 > Log:
 >   Fix build with spaces in names.
 >  =20
 >   PR: 162736
 
 Hi Warner,
 
 I am puzzled by this change.
 
 > -		kernconfdir=3D$(realpath $(dirname ${NANO_KERNEL}))
 > +		extra=3D"KERNCONFDIR=3D$(realpath $(dirname ${NANO_KERNEL}))"
 >  		kernconf=3D$(basename ${NANO_KERNEL})
 >  	else
 >  		kernconf=3D${NANO_KERNEL}
 > @@ -216,8 +218,7 @@ build_kernel ( ) (
 >  	# Note: We intentionally build all modules, not only the ones in
 >  	# NANO_MODULES so the built world can be reused by multiple images.
 >  	env TARGET_ARCH=3D${NANO_ARCH} ${NANO_PMAKE} buildkernel \
 > -		__MAKE_CONF=3D${NANO_MAKE_CONF_BUILD} \
 > -		${kernconfdir:+"KERNCONFDIR=3D"}${kernconfdir} \
 > +		${extra} __MAKE_CONF=3D${NANO_MAKE_CONF_BUILD} \
 >  		KERNCONF=3D${kernconf}
 
 This seems to be a no-op as far as the described issue is concerned:
 extra will still contain a space, and will be split incorrectly when
 expanded by sh.
 
 Furhtermore, I tried building with a different fix (using eval in the
 command above, and inserting required quotes around the path name),
 and the build fails soon thereafter because KERCONFDIR also needs to be
 protected by quotes in Makefile.inc1:
 
 Index: Makefile.inc1
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 --- Makefile.inc1	(r=E9vision 265192)
 +++ Makefile.inc1	(copie de travail)
 @@ -1001,7 +1001,7 @@
  	cd ${KRNLCONFDIR}; \
  		PATH=3D${TMPPATH} \
  		    config ${CONFIGARGS} -d ${KRNLOBJDIR}/${_kernel} \
 -			-I ${KERNCONFDIR} ${KERNCONFDIR}/${_kernel}
 +			-I "${KERNCONFDIR}" "${KERNCONFDIR}"/${_kernel}
  .endif
  .if !defined(NO_CLEAN) && !defined(NO_KERNELCLEAN)
  	@echo
 
 I haven't made a complete build with this fix, so cannot say for sure
 whether there might be other places that need to be fixed as well.
 
 Is there something I'm missing? Were you able to make a full NanoBSD
 build from a directory with a space?
 
 Thomas.
 
 
 --1yeeQ81UyVL57Vl7
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 
 iD8DBQFTY37xAE1UuDk9JGkRAtRaAJ4jT9Jv27gNs6VZyRVKwmX3XdC0FwCghFNQ
 MUqfJoACWkuWGsEM2x/ZMC0=
 =Jx4m
 -----END PGP SIGNATURE-----
 
 --1yeeQ81UyVL57Vl7--

From: Warner Losh <imp@bsdimp.com>
To: Thomas Quinot <thomas@FreeBSD.org>
Cc: Warner Losh <imp@FreeBSD.org>,
 bug-followup@freebsd.org
Subject: Re: kern/162736 svn commit: r263184 - head/tools/tools/nanobsd
Date: Fri, 2 May 2014 08:48:44 -0600

 --Apple-Mail=_27BBBC94-36A7-4183-BD92-B6F30B903253
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=iso-8859-1
 
 I think the extra stuff might, indeed, be bogus...
 
 On May 2, 2014, at 5:18 AM, Thomas Quinot <thomas@FreeBSD.org> wrote:
 
 > * Warner Losh, 2014-03-14 :
 >=20
 >> Author: imp
 >> Date: Fri Mar 14 19:45:26 2014
 >> New Revision: 263184
 >> URL: http://svnweb.freebsd.org/changeset/base/263184
 >>=20
 >> Log:
 >>  Fix build with spaces in names.
 >>=20
 >>  PR: 162736
 >=20
 > Hi Warner,
 >=20
 > I am puzzled by this change.
 >=20
 >> -		kernconfdir=3D$(realpath $(dirname ${NANO_KERNEL}))
 >> +		extra=3D"KERNCONFDIR=3D$(realpath $(dirname =
 ${NANO_KERNEL}))"
 >> 		kernconf=3D$(basename ${NANO_KERNEL})
 >> 	else
 >> 		kernconf=3D${NANO_KERNEL}
 >> @@ -216,8 +218,7 @@ build_kernel ( ) (
 >> 	# Note: We intentionally build all modules, not only the ones in
 >> 	# NANO_MODULES so the built world can be reused by multiple =
 images.
 >> 	env TARGET_ARCH=3D${NANO_ARCH} ${NANO_PMAKE} buildkernel \
 >> -		__MAKE_CONF=3D${NANO_MAKE_CONF_BUILD} \
 >> -		${kernconfdir:+"KERNCONFDIR=3D"}${kernconfdir} \
 >> +		${extra} __MAKE_CONF=3D${NANO_MAKE_CONF_BUILD} \
 >> 		KERNCONF=3D${kernconf}
 >=20
 > This seems to be a no-op as far as the described issue is concerned:
 > extra will still contain a space, and will be split incorrectly when
 > expanded by sh.
 >=20
 > Furhtermore, I tried building with a different fix (using eval in the
 > command above, and inserting required quotes around the path name),
 > and the build fails soon thereafter because KERCONFDIR also needs to =
 be
 > protected by quotes in Makefile.inc1:
 >=20
 > Index: Makefile.inc1
 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > --- Makefile.inc1	(r=E9vision 265192)
 > +++ Makefile.inc1	(copie de travail)
 > @@ -1001,7 +1001,7 @@
 > 	cd ${KRNLCONFDIR}; \
 > 		PATH=3D${TMPPATH} \
 > 		    config ${CONFIGARGS} -d ${KRNLOBJDIR}/${_kernel} \
 > -			-I ${KERNCONFDIR} ${KERNCONFDIR}/${_kernel}
 > +			-I "${KERNCONFDIR}" "${KERNCONFDIR}"/${_kernel}
 > .endif
 > .if !defined(NO_CLEAN) && !defined(NO_KERNELCLEAN)
 > 	@echo
 >=20
 > I haven't made a complete build with this fix, so cannot say for sure
 > whether there might be other places that need to be fixed as well.
 >=20
 > Is there something I'm missing? Were you able to make a full NanoBSD
 > build from a directory with a space?
 >=20
 > Thomas.
 >=20
 
 
 --Apple-Mail=_27BBBC94-36A7-4183-BD92-B6F30B903253
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP using GPGMail
 
 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org
 
 iQIcBAEBCgAGBQJTY7BMAAoJEGwc0Sh9sBEA0u8QAOmD5qLvshkvTEpybi5ZJOiM
 Zm2+x43CNxpD8jJfTz73K3NPV0bCvcatq4DLdJ+PPRcRfqXkL/S60bjdWFOzDOko
 FWIti2piqXsrWSreSCz3/044wlSK4VzW4ScAeDnWTRCgx1sE551krgr7NXQGiDDB
 NRjgghlXU+yVV774m11CDCi6ib4mLQhTIRUNwah5gI0X7iW3j4a+PCs1qHrOIrH+
 Fej7PruqMceDJEsiPOOHpP5pTQevD2gB2BrokrQ0Y8qmNi0g+oLIy+vDFzPJ8DuU
 dICrmwtF2KIvp/kIxBDPfG94fpLUXue0bP8daKDLKWEmjfPZHLVMlI/B8HF3Klue
 2vzOOHcg0AAbG3bi++L/3J8wsVtdFpvuEUre89MVCweDoRdWQX9WuAt55zWwACov
 jorjmvT5PtSIt/aKfKbwDLb9rhIr4QyDNEDe7WO6VBFZDflq8nstaVF5RrXvmbg0
 BRMmP6O74Abf0bRpNIHQTSNExdyrUU8tQInUFY7ynKEIenQEZ3+Mjf2k6hvJDv50
 awj5UCGhelngagSddAW8mVWvZM9Eyju7GWArAJHtyOtMCKAkBH6nimorPxvLeRe3
 uG09PTzR/SGf9xjPB92ci+54nyBWREWezcqx1g5K9exDMpvspOs3+CnNIezhNLvP
 YtmJG1RXgO4yK3p5W/xx
 =Bdub
 -----END PGP SIGNATURE-----
 
 --Apple-Mail=_27BBBC94-36A7-4183-BD92-B6F30B903253--

From: Thomas Quinot <thomas@FreeBSD.ORG>
To: Warner Losh <imp@bsdimp.com>
Cc: Warner Losh <imp@FreeBSD.org>, bug-followup@freebsd.org
Subject: Re: kern/162736 svn commit: r263184 - head/tools/tools/nanobsd
Date: Fri, 2 May 2014 16:55:16 +0200

 --AhhlLboLdkugWU4S
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 * Warner Losh, 2014-05-02 :
 
 > I think the extra stuff might, indeed, be bogus...
 
 OK, thanks for the confirmation, I'll continue experimenting then, and
 commit a cumulative fix if I can get a succseful build.
 
 Thomas.
 
 
 --AhhlLboLdkugWU4S
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (FreeBSD)
 
 iD8DBQFTY7HUAE1UuDk9JGkRAlpkAJ0fVDxz8zWbwuDEkiwtv1PXgyLBSQCdGxJn
 YFPHoeD9AgMfCz32voSd4gM=
 =eOKj
 -----END PGP SIGNATURE-----
 
 --AhhlLboLdkugWU4S--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/162736: commit references a PR
Date: Sat,  3 May 2014 09:24:24 +0000 (UTC)

 Author: thomas
 Date: Sat May  3 09:24:20 2014
 New Revision: 265260
 URL: http://svnweb.freebsd.org/changeset/base/265260
 
 Log:
   Add appropriate quoting to allow building with a KERNCONFDIR containing
   spaces.
   
   PR:		kern/162736
   MFC after:	1 week
 
 Modified:
   head/Makefile.inc1
   head/tools/tools/nanobsd/nanobsd.sh
 
 Modified: head/Makefile.inc1
 ==============================================================================
 --- head/Makefile.inc1	Sat May  3 09:18:59 2014	(r265259)
 +++ head/Makefile.inc1	Sat May  3 09:24:20 2014	(r265260)
 @@ -1001,7 +1001,7 @@ buildkernel:
  	cd ${KRNLCONFDIR}; \
  		PATH=${TMPPATH} \
  		    config ${CONFIGARGS} -d ${KRNLOBJDIR}/${_kernel} \
 -			-I ${KERNCONFDIR} ${KERNCONFDIR}/${_kernel}
 +			-I '${KERNCONFDIR}' '${KERNCONFDIR}/${_kernel}'
  .endif
  .if !defined(NO_CLEAN) && !defined(NO_KERNELCLEAN)
  	@echo
 @@ -1816,7 +1816,7 @@ DTBOUTPUTPATH= ${KRNLOBJDIR}/${KERNCONF}
  .if !defined(FDT_DTS_FILE) || empty(FDT_DTS_FILE)
  .if exists(${KERNCONFDIR}/${KERNCONF})
  FDT_DTS_FILE!= awk 'BEGIN {FS="="} /^makeoptions[[:space:]]+FDT_DTS_FILE/ {print $$2}' \
 -	${KERNCONFDIR}/${KERNCONF} ; echo
 +	'${KERNCONFDIR}/${KERNCONF}' ; echo
  .endif
  .endif
  
 
 Modified: head/tools/tools/nanobsd/nanobsd.sh
 ==============================================================================
 --- head/tools/tools/nanobsd/nanobsd.sh	Sat May  3 09:18:59 2014	(r265259)
 +++ head/tools/tools/nanobsd/nanobsd.sh	Sat May  3 09:24:20 2014	(r265260)
 @@ -233,7 +233,7 @@ build_kernel ( ) (
  
  	(
  	if [ -f ${NANO_KERNEL} ] ; then
 -		extra="KERNCONFDIR=$(realpath $(dirname ${NANO_KERNEL}))"
 +		kernconfdir_arg="KERNCONFDIR='$(realpath $(dirname ${NANO_KERNEL}))'"
  		kernconf=$(basename ${NANO_KERNEL})
  	else
  		kernconf=${NANO_KERNEL}
 @@ -245,10 +245,10 @@ build_kernel ( ) (
  	unset TARGET_CPUTYPE
  	# Note: We intentionally build all modules, not only the ones in
  	# NANO_MODULES so the built world can be reused by multiple images.
 -	env TARGET_ARCH=${NANO_ARCH} ${NANO_PMAKE} buildkernel \
 -		SRCCONF=${SRCCONF} \
 -		${extra} __MAKE_CONF=${NANO_MAKE_CONF_BUILD} \
 -		KERNCONF=${kernconf}
 +	eval "TARGET_ARCH=${NANO_ARCH} ${NANO_PMAKE} buildkernel \
 +		SRCCONF='${SRCCONF}' \
 +		__MAKE_CONF='${NANO_MAKE_CONF_BUILD}' \
 +		${kernconfdir_arg} KERNCONF=${kernconf}"
  	) > ${MAKEOBJDIRPREFIX}/_.bk 2>&1
  )
  
 @@ -315,19 +315,19 @@ install_kernel ( ) (
  
  	(
  	if [ -f ${NANO_KERNEL} ] ; then
 -		extra="KERNCONFDIR=$(realpath $(dirname ${NANO_KERNEL}))"
 +		kernconfdir_arg="KERNCONFDIR='$(realpath $(dirname ${NANO_KERNEL}))'"
  		kernconf=$(basename ${NANO_KERNEL})
  	else
  		kernconf=${NANO_KERNEL}
  	fi
  
  	cd ${NANO_SRC}
 -	env TARGET_ARCH=${NANO_ARCH} ${NANO_MAKE} installkernel \
 -		DESTDIR=${NANO_WORLDDIR} \
 -		SRCCONF=${SRCCONF} \
 -		${extra} __MAKE_CONF=${NANO_MAKE_CONF_INSTALL} \
 -		KERNCONF=${kernconf} \
 -		MODULES_OVERRIDE="${NANO_MODULES}"
 +	eval "TARGET_ARCH=${NANO_ARCH} ${NANO_MAKE} installkernel \
 +		DESTDIR='${NANO_WORLDDIR}' \
 +		SRCCONF='${SRCCONF}' \
 +		__MAKE_CONF='${NANO_MAKE_CONF_INSTALL}' \
 +		${kernconfdir_arg} KERNCONF=${kernconf} \
 +		MODULES_OVERRIDE='${NANO_MODULES}'"
  	) > ${NANO_OBJ}/_.ik 2>&1
  )
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/162736: commit references a PR
Date: Sun, 11 May 2014 20:45:02 +0000 (UTC)

 Author: thomas
 Date: Sun May 11 20:44:58 2014
 New Revision: 265894
 URL: http://svnweb.freebsd.org/changeset/base/265894
 
 Log:
   MFC rev. 265260:
   Add appropriate quoting to allow building with a KERNCONFDIR containing
   spaces.
   
   PR:		kern/162736
 
 Modified:
   stable/10/Makefile.inc1
   stable/10/tools/tools/nanobsd/nanobsd.sh
 
 Changes in other areas also in this revision:
 Modified:
   stable/9/Makefile.inc1   (contents, props changed)
   stable/9/tools/tools/nanobsd/nanobsd.sh
 
 Modified: stable/10/Makefile.inc1
 ==============================================================================
 --- stable/10/Makefile.inc1	Sun May 11 18:49:18 2014	(r265893)
 +++ stable/10/Makefile.inc1	Sun May 11 20:44:58 2014	(r265894)
 @@ -1002,7 +1002,7 @@ buildkernel:
  	cd ${KRNLCONFDIR}; \
  		PATH=${TMPPATH} \
  		    config ${CONFIGARGS} -d ${KRNLOBJDIR}/${_kernel} \
 -			-I ${KERNCONFDIR} ${KERNCONFDIR}/${_kernel}
 +			-I '${KERNCONFDIR}' '${KERNCONFDIR}/${_kernel}'
  .endif
  .if !defined(NO_CLEAN) && !defined(NO_KERNELCLEAN)
  	@echo
 @@ -1831,7 +1831,7 @@ DTBOUTPUTPATH= ${KRNLOBJDIR}/${KERNCONF}
  .if !defined(FDT_DTS_FILE) || empty(FDT_DTS_FILE)
  .if exists(${KERNCONFDIR}/${KERNCONF})
  FDT_DTS_FILE!= awk 'BEGIN {FS="="} /^makeoptions[[:space:]]+FDT_DTS_FILE/ {print $$2}' \
 -	${KERNCONFDIR}/${KERNCONF} ; echo
 +	'${KERNCONFDIR}/${KERNCONF}' ; echo
  .endif
  .endif
  
 
 Modified: stable/10/tools/tools/nanobsd/nanobsd.sh
 ==============================================================================
 --- stable/10/tools/tools/nanobsd/nanobsd.sh	Sun May 11 18:49:18 2014	(r265893)
 +++ stable/10/tools/tools/nanobsd/nanobsd.sh	Sun May 11 20:44:58 2014	(r265894)
 @@ -233,7 +233,7 @@ build_kernel ( ) (
  
  	(
  	if [ -f ${NANO_KERNEL} ] ; then
 -		extra="KERNCONFDIR=$(realpath $(dirname ${NANO_KERNEL}))"
 +		kernconfdir_arg="KERNCONFDIR='$(realpath $(dirname ${NANO_KERNEL}))'"
  		kernconf=$(basename ${NANO_KERNEL})
  	else
  		kernconf=${NANO_KERNEL}
 @@ -245,10 +245,10 @@ build_kernel ( ) (
  	unset TARGET_CPUTYPE
  	# Note: We intentionally build all modules, not only the ones in
  	# NANO_MODULES so the built world can be reused by multiple images.
 -	env TARGET_ARCH=${NANO_ARCH} ${NANO_PMAKE} buildkernel \
 -		SRCCONF=${SRCCONF} \
 -		${extra} __MAKE_CONF=${NANO_MAKE_CONF_BUILD} \
 -		KERNCONF=${kernconf}
 +	eval "TARGET_ARCH=${NANO_ARCH} ${NANO_PMAKE} buildkernel \
 +		SRCCONF='${SRCCONF}' \
 +		__MAKE_CONF='${NANO_MAKE_CONF_BUILD}' \
 +		${kernconfdir_arg} KERNCONF=${kernconf}"
  	) > ${MAKEOBJDIRPREFIX}/_.bk 2>&1
  )
  
 @@ -315,19 +315,19 @@ install_kernel ( ) (
  
  	(
  	if [ -f ${NANO_KERNEL} ] ; then
 -		extra="KERNCONFDIR=$(realpath $(dirname ${NANO_KERNEL}))"
 +		kernconfdir_arg="KERNCONFDIR='$(realpath $(dirname ${NANO_KERNEL}))'"
  		kernconf=$(basename ${NANO_KERNEL})
  	else
  		kernconf=${NANO_KERNEL}
  	fi
  
  	cd ${NANO_SRC}
 -	env TARGET_ARCH=${NANO_ARCH} ${NANO_MAKE} installkernel \
 -		DESTDIR=${NANO_WORLDDIR} \
 -		SRCCONF=${SRCCONF} \
 -		${extra} __MAKE_CONF=${NANO_MAKE_CONF_INSTALL} \
 -		KERNCONF=${kernconf} \
 -		MODULES_OVERRIDE="${NANO_MODULES}"
 +	eval "TARGET_ARCH=${NANO_ARCH} ${NANO_MAKE} installkernel \
 +		DESTDIR='${NANO_WORLDDIR}' \
 +		SRCCONF='${SRCCONF}' \
 +		__MAKE_CONF='${NANO_MAKE_CONF_INSTALL}' \
 +		${kernconfdir_arg} KERNCONF=${kernconf} \
 +		MODULES_OVERRIDE='${NANO_MODULES}'"
  	) > ${NANO_OBJ}/_.ik 2>&1
  )
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/162736: commit references a PR
Date: Sun, 11 May 2014 20:45:06 +0000 (UTC)

 Author: thomas
 Date: Sun May 11 20:44:58 2014
 New Revision: 265894
 URL: http://svnweb.freebsd.org/changeset/base/265894
 
 Log:
   MFC rev. 265260:
   Add appropriate quoting to allow building with a KERNCONFDIR containing
   spaces.
   
   PR:		kern/162736
 
 Modified:
   stable/9/Makefile.inc1   (contents, props changed)
   stable/9/tools/tools/nanobsd/nanobsd.sh
 
 Changes in other areas also in this revision:
 Modified:
   stable/10/Makefile.inc1
   stable/10/tools/tools/nanobsd/nanobsd.sh
 
 Modified: stable/9/Makefile.inc1
 ==============================================================================
 --- stable/9/Makefile.inc1	Sun May 11 18:49:18 2014	(r265893)
 +++ stable/9/Makefile.inc1	Sun May 11 20:44:58 2014	(r265894)
 @@ -926,7 +926,7 @@ buildkernel:
  	cd ${KRNLCONFDIR}; \
  		PATH=${TMPPATH} \
  		    config ${CONFIGARGS} -d ${KRNLOBJDIR}/${_kernel} \
 -			-I ${KERNCONFDIR} ${KERNCONFDIR}/${_kernel}
 +			-I '${KERNCONFDIR}' '${KERNCONFDIR}/${_kernel}'
  .endif
  .if !defined(NO_CLEAN) && !defined(NO_KERNELCLEAN)
  	@echo
 @@ -1657,7 +1657,7 @@ DTBOUTPUTPATH= ${KRNLOBJDIR}/${KERNCONF}
  .if !defined(FDT_DTS_FILE) || empty(FDT_DTS_FILE)
  .if exists(${KERNCONFDIR}/${KERNCONF})
  FDT_DTS_FILE!= awk 'BEGIN {FS="="} /^makeoptions[[:space:]]+FDT_DTS_FILE/ {print $$2}' \
 -	${KERNCONFDIR}/${KERNCONF} ; echo
 +	'${KERNCONFDIR}/${KERNCONF}' ; echo
  .endif
  .endif
  
 
 Modified: stable/9/tools/tools/nanobsd/nanobsd.sh
 ==============================================================================
 --- stable/9/tools/tools/nanobsd/nanobsd.sh	Sun May 11 18:49:18 2014	(r265893)
 +++ stable/9/tools/tools/nanobsd/nanobsd.sh	Sun May 11 20:44:58 2014	(r265894)
 @@ -201,7 +201,7 @@ build_kernel ( ) (
  
  	(
  	if [ -f ${NANO_KERNEL} ] ; then
 -		kernconfdir=$(realpath $(dirname ${NANO_KERNEL}))
 +		kernconfdir_arg="KERNCONFDIR='$(realpath $(dirname ${NANO_KERNEL}))'"
  		kernconf=$(basename ${NANO_KERNEL})
  	else
  		kernconf=${NANO_KERNEL}
 @@ -214,10 +214,9 @@ build_kernel ( ) (
  	unset TARGET_BIG_ENDIAN
  	# Note: We intentionally build all modules, not only the ones in
  	# NANO_MODULES so the built world can be reused by multiple images.
 -	env TARGET_ARCH=${NANO_ARCH} ${NANO_PMAKE} buildkernel \
 -		__MAKE_CONF=${NANO_MAKE_CONF_BUILD} \
 -		${kernconfdir:+"KERNCONFDIR="}${kernconfdir} \
 -		KERNCONF=${kernconf}
 +	eval "TARGET_ARCH=${NANO_ARCH} ${NANO_PMAKE} buildkernel \
 +		__MAKE_CONF='${NANO_MAKE_CONF_BUILD}' \
 +		${kernconfdir_arg} KERNCONF=${kernconf}"
  	) > ${MAKEOBJDIRPREFIX}/_.bk 2>&1
  )
  
 @@ -281,19 +280,18 @@ install_kernel ( ) (
  
  	(
  	if [ -f ${NANO_KERNEL} ] ; then
 -		kernconfdir=$(realpath $(dirname ${NANO_KERNEL}))
 +		kernconfdir_arg="KERNCONFDIR='$(realpath $(dirname ${NANO_KERNEL}))'"
  		kernconf=$(basename ${NANO_KERNEL})
  	else
  		kernconf=${NANO_KERNEL}
  	fi
  
  	cd ${NANO_SRC}
 -	env TARGET_ARCH=${NANO_ARCH} ${NANO_PMAKE} installkernel \
 -		DESTDIR=${NANO_WORLDDIR} \
 -		__MAKE_CONF=${NANO_MAKE_CONF_INSTALL} \
 -		${kernconfdir:+"KERNCONFDIR="}${kernconfdir} \
 -		KERNCONF=${kernconf} \
 -		MODULES_OVERRIDE="${NANO_MODULES}"
 +	eval "TARGET_ARCH=${NANO_ARCH} ${NANO_MAKE} installkernel \
 +		DESTDIR='${NANO_WORLDDIR}' \
 +		__MAKE_CONF='${NANO_MAKE_CONF_INSTALL}' \
 +		${kernconfdir_arg} KERNCONF=${kernconf} \
 +		MODULES_OVERRIDE='${NANO_MODULES}'"
  	) > ${NANO_OBJ}/_.ik 2>&1
  )
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
