From nobody@FreeBSD.org  Fri Nov 11 20:33:32 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BEBCD106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 Nov 2011 20:33:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id AF53C8FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 Nov 2011 20:33:32 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pABKXWOb087079
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 Nov 2011 20:33:32 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pABKXVQW087063;
	Fri, 11 Nov 2011 20:33:31 GMT
	(envelope-from nobody)
Message-Id: <201111112033.pABKXVQW087063@red.freebsd.org>
Date: Fri, 11 Nov 2011 20:33:31 GMT
From: Alexey Slynko <slynko@tronet.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: EliteBook 8540p panic on acpi_hp module loading
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         162491
>Category:       kern
>Synopsis:       [acpi_hp] [panic] EliteBook 8540p panic on acpi_hp module loading
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    jh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 11 20:40:06 UTC 2011
>Closed-Date:    Mon Jan 09 16:26:33 UTC 2012
>Last-Modified:  Mon Jan 09 16:26:33 UTC 2012
>Originator:     Alexey Slynko
>Release:        9.0-RC1
>Organization:
Brandproduction Ltd
>Environment:
FreeBSD elizabet.brandproduction.ru 9.0-RC2 FreeBSD 9.0-RC2 #16: Fri Nov 11 23:27:09 MSK 2011     slynko@elizabet.brandproduction.ru:/usr/obj/usr/src/sys/ELIZABET  amd64

>Description:
My EliteBook 8540p panic on boot after upgrade to 9.0-RC1. I've tried to unload all kernel modules and load it manually. It was crashed on acpi_hp loading:

acpi_wmi0: <ACPI-WMI mapping> on acpi0
acpi_wmi1: <ACPI-WMI mapping> on acpi0
panic: make_dev_credv: bad si_name (error=17, si_name=wmistat)
cpuid = 3
KDB: stack backtrace:
#0 0xffffffff80464c3e at kdb_backtrace+0x5e
#1 0xffffffff8042db77 at panic+0x187
#2 0xffffffff803e50bc at make_dev_credv+0x1dc
#3 0xffffffff803e52af at make_dev+0x6f
#4 0xffffffff822683e9 at acpi_wmi_attach+0x339
#5 0xffffffff8045e059 at device_attach+0x69
#6 0xffffffff802dd833 at acpi_driver_added+0xa3
#7 0xffffffff8045c855 at devclass_driver_added+0x75
#8 0xffffffff8045d233 at devclass_add_driver+0x103
#9 0xffffffff8041b068 at module_register_init+0xb8
#10 0xffffffff80413636 at linker_load_module+0x9b6
#11 0xffffffff804139cc at linker_load_dependencies+0x1ac
#12 0xffffffff806901e6 at link_elf_load_file+0xaf6
#13 0xffffffff80413534 at linker_load_module+0x8b4
#14 0xffffffff80413abe at kern_kldload+0xbe
#15 0xffffffff80413cd4 at sys_kldload+0x84
#16 0xffffffff8066ca0a at amd64_syscall+0x4fa
#17 0xffffffff80657617 at Xfast_syscall+0xf7

>How-To-Repeat:
kldload acpi_hp on EliteBook 8540p
>Fix:
Unknown

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-acpi 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Nov 12 00:19:53 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162491 

From: Jaakko Heinonen <jh@FreeBSD.org>
To: Alexey Slynko <slynko@tronet.ru>
Cc: bug-followup@FreeBSD.org, avg@FreeBSD.org
Subject: Re: kern/162491: EliteBook 8540p panic on acpi_hp module loading
Date: Sun, 13 Nov 2011 09:49:40 +0200

 On 2011-11-11, Alexey Slynko wrote:
 > My EliteBook 8540p panic on boot after upgrade to 9.0-RC1. I've tried
 > to unload all kernel modules and load it manually. It was crashed on
 > acpi_hp loading:
 
 > acpi_wmi0: <ACPI-WMI mapping> on acpi0
 > acpi_wmi1: <ACPI-WMI mapping> on acpi0
 > panic: make_dev_credv: bad si_name (error=17, si_name=wmistat)
 
 I don't really know much about acpi_wmi(4) but obviously it tries to
 create /dev/wmistat twice here. I am not sure if it's legitimate to have
 several wmistat device files but you could try this patch:
 
 %%%
 Index: sys/dev/acpi_support/acpi_wmi.c
 ===================================================================
 --- sys/dev/acpi_support/acpi_wmi.c	(revision 227463)
 +++ sys/dev/acpi_support/acpi_wmi.c	(working copy)
 @@ -265,7 +265,7 @@ acpi_wmi_attach(device_t dev)
  		    acpi_wmi_ec_handler);
  	} else {
  		sc->wmistat_dev_t = make_dev(&wmistat_cdevsw, 0, UID_ROOT,
 -		    GID_WHEEL, 0644, "wmistat");
 +		    GID_WHEEL, 0644, "wmistat%d", device_get_unit(dev));
  		sc->wmistat_dev_t->si_drv1 = sc;
  		sc->wmistat_open_pid = 0;
  		sc->wmistat_bufptr = -1;
 Index: share/man/man4/acpi_wmi.4
 ===================================================================
 --- share/man/man4/acpi_wmi.4	(revision 227463)
 +++ share/man/man4/acpi_wmi.4	(working copy)
 @@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd February 8, 2010
 +.Dd November 13, 2011
  .Dt ACPI_WMI 4
  .Os
  .Sh NAME
 @@ -49,16 +49,16 @@ The
  .Nm
  driver provides an interface for vendor specific WMI implementations 
  (e.g. HP and Acer laptops).
 -It creates /dev/wmistat, which can be read to get
 +It creates /dev/wmistat%d, which can be read to get
  information about GUIDs found in the system.
  .Sh FILES
 -.Bl -tag -width /dev/wmistat -compact
 -.It Pa /dev/wmistat
 +.Bl -tag -width /dev/wmistat%d -compact
 +.It Pa /dev/wmistat%d
  WMI status device.
  .El
  .Sh EXAMPLES
  .Bd -literal
 -# cat /dev/wmistat
 +# cat /dev/wmistat0
  GUID                                  INST EXPE METH STR EVENT OID
  {5FB7F034-2C63-45E9-BE91-3D44E2C707E4}   1 NO   WMAA NO  NO    AA
  {95F24279-4D7B-4334-9387-ACCDC67EF61C}   1 NO   NO   NO  0x80+ -
 %%%
 
 I have cc'd avg@. He might know something about acpi_wmi(4).
 
 -- 
 Jaakko

From: Andriy Gapon <avg@FreeBSD.org>
To: Jaakko Heinonen <jh@FreeBSD.org>
Cc: Alexey Slynko <slynko@tronet.ru>, bug-followup@FreeBSD.org
Subject: Re: kern/162491: EliteBook 8540p panic on acpi_hp module loading
Date: Sun, 13 Nov 2011 11:35:19 +0200

 on 13/11/2011 09:49 Jaakko Heinonen said the following:
 > On 2011-11-11, Alexey Slynko wrote:
 >> My EliteBook 8540p panic on boot after upgrade to 9.0-RC1. I've tried
 >> to unload all kernel modules and load it manually. It was crashed on
 >> acpi_hp loading:
 > 
 >> acpi_wmi0: <ACPI-WMI mapping> on acpi0
 >> acpi_wmi1: <ACPI-WMI mapping> on acpi0
 >> panic: make_dev_credv: bad si_name (error=17, si_name=wmistat)
 > 
 > I don't really know much about acpi_wmi(4) but obviously it tries to
 > create /dev/wmistat twice here. I am not sure if it's legitimate to have
 > several wmistat device files but you could try this patch:
 
 I think that this is the most appropriate patch, thank you!
 I don't know of any actual usage for /dev/wmistat devices in userland besides
 cat-ing them and staring in awe at a bunch of GUID strings :-)
 
 -- 
 Andriy Gapon

From: Alexey Slynko <slynko@tronet.ru>
To: jh@FreeBSD.org
Cc: bug-followup@FreeBSD.org, avg@FreeBSD.org
Subject: Re: kern/162491: EliteBook 8540p panic on acpi_hp module loading
Date: Sun, 13 Nov 2011 20:18:08 +0400 (MSK)

 From: Jaakko Heinonen <jh@FreeBSD.org>
 Subject: Re: kern/162491: EliteBook 8540p panic on acpi_hp module loading
 Date: Sun, 13 Nov 2011 09:49:40 +0200
 
 > I don't really know much about acpi_wmi(4) but obviously it tries to
 > create /dev/wmistat twice here. I am not sure if it's legitimate to have
 > several wmistat device files but you could try this patch:
 
 I have applied your patch, and acpi_wmi loaded sucessfully, but acpi_hp still doesn't work.
 
 acpi_wmi0: <ACPI-WMI mapping> on acpi0
 acpi_wmi1: <ACPI-WMI mapping> on acpi0
 acpi_wmi2: <ACPI-WMI mapping> on acpi0
 acpi_hp0: <HP ACPI-WMI Mapping> on acpi_wmi0
 acpi_hp0: WMI device does not provide the HP BIOS GUID
 device_attach: acpi_hp0 attach returned 22
 acpi_hp1: <HP ACPI-WMI Mapping> on acpi_wmi1
 acpi_hp1: WMI device does not provide the HP BIOS GUID
 device_attach: acpi_hp1 attach returned 22
 acpi_hp2: <HP ACPI-WMI Mapping> on acpi_wmi2
 acpi_hp2: WMI device does not provide the HP BIOS GUID
 device_attach: acpi_hp2 attach returned 22

From: Jaakko Heinonen <jh@FreeBSD.org>
To: Alexey Slynko <slynko@tronet.ru>
Cc: bug-followup@FreeBSD.org, avg@FreeBSD.org
Subject: Re: kern/162491: EliteBook 8540p panic on acpi_hp module loading
Date: Tue, 15 Nov 2011 19:00:36 +0200

 On 2011-11-13, Alexey Slynko wrote:
 > I have applied your patch, and acpi_wmi loaded sucessfully, but
 > acpi_hp still doesn't work.
 
 Thanks for testing. Unfortunately, I don't know if there is much more
 that I can do to help you. However following information might be useful
 for solving the problem:
 
 - Did acpi_hp(4) work with previous FreeBSD versions? If it did, what is
   the exact working version?
 - verbose dmesg(8) output from working and non-working versions
 
 > acpi_wmi0: <ACPI-WMI mapping> on acpi0
 > acpi_wmi1: <ACPI-WMI mapping> on acpi0
 > acpi_wmi2: <ACPI-WMI mapping> on acpi0
 > acpi_hp0: <HP ACPI-WMI Mapping> on acpi_wmi0
 > acpi_hp0: WMI device does not provide the HP BIOS GUID
 > device_attach: acpi_hp0 attach returned 22
 > acpi_hp1: <HP ACPI-WMI Mapping> on acpi_wmi1
 > acpi_hp1: WMI device does not provide the HP BIOS GUID
 > device_attach: acpi_hp1 attach returned 22
 > acpi_hp2: <HP ACPI-WMI Mapping> on acpi_wmi2
 > acpi_hp2: WMI device does not provide the HP BIOS GUID
 > device_attach: acpi_hp2 attach returned 22
 
 -- 
 Jaakko

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/162491: commit references a PR
Date: Tue, 22 Nov 2011 16:44:59 +0000 (UTC)

 Author: jh
 Date: Tue Nov 22 16:44:50 2011
 New Revision: 227823
 URL: http://svn.freebsd.org/changeset/base/227823
 
 Log:
   Append unit number to the WMI status device name to allow attaching
   multiple acpi_wmi(4) instances.
   
   PR:		kern/162491
   Reviewed by:	avg
 
 Modified:
   head/share/man/man4/acpi_wmi.4
   head/sys/dev/acpi_support/acpi_wmi.c
 
 Modified: head/share/man/man4/acpi_wmi.4
 ==============================================================================
 --- head/share/man/man4/acpi_wmi.4	Tue Nov 22 16:18:12 2011	(r227822)
 +++ head/share/man/man4/acpi_wmi.4	Tue Nov 22 16:44:50 2011	(r227823)
 @@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd February 8, 2010
 +.Dd November 22, 2011
  .Dt ACPI_WMI 4
  .Os
  .Sh NAME
 @@ -49,16 +49,16 @@ The
  .Nm
  driver provides an interface for vendor specific WMI implementations 
  (e.g. HP and Acer laptops).
 -It creates /dev/wmistat, which can be read to get
 +It creates /dev/wmistat%d, which can be read to get
  information about GUIDs found in the system.
  .Sh FILES
 -.Bl -tag -width /dev/wmistat -compact
 -.It Pa /dev/wmistat
 +.Bl -tag -width /dev/wmistat%d -compact
 +.It Pa /dev/wmistat%d
  WMI status device.
  .El
  .Sh EXAMPLES
  .Bd -literal
 -# cat /dev/wmistat
 +# cat /dev/wmistat0
  GUID                                  INST EXPE METH STR EVENT OID
  {5FB7F034-2C63-45E9-BE91-3D44E2C707E4}   1 NO   WMAA NO  NO    AA
  {95F24279-4D7B-4334-9387-ACCDC67EF61C}   1 NO   NO   NO  0x80+ -
 
 Modified: head/sys/dev/acpi_support/acpi_wmi.c
 ==============================================================================
 --- head/sys/dev/acpi_support/acpi_wmi.c	Tue Nov 22 16:18:12 2011	(r227822)
 +++ head/sys/dev/acpi_support/acpi_wmi.c	Tue Nov 22 16:44:50 2011	(r227823)
 @@ -265,7 +265,7 @@ acpi_wmi_attach(device_t dev)
  		    acpi_wmi_ec_handler);
  	} else {
  		sc->wmistat_dev_t = make_dev(&wmistat_cdevsw, 0, UID_ROOT,
 -		    GID_WHEEL, 0644, "wmistat");
 +		    GID_WHEEL, 0644, "wmistat%d", device_get_unit(dev));
  		sc->wmistat_dev_t->si_drv1 = sc;
  		sc->wmistat_open_pid = 0;
  		sc->wmistat_bufptr = -1;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
Responsible-Changed-From-To: freebsd-acpi->jh 
Responsible-Changed-By: jh 
Responsible-Changed-When: Mon Jan 9 15:47:46 UTC 2012 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162491 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/162491: commit references a PR
Date: Mon,  9 Jan 2012 15:56:43 +0000 (UTC)

 Author: jh
 Date: Mon Jan  9 15:56:33 2012
 New Revision: 229858
 URL: http://svn.freebsd.org/changeset/base/229858
 
 Log:
   MFC r227823, r228163:
   
   Append unit number to the WMI status device name to allow attaching
   multiple acpi_wmi(4) instances.
   
   PR:		kern/162491
 
 Modified:
   stable/9/UPDATING   (contents, props changed)
   stable/9/share/man/man4/acpi_wmi.4
   stable/9/sys/dev/acpi_support/acpi_wmi.c
 Directory Properties:
   stable/9/share/man/man4/   (props changed)
   stable/9/sys/   (props changed)
   stable/9/sys/amd64/include/xen/   (props changed)
   stable/9/sys/boot/   (props changed)
   stable/9/sys/boot/i386/efi/   (props changed)
   stable/9/sys/boot/ia64/efi/   (props changed)
   stable/9/sys/boot/ia64/ski/   (props changed)
   stable/9/sys/boot/powerpc/boot1.chrp/   (props changed)
   stable/9/sys/boot/powerpc/ofw/   (props changed)
   stable/9/sys/cddl/contrib/opensolaris/   (props changed)
   stable/9/sys/conf/   (props changed)
   stable/9/sys/contrib/dev/acpica/   (props changed)
   stable/9/sys/contrib/octeon-sdk/   (props changed)
   stable/9/sys/contrib/pf/   (props changed)
   stable/9/sys/contrib/x86emu/   (props changed)
 
 Modified: stable/9/UPDATING
 ==============================================================================
 --- stable/9/UPDATING	Mon Jan  9 14:35:05 2012	(r229857)
 +++ stable/9/UPDATING	Mon Jan  9 15:56:33 2012	(r229858)
 @@ -9,6 +9,10 @@ handbook.
  Items affecting the ports and packages system can be found in
  /usr/ports/UPDATING.  Please read that file before running portupgrade.
  
 +20120109:
 +	The acpi_wmi(4) status device /dev/wmistat has been renamed to
 +	/dev/wmistat0.
 +
  20120106:
  	A new VOP_ADVISE() was added to support posix_fadvise(2).  All
  	filesystem modules must be recompiled.
 
 Modified: stable/9/share/man/man4/acpi_wmi.4
 ==============================================================================
 --- stable/9/share/man/man4/acpi_wmi.4	Mon Jan  9 14:35:05 2012	(r229857)
 +++ stable/9/share/man/man4/acpi_wmi.4	Mon Jan  9 15:56:33 2012	(r229858)
 @@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd February 8, 2010
 +.Dd November 22, 2011
  .Dt ACPI_WMI 4
  .Os
  .Sh NAME
 @@ -49,16 +49,16 @@ The
  .Nm
  driver provides an interface for vendor specific WMI implementations 
  (e.g. HP and Acer laptops).
 -It creates /dev/wmistat, which can be read to get
 +It creates /dev/wmistat%d, which can be read to get
  information about GUIDs found in the system.
  .Sh FILES
 -.Bl -tag -width /dev/wmistat -compact
 -.It Pa /dev/wmistat
 +.Bl -tag -width /dev/wmistat%d -compact
 +.It Pa /dev/wmistat%d
  WMI status device.
  .El
  .Sh EXAMPLES
  .Bd -literal
 -# cat /dev/wmistat
 +# cat /dev/wmistat0
  GUID                                  INST EXPE METH STR EVENT OID
  {5FB7F034-2C63-45E9-BE91-3D44E2C707E4}   1 NO   WMAA NO  NO    AA
  {95F24279-4D7B-4334-9387-ACCDC67EF61C}   1 NO   NO   NO  0x80+ -
 
 Modified: stable/9/sys/dev/acpi_support/acpi_wmi.c
 ==============================================================================
 --- stable/9/sys/dev/acpi_support/acpi_wmi.c	Mon Jan  9 14:35:05 2012	(r229857)
 +++ stable/9/sys/dev/acpi_support/acpi_wmi.c	Mon Jan  9 15:56:33 2012	(r229858)
 @@ -264,7 +264,7 @@ acpi_wmi_attach(device_t dev)
  		    acpi_wmi_ec_handler);
  	} else {
  		sc->wmistat_dev_t = make_dev(&wmistat_cdevsw, 0, UID_ROOT,
 -		    GID_WHEEL, 0644, "wmistat");
 +		    GID_WHEEL, 0644, "wmistat%d", device_get_unit(dev));
  		sc->wmistat_dev_t->si_drv1 = sc;
  		sc->wmistat_open_pid = 0;
  		sc->wmistat_bufptr = -1;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: jh 
State-Changed-When: Mon Jan 9 16:26:32 UTC 2012 
State-Changed-Why:  
The reported panic has been fixed in head and stable/9. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162491 
>Unformatted:
