From nobody@FreeBSD.org  Sun Nov  6 00:21:16 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E343E106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  6 Nov 2011 00:21:16 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id D3B258FC1A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  6 Nov 2011 00:21:16 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pA60LGAm078134
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 6 Nov 2011 00:21:16 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pA60LGCL078133;
	Sun, 6 Nov 2011 00:21:16 GMT
	(envelope-from nobody)
Message-Id: <201111060021.pA60LGCL078133@red.freebsd.org>
Date: Sun, 6 Nov 2011 00:21:16 GMT
From: Alexander Best <arundel@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: unnecessary self-assignment in libc/resolv/res_send.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         162321
>Category:       kern
>Synopsis:       [libc] unnecessary self-assignment in libc/resolv/res_send.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 06 00:30:08 UTC 2011
>Closed-Date:    Mon Jan 09 11:39:50 UTC 2012
>Last-Modified:  Mon Jan 09 11:39:50 UTC 2012
>Originator:     Alexander Best
>Release:        10.0-CURRENT
>Organization:
>Environment:
FreeBSD otaku 10.0-CURRENT FreeBSD 10.0-CURRENT #6: Fri Nov  4 14:33:13 CET 2011     arundel@otaku:/usr/obj/usr/git-freebsd-head/sys/ARUNDEL  amd64
>Description:
i believe the following assignment is unnecessary and can be removed:

/usr/local/bin/clang -fpic -DPIC -O2 -pipe -march=core2 -DSTRIP_FBSDID -I/usr/git-freebsd-head/lib/libc/include -I/usr/git-freebsd-head/lib/libc/../../include -I/usr/git-freebsd-head/lib/libc/amd64 -DNLS  -D__DBINTERFACE_PRIVATE -I/usr/git-freebsd-head/lib/libc/../../contrib/gdtoa -I/usr/obj/usr/git-freebsd-head/lib/libc -I/usr/git-freebsd-head/lib/libc/resolv -D_ACL_PRIVATE -DPOSIX_MISTAKE -I/usr/git-freebsd-head/lib/libc/../../contrib/tzcode/stdtime -I/usr/git-freebsd-head/lib/libc/stdtime -I/usr/git-freebsd-head/lib/libc/locale -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/usr/git-freebsd-head/lib/libc/rpc -DSYMBOL_VERSIONING -std=gnu99 -fstack-protector -Wsystem-headers -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -c /usr/git-freebsd-head/lib/libc/resolv/res_send.c -o res_send.So
/usr/git-freebsd-head/lib/libc/resolv/res_send.c:1105:7: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign]
        alen = alen;
        ~~~~ ^ ~~~~
1 warning generated.

cheers.
alex
>How-To-Repeat:
run buildworld with clang (or clang tot in my case) as compiler.
>Fix:
get rid of the assignment. ;)

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Thu Dec 15 16:15:04 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162321 
State-Changed-From-To: open->closed 
State-Changed-By: arundel 
State-Changed-When: Sat Dec 17 10:57:57 UTC 2011 
State-Changed-Why:  
Fixed in r228537. Since clang will never become the default compiler for 9.X, 
there's no need to MFC this change. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162321 
State-Changed-From-To: closed->patched 
State-Changed-By: arundel 
State-Changed-When: Wed Dec 21 20:11:52 UTC 2011 
State-Changed-Why:  
there's a possibility this will get mfc'ed after all. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162321 
Responsible-Changed-From-To: eadler->dim 
Responsible-Changed-By: arundel 
Responsible-Changed-When: Wed Dec 21 20:12:22 UTC 2011 
Responsible-Changed-Why:  
over to dim@ as mfc reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162321 

From: Dimitry Andric <dim@FreeBSD.org>
To: bug-followup@FreeBSD.org, arundel@FreeBSD.org
Cc:  
Subject: Re: kern/162321: [libc] unnecessary self-assignment in libc/resolv/res_send.c
Date: Mon, 02 Jan 2012 12:59:56 +0100

 Fix has been MFC'd to stable/9 in r229077.
State-Changed-From-To: patched->closed 
State-Changed-By: dim 
State-Changed-When: Mon Jan 9 11:39:20 UTC 2012 
State-Changed-Why:  
Merged to stable/9 in r229077. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162321 
>Unformatted:
