From nobody@FreeBSD.org  Mon Oct 24 08:39:10 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 446EF1065673
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Oct 2011 08:39:10 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 340478FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Oct 2011 08:39:10 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p9O8dAgx025893
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Oct 2011 08:39:10 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p9O8d995025892;
	Mon, 24 Oct 2011 08:39:09 GMT
	(envelope-from nobody)
Message-Id: <201110240839.p9O8d995025892@red.freebsd.org>
Date: Mon, 24 Oct 2011 08:39:09 GMT
From: subbsd <subbsd@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: filesystem lock with mount nullfs in random cases
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         161956
>Category:       kern
>Synopsis:       [nullfs] [hang] filesystem lock with mount nullfs in random cases
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    pho
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 24 08:40:03 UTC 2011
>Closed-Date:    Mon Oct 31 15:08:00 UTC 2011
>Last-Modified:  Mon Oct 31 15:08:00 UTC 2011
>Originator:     subbsd
>Release:        9.0-RC1
>Organization:
>Environment:
FreeBSD fbsd.my.domain 9.0-RC1 FreeBSD 9.0-RC1 #0: Wed Oct 19 23:11:33 MSK 2011     root@fbsd.my.domain:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
filesystem (zfs or ufs) is freezing in random time when mount nullfs is work.

more information: http://docs.freebsd.org/cgi/getmsg.cgi?fetch=270240+0+archive/2011/freebsd-fs/20111023.freebsd-fs
>How-To-Repeat:
making it easy to reproduce when do 'svn cleanup' for mounted directory, see

http://docs.freebsd.org/cgi/getmsg.cgi?fetch=270240+0+archive/2011/freebsd-fs/20111023.freebsd-fs
>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Oct 25 13:14:04 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161956 
State-Changed-From-To: open->patched 
State-Changed-By: pho 
State-Changed-When: Thu Oct 27 08:37:11 UTC 2011 
State-Changed-Why:  
Fixed in HEAD (r226681). 


Responsible-Changed-From-To: freebsd-fs->pho 
Responsible-Changed-By: pho 
Responsible-Changed-When: Thu Oct 27 08:37:11 UTC 2011 
Responsible-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=161956 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/161956: commit references a PR
Date: Mon, 31 Oct 2011 09:18:11 +0000 (UTC)

 Author: pho
 Date: Mon Oct 31 09:18:01 2011
 New Revision: 226963
 URL: http://svn.freebsd.org/changeset/base/226963
 
 Log:
   MFC r226681:
   Only unlock if the lock is exclusive.
   
   Approved by:	re (kib)
   PR:		kern/161956
 
 Modified:
   stable/9/sys/fs/nullfs/null_vfsops.c
 Directory Properties:
   stable/9/sys/   (props changed)
   stable/9/sys/amd64/include/xen/   (props changed)
   stable/9/sys/boot/   (props changed)
   stable/9/sys/boot/i386/efi/   (props changed)
   stable/9/sys/boot/ia64/efi/   (props changed)
   stable/9/sys/boot/ia64/ski/   (props changed)
   stable/9/sys/boot/powerpc/boot1.chrp/   (props changed)
   stable/9/sys/boot/powerpc/ofw/   (props changed)
   stable/9/sys/cddl/contrib/opensolaris/   (props changed)
   stable/9/sys/conf/   (props changed)
   stable/9/sys/contrib/dev/acpica/   (props changed)
   stable/9/sys/contrib/octeon-sdk/   (props changed)
   stable/9/sys/contrib/pf/   (props changed)
   stable/9/sys/contrib/x86emu/   (props changed)
 
 Modified: stable/9/sys/fs/nullfs/null_vfsops.c
 ==============================================================================
 --- stable/9/sys/fs/nullfs/null_vfsops.c	Mon Oct 31 09:06:33 2011	(r226962)
 +++ stable/9/sys/fs/nullfs/null_vfsops.c	Mon Oct 31 09:18:01 2011	(r226963)
 @@ -104,11 +104,10 @@ nullfs_mount(struct mount *mp)
  		return (EINVAL);
  
  	/*
 -	 * Unlock lower node to avoid deadlock.
 -	 * (XXX) VOP_ISLOCKED is needed?
 +	 * Unlock lower node to avoid possible deadlock.
  	 */
  	if ((mp->mnt_vnodecovered->v_op == &null_vnodeops) &&
 -		VOP_ISLOCKED(mp->mnt_vnodecovered)) {
 +	    VOP_ISLOCKED(mp->mnt_vnodecovered) == LK_EXCLUSIVE) {
  		VOP_UNLOCK(mp->mnt_vnodecovered, 0);
  		isvnunlocked = 1;
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/161956: commit references a PR
Date: Mon, 31 Oct 2011 09:22:30 +0000 (UTC)

 Author: pho
 Date: Mon Oct 31 09:22:09 2011
 New Revision: 226964
 URL: http://svn.freebsd.org/changeset/base/226964
 
 Log:
   MFC r226681:
   Only unlock if the lock is exclusive.
   
   PR:		kern/161956
 
 Modified:
   stable/8/sys/fs/nullfs/null_vfsops.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
 
 Modified: stable/8/sys/fs/nullfs/null_vfsops.c
 ==============================================================================
 --- stable/8/sys/fs/nullfs/null_vfsops.c	Mon Oct 31 09:18:01 2011	(r226963)
 +++ stable/8/sys/fs/nullfs/null_vfsops.c	Mon Oct 31 09:22:09 2011	(r226964)
 @@ -104,11 +104,10 @@ nullfs_mount(struct mount *mp)
  		return (EINVAL);
  
  	/*
 -	 * Unlock lower node to avoid deadlock.
 -	 * (XXX) VOP_ISLOCKED is needed?
 +	 * Unlock lower node to avoid possible deadlock.
  	 */
  	if ((mp->mnt_vnodecovered->v_op == &null_vnodeops) &&
 -		VOP_ISLOCKED(mp->mnt_vnodecovered)) {
 +	    VOP_ISLOCKED(mp->mnt_vnodecovered) == LK_EXCLUSIVE) {
  		VOP_UNLOCK(mp->mnt_vnodecovered, 0);
  		isvnunlocked = 1;
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: pho 
State-Changed-When: Mon Oct 31 15:02:50 UTC 2011 
State-Changed-Why:  
Fix merged to stable/8 and stable/9. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161956 
>Unformatted:
