From nobody@FreeBSD.org  Sat Oct 15 02:48:46 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8F44C1065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 Oct 2011 02:48:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 659858FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 Oct 2011 02:48:46 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p9F2mkxq054219
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 Oct 2011 02:48:46 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p9F2mjTm054218;
	Sat, 15 Oct 2011 02:48:45 GMT
	(envelope-from nobody)
Message-Id: <201110150248.p9F2mjTm054218@red.freebsd.org>
Date: Sat, 15 Oct 2011 02:48:45 GMT
From: tanaka s <sh_tanaka@yahoo.co.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: snapshot on journaled ufs doesn't work
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         161674
>Category:       kern
>Synopsis:       [ufs] snapshot on journaled ufs doesn't work
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    mckusick
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 15 02:50:01 UTC 2011
>Closed-Date:    Tue Feb 07 04:31:23 UTC 2012
>Last-Modified:  Tue Feb 07 04:31:23 UTC 2012
>Originator:     tanaka s
>Release:        9.0 BETA3
>Organization:
>Environment:
FreeBSD vexpress 9.0-BETA3 FreeBSD 9.0-BETA3 #0: Sat Sep 24 20:46:57 UTC 2011     root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

FreeBSD ml110g6 9.0-BETA3 FreeBSD 9.0-BETA3 #6: Wed Oct 12 21:15:31 JST 2011     root@ml110g6:/usr/obj/usr/src/sys/MYKERNEL  i386

>Description:
When creating snapshot on journaled ufs,
  (1) System will freeze,  or
  (2) Journaling and Softupdating will be disabled.

Fowllowing log is (2).

Before making snapshot,
    /dev/ada0p3 on /var (ufs, local, journaled soft-updates)
After making and deleting snapshot
    /dev/ada0p3 on /var (ufs, local)

********************************************************************
vexpress# uname -a
FreeBSD vexpress 9.0-BETA3 FreeBSD 9.0-BETA3 #0: Sat Sep 24 20:46:57 UTC 2011     root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
vexpress# df -k
Filesystem  1024-blocks   Used    Avail Capacity  Mounted on
/dev/ada0p2      515676 209716   264708    44%    /
devfs                 1      1        0   100%    /dev
/dev/ada0p3     1031708   9264   939908     1%    /var
/dev/ada0p5    12380444 264400 11125612     2%    /usr
vexpress# mount
/dev/ada0p2 on / (ufs, local, journaled soft-updates)
devfs on /dev (devfs, local, multilabel)
/dev/ada0p3 on /var (ufs, local, journaled soft-updates)
/dev/ada0p5 on /usr (ufs, local, journaled soft-updates)
vexpress#
vexpress# dump -0aLu -f /usr/var3.dmp /var
  DUMP: Date of this level 0 dump: Sat Oct 15 11:09:20 2011
  DUMP: Date of last level 0 dump: the epoch
  DUMP: Dumping snapshot of /dev/ada0p3 (/var) to /usr/var3.dmp
  DUMP: mapping (Pass I) [regular files]
  DUMP: mapping (Pass II) [directories]
  DUMP: estimated 406 tape blocks.
  DUMP: dumping (Pass III) [directories]
  DUMP: dumping (Pass IV) [regular files]
  DUMP: DUMP: 398 tape blocks on 1 volume
  DUMP: finished in 1 seconds, throughput 398 KBytes/sec
  DUMP: level 0 dump on Sat Oct 15 11:09:20 2011
  DUMP: Closing /usr/var3.dmp
  DUMP: DUMP IS DONE
vexpress#
vexpress#
vexpress# mount
/dev/ada0p2 on / (ufs, local, journaled soft-updates)
devfs on /dev (devfs, local, multilabel)
/dev/ada0p3 on /var (ufs, local)
/dev/ada0p5 on /usr (ufs, local, journaled soft-updates)
vexpress#
   

>How-To-Repeat:
Install FreeBSD 9 BETA3
# dump -0aLu -f [backupd_file] [journaled_file_system]
>Fix:
disable journaling

tunefs -n enable -j disable [file_system]

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sun Oct 16 22:48:01 UTC 2011 
Responsible-Changed-Why:  
over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161674 
State-Changed-From-To: open->closed 
State-Changed-By: mckusick 
State-Changed-When: Tue Feb 7 04:27:05 UTC 2012 
State-Changed-Why:  
This bug was fixed in head in -r230249: 

Make sure all intermediate variables holding mount flags (mnt_flag) 
and that all internal kernel calls passing mount flags are declared 
as uint64_t so that flags in the top 32-bits are not lost. 

The soft update journalling flag is located in the top 32-bits of 
mnt_flag and was being lost due to this bug. 

This fix was MFC'ed to 9 in -r230725 on Sun Jan 29 08:03:45 2012. 



Responsible-Changed-From-To: freebsd-fs->mckusick 
Responsible-Changed-By: mckusick 
Responsible-Changed-When: Tue Feb 7 04:27:05 UTC 2012 
Responsible-Changed-Why:  
I have taken responsibility for this bug. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161674 
>Unformatted:
