From nobody@FreeBSD.org  Sun Aug 21 18:32:37 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B7D921065800
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 21 Aug 2011 18:32:37 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id A67998FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 21 Aug 2011 18:32:37 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p7LIWbg6087415
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 21 Aug 2011 18:32:37 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p7LIWblq087414;
	Sun, 21 Aug 2011 18:32:37 GMT
	(envelope-from nobody)
Message-Id: <201108211832.p7LIWblq087414@red.freebsd.org>
Date: Sun, 21 Aug 2011 18:32:37 GMT
From: Garrett Cooper <yaneurabeya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] add units to hw.acpi.sleep_delay
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         159975
>Category:       kern
>Synopsis:       [acpica] [patch] add units to hw.acpi.sleep_delay
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 21 18:40:09 UTC 2011
>Closed-Date:    Tue Sep 20 07:03:24 CEST 2011
>Last-Modified:  Sun Feb 03 22:29:17 UTC 2013
>Originator:     Garrett Cooper
>Release:        9.0-BETA1
>Organization:
n/a
>Environment:
FreeBSD akai-ntbk.local 9.0-BETA1 FreeBSD 9.0-BETA1 #8 r225048M: Sun Aug 21 01:09:59 PDT 2011     root@akai-ntbk.local:/usr/obj/usr/src/sys/NETBOOK  i386
>Description:
The current description for the hw.acpi.sleep_delay sysctl doesn't note that the unit is in seconds. The attached patch documents that.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: sys/dev/acpica/acpi.c
===================================================================
--- sys/dev/acpica/acpi.c	(revision 225048)
+++ sys/dev/acpica/acpi.c	(working copy)
@@ -574,7 +574,7 @@
 	&sc->acpi_suspend_sx, 0, acpi_sleep_state_sysctl, "A", "");
     SYSCTL_ADD_INT(&sc->acpi_sysctl_ctx, SYSCTL_CHILDREN(sc->acpi_sysctl_tree),
 	OID_AUTO, "sleep_delay", CTLFLAG_RW, &sc->acpi_sleep_delay, 0,
-	"sleep delay");
+	"sleep delay in seconds");
     SYSCTL_ADD_INT(&sc->acpi_sysctl_ctx, SYSCTL_CHILDREN(sc->acpi_sysctl_tree),
 	OID_AUTO, "s4bios", CTLFLAG_RW, &sc->acpi_s4bios, 0, "S4BIOS mode");
     SYSCTL_ADD_INT(&sc->acpi_sysctl_ctx, SYSCTL_CHILDREN(sc->acpi_sysctl_tree),


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: brueffer 
State-Changed-When: Tue Sep 13 17:57:35 CEST 2011 
State-Changed-Why:  
Committed, MFC pending. Thanks! 


Responsible-Changed-From-To: freebsd-bugs->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Tue Sep 13 17:57:35 CEST 2011 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159975 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/159975: commit references a PR
Date: Tue, 13 Sep 2011 15:57:43 +0000 (UTC)

 Author: brueffer
 Date: Tue Sep 13 15:57:29 2011
 New Revision: 225533
 URL: http://svn.freebsd.org/changeset/base/225533
 
 Log:
   Improve the sleep_delay sysctl description by specifying which unit
   the number is in.
   
   PR:		159975
   Submitted by:	gcooper
   Approved by:	re (kib)
   MFC after:	1 week
 
 Modified:
   head/sys/dev/acpica/acpi.c
 
 Modified: head/sys/dev/acpica/acpi.c
 ==============================================================================
 --- head/sys/dev/acpica/acpi.c	Tue Sep 13 15:49:28 2011	(r225532)
 +++ head/sys/dev/acpica/acpi.c	Tue Sep 13 15:57:29 2011	(r225533)
 @@ -574,7 +574,7 @@ acpi_attach(device_t dev)
  	&sc->acpi_suspend_sx, 0, acpi_sleep_state_sysctl, "A", "");
      SYSCTL_ADD_INT(&sc->acpi_sysctl_ctx, SYSCTL_CHILDREN(sc->acpi_sysctl_tree),
  	OID_AUTO, "sleep_delay", CTLFLAG_RW, &sc->acpi_sleep_delay, 0,
 -	"sleep delay");
 +	"sleep delay in seconds");
      SYSCTL_ADD_INT(&sc->acpi_sysctl_ctx, SYSCTL_CHILDREN(sc->acpi_sysctl_tree),
  	OID_AUTO, "s4bios", CTLFLAG_RW, &sc->acpi_s4bios, 0, "S4BIOS mode");
      SYSCTL_ADD_INT(&sc->acpi_sysctl_ctx, SYSCTL_CHILDREN(sc->acpi_sysctl_tree),
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brueffer 
State-Changed-When: Tue Sep 20 07:03:01 CEST 2011 
State-Changed-Why:  
MFCs done. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159975 
>Unformatted:
