From nobody@FreeBSD.org  Fri Aug 19 10:17:14 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E8F12106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 19 Aug 2011 10:17:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id D8EDA8FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 19 Aug 2011 10:17:14 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p7JAHEOq046499
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 19 Aug 2011 10:17:14 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p7JAHE9K046498;
	Fri, 19 Aug 2011 10:17:14 GMT
	(envelope-from nobody)
Message-Id: <201108191017.p7JAHE9K046498@red.freebsd.org>
Date: Fri, 19 Aug 2011 10:17:14 GMT
From: Ivan Klymenko <fidaj@ukr.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] type specifier error /sys/kern/sched_4bsd.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         159904
>Category:       kern
>Synopsis:       [patch] type specifier error /sys/kern/sched_4bsd.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    delphij
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 19 10:20:09 UTC 2011
>Closed-Date:    Fri Sep 09 01:38:33 UTC 2011
>Last-Modified:  Fri Sep  9 01:40:04 UTC 2011
>Originator:     Ivan Klymenko
>Release:        FreeBSD 9.0-BETA1 amd64
>Organization:
individual
>Environment:
>Description:

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- sched_4bsd.c.orig	2011-08-19 13:10:21.000000000 +0300
+++ sched_4bsd.c	2011-08-19 13:10:46.000000000 +0300
@@ -720,7 +720,7 @@
 {
 
 	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(td), "proc exit",
-	    "prio:td", td->td_priority);
+	    "prio:%d", td->td_priority);
 
 	PROC_LOCK_ASSERT(p, MA_OWNED);
 	sched_exit_thread(FIRST_THREAD_IN_PROC(p), td);
@@ -731,7 +731,7 @@
 {
 
 	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "exit",
-	    "prio:td", child->td_priority);
+	    "prio:%d", child->td_priority);
 	thread_lock(td);
 	td->td_estcpu = ESTCPULIM(td->td_estcpu + child->td_estcpu);
 	thread_unlock(td);


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->delphij 
Responsible-Changed-By: delphij 
Responsible-Changed-When: Thu Aug 25 22:49:23 UTC 2011 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159904 
State-Changed-From-To: open->patched 
State-Changed-By: delphij 
State-Changed-When: Fri Aug 26 18:00:28 UTC 2011 
State-Changed-Why:  
Patch applied against -HEAD, MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159904 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/159904: commit references a PR
Date: Fri, 26 Aug 2011 18:00:27 +0000 (UTC)

 Author: delphij
 Date: Fri Aug 26 18:00:07 2011
 New Revision: 225199
 URL: http://svn.freebsd.org/changeset/base/225199
 
 Log:
   Fix format strings for KTR_STATE in 4BSD ad ULE schedulers.
   
   Submitted by:	Ivan Klymenko <fidaj@ukr.net>
   PR:		kern/159904, kern/159905
   MFC after:	2 weeks
   Approved by:	re (kib)
 
 Modified:
   head/sys/kern/sched_4bsd.c
   head/sys/kern/sched_ule.c
 
 Modified: head/sys/kern/sched_4bsd.c
 ==============================================================================
 --- head/sys/kern/sched_4bsd.c	Fri Aug 26 17:45:56 2011	(r225198)
 +++ head/sys/kern/sched_4bsd.c	Fri Aug 26 18:00:07 2011	(r225199)
 @@ -720,7 +720,7 @@ sched_exit(struct proc *p, struct thread
  {
  
  	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(td), "proc exit",
 -	    "prio:td", td->td_priority);
 +	    "prio:%d", td->td_priority);
  
  	PROC_LOCK_ASSERT(p, MA_OWNED);
  	sched_exit_thread(FIRST_THREAD_IN_PROC(p), td);
 @@ -731,7 +731,7 @@ sched_exit_thread(struct thread *td, str
  {
  
  	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "exit",
 -	    "prio:td", child->td_priority);
 +	    "prio:%d", child->td_priority);
  	thread_lock(td);
  	td->td_estcpu = ESTCPULIM(td->td_estcpu + child->td_estcpu);
  	thread_unlock(td);
 
 Modified: head/sys/kern/sched_ule.c
 ==============================================================================
 --- head/sys/kern/sched_ule.c	Fri Aug 26 17:45:56 2011	(r225198)
 +++ head/sys/kern/sched_ule.c	Fri Aug 26 18:00:07 2011	(r225199)
 @@ -2022,7 +2022,7 @@ sched_exit(struct proc *p, struct thread
  	struct thread *td;
  
  	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "proc exit",
 -	    "prio:td", child->td_priority);
 +	    "prio:%d", child->td_priority);
  	PROC_LOCK_ASSERT(p, MA_OWNED);
  	td = FIRST_THREAD_IN_PROC(p);
  	sched_exit_thread(td, child);
 @@ -2039,7 +2039,7 @@ sched_exit_thread(struct thread *td, str
  {
  
  	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "thread exit",
 -	    "prio:td", child->td_priority);
 +	    "prio:%d", child->td_priority);
  	/*
  	 * Give the child's runtime to the parent without returning the
  	 * sleep time as a penalty to the parent.  This causes shells that
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: delphij 
State-Changed-When: Fri Sep 9 01:38:15 UTC 2011 
State-Changed-Why:  
MFC'ed to RELENG_8, thanks for your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159904 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/159904: commit references a PR
Date: Fri,  9 Sep 2011 01:39:28 +0000 (UTC)

 Author: delphij
 Date: Fri Sep  9 01:39:19 2011
 New Revision: 225454
 URL: http://svn.freebsd.org/changeset/base/225454
 
 Log:
   MFC r225199:
   
   Fix format strings for KTR_STATE in 4BSD ad ULE schedulers.
   
   Submitted by:	Ivan Klymenko <fidaj@ukr.net>
   PR:		kern/159904, kern/159905
 
 Modified:
   stable/8/sys/kern/sched_4bsd.c
   stable/8/sys/kern/sched_ule.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
 
 Modified: stable/8/sys/kern/sched_4bsd.c
 ==============================================================================
 --- stable/8/sys/kern/sched_4bsd.c	Thu Sep  8 23:59:16 2011	(r225453)
 +++ stable/8/sys/kern/sched_4bsd.c	Fri Sep  9 01:39:19 2011	(r225454)
 @@ -717,7 +717,7 @@ sched_exit(struct proc *p, struct thread
  {
  
  	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(td), "proc exit",
 -	    "prio:td", td->td_priority);
 +	    "prio:%d", td->td_priority);
  
  	PROC_LOCK_ASSERT(p, MA_OWNED);
  	sched_exit_thread(FIRST_THREAD_IN_PROC(p), td);
 @@ -728,7 +728,7 @@ sched_exit_thread(struct thread *td, str
  {
  
  	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "exit",
 -	    "prio:td", child->td_priority);
 +	    "prio:%d", child->td_priority);
  	thread_lock(td);
  	td->td_estcpu = ESTCPULIM(td->td_estcpu + child->td_estcpu);
  	thread_unlock(td);
 
 Modified: stable/8/sys/kern/sched_ule.c
 ==============================================================================
 --- stable/8/sys/kern/sched_ule.c	Thu Sep  8 23:59:16 2011	(r225453)
 +++ stable/8/sys/kern/sched_ule.c	Fri Sep  9 01:39:19 2011	(r225454)
 @@ -2032,7 +2032,7 @@ sched_exit(struct proc *p, struct thread
  	struct thread *td;
  
  	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "proc exit",
 -	    "prio:td", child->td_priority);
 +	    "prio:%d", child->td_priority);
  	PROC_LOCK_ASSERT(p, MA_OWNED);
  	td = FIRST_THREAD_IN_PROC(p);
  	sched_exit_thread(td, child);
 @@ -2049,7 +2049,7 @@ sched_exit_thread(struct thread *td, str
  {
  
  	KTR_STATE1(KTR_SCHED, "thread", sched_tdname(child), "thread exit",
 -	    "prio:td", child->td_priority);
 +	    "prio:%d", child->td_priority);
  	/*
  	 * Give the child's runtime to the parent without returning the
  	 * sleep time as a penalty to the parent.  This causes shells that
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
