From nobody@FreeBSD.org  Mon Aug  8 13:02:00 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 032431065676
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  8 Aug 2011 13:02:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id E6E7E8FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  8 Aug 2011 13:01:59 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p78D1xS7079862
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 8 Aug 2011 13:01:59 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p78D1xOL079861;
	Mon, 8 Aug 2011 13:01:59 GMT
	(envelope-from nobody)
Message-Id: <201108081301.p78D1xOL079861@red.freebsd.org>
Date: Mon, 8 Aug 2011 13:01:59 GMT
From: Svatopluk Kraus <onwahe@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [path] arp_ifscrub() is called even if IFF_NOARP flag is set
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         159602
>Category:       kern
>Synopsis:       [netinet] [patch] arp_ifscrub() is called even if IFF_NOARP flag is set
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    qingli
>State:          patched
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 08 13:10:17 UTC 2011
>Closed-Date:    
>Last-Modified:  Tue Oct 18 03:49:51 UTC 2011
>Originator:     Svatopluk Kraus
>Release:        current
>Organization:
>Environment:
>Description:
arp_ifscrub() is called on interface with IFF_NOARP flag set. A message
"interface address is missing from cache = %p  in delete" is printed.
>How-To-Repeat:

>Fix:
Index: sys/netinet/in.c
===================================================================
--- sys/netinet/in.c	(revision 224705)
+++ sys/netinet/in.c	(working copy)
@@ -1136,7 +1136,8 @@
 			if (error == 0)
 				target->ia_flags &= ~IFA_RTSELF;
 		}
-		if (flags & LLE_STATIC)
+		if ((flags & LLE_STATIC) &&
+		    !(target->ia_ifp->if_flags & IFF_NOARP))
 			/* remove arp cache */
 			arp_ifscrub(target->ia_ifp, IA_SIN(target)->sin_addr.s_addr);
 	}


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Aug 14 10:29:32 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159602 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/159602: commit references a PR
Date: Fri,  7 Oct 2011 22:22:29 +0000 (UTC)

 Author: qingli
 Date: Fri Oct  7 22:22:19 2011
 New Revision: 226120
 URL: http://svn.freebsd.org/changeset/base/226120
 
 Log:
   Do not try removing an ARP entry associated with a given interface
   address if that interface does not support ARP. Otherwise the
   system will generate error messages unnecessarily due to the missing
   entry.
   
   PR:		kern/159602
   Submitted by:	pluknet
   MFC after:	3 days
 
 Modified:
   head/sys/netinet/in.c
 
 Modified: head/sys/netinet/in.c
 ==============================================================================
 --- head/sys/netinet/in.c	Fri Oct  7 22:14:18 2011	(r226119)
 +++ head/sys/netinet/in.c	Fri Oct  7 22:22:19 2011	(r226120)
 @@ -1138,7 +1138,8 @@ in_scrubprefix(struct in_ifaddr *target,
  			if (error == 0)
  				target->ia_flags &= ~IFA_RTSELF;
  		}
 -		if (flags & LLE_STATIC)
 +		if ((flags & LLE_STATIC) &&
 +			!(target->ia_ifp->if_flags & IFF_NOARP))
  			/* remove arp cache */
  			arp_ifscrub(target->ia_ifp, IA_SIN(target)->sin_addr.s_addr);
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/159602: commit references a PR
Date: Mon, 10 Oct 2011 21:44:10 +0000 (UTC)

 Author: qingli
 Date: Mon Oct 10 21:43:53 2011
 New Revision: 226238
 URL: http://svn.freebsd.org/changeset/base/226238
 
 Log:
   MFC 226120
   
   Do not try removing an ARP entry associated with a given interface
   address if that interface does not support ARP. Otherwise the
   system will generate error messages unnecessarily due to the missing
   entry.
   
   PR:		kern/159602
   Submitted by:	pluknet
 
 Modified:
   stable/8/sys/netinet/in.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
 
 Modified: stable/8/sys/netinet/in.c
 ==============================================================================
 --- stable/8/sys/netinet/in.c	Mon Oct 10 21:41:34 2011	(r226237)
 +++ stable/8/sys/netinet/in.c	Mon Oct 10 21:43:53 2011	(r226238)
 @@ -1138,7 +1138,8 @@ in_scrubprefix(struct in_ifaddr *target,
  			if (error == 0)
  				target->ia_flags &= ~IFA_RTSELF;
  		}
 -		if (flags & LLE_STATIC)
 +		if ((flags & LLE_STATIC) &&
 +			!(target->ia_ifp->if_flags & IFF_NOARP))
  			/* remove arp cache */
  			arp_ifscrub(target->ia_ifp, IA_SIN(target)->sin_addr.s_addr);
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/159602: commit references a PR
Date: Thu, 13 Oct 2011 09:21:58 +0000 (UTC)

 Author: qingli
 Date: Thu Oct 13 09:21:49 2011
 New Revision: 226337
 URL: http://svn.freebsd.org/changeset/base/226337
 
 Log:
   MFC 226120
   
   PR:		kern/159602
   Submitted by:	pluknet
   Approved by:	re (kib)
 
 Modified:
   stable/9/sys/netinet/in.c
 Directory Properties:
   stable/9/sys/   (props changed)
   stable/9/sys/amd64/include/xen/   (props changed)
   stable/9/sys/boot/   (props changed)
   stable/9/sys/boot/i386/efi/   (props changed)
   stable/9/sys/boot/ia64/efi/   (props changed)
   stable/9/sys/boot/ia64/ski/   (props changed)
   stable/9/sys/boot/powerpc/boot1.chrp/   (props changed)
   stable/9/sys/boot/powerpc/ofw/   (props changed)
   stable/9/sys/cddl/contrib/opensolaris/   (props changed)
   stable/9/sys/conf/   (props changed)
   stable/9/sys/contrib/dev/acpica/   (props changed)
   stable/9/sys/contrib/octeon-sdk/   (props changed)
   stable/9/sys/contrib/pf/   (props changed)
   stable/9/sys/contrib/x86emu/   (props changed)
 
 Modified: stable/9/sys/netinet/in.c
 ==============================================================================
 --- stable/9/sys/netinet/in.c	Thu Oct 13 08:36:11 2011	(r226336)
 +++ stable/9/sys/netinet/in.c	Thu Oct 13 09:21:49 2011	(r226337)
 @@ -1138,7 +1138,8 @@ in_scrubprefix(struct in_ifaddr *target,
  			if (error == 0)
  				target->ia_flags &= ~IFA_RTSELF;
  		}
 -		if (flags & LLE_STATIC)
 +		if ((flags & LLE_STATIC) &&
 +			!(target->ia_ifp->if_flags & IFF_NOARP))
  			/* remove arp cache */
  			arp_ifscrub(target->ia_ifp, IA_SIN(target)->sin_addr.s_addr);
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: Svatopluk Kraus <onwahe@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: kern/159602: [netinet] [patch] arp_ifscrub() is called even if
 IFF_NOARP flag is set
Date: Thu, 13 Oct 2011 11:20:18 +0200

 Thanks for commit. I think the PR can be closed.
State-Changed-From-To: open->patched 
State-Changed-By: linimon 
State-Changed-When: Tue Oct 18 03:49:20 UTC 2011 
State-Changed-Why:  
Merged to 9, but I don't know if it is mergeable to 7 or 8. 


Responsible-Changed-From-To: freebsd-net->qingli 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Oct 18 03:49:20 UTC 2011 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=159602 
>Unformatted:
