From eugen@eg.sd.rdtc.ru  Mon Aug  1 06:35:14 2011
Return-Path: <eugen@eg.sd.rdtc.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D39AC106568A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  1 Aug 2011 06:35:14 +0000 (UTC)
	(envelope-from eugen@eg.sd.rdtc.ru)
Received: from eg.sd.rdtc.ru (unknown [IPv6:2a03:3100:c:13::5])
	by mx1.freebsd.org (Postfix) with ESMTP id 3D3878FC17
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  1 Aug 2011 06:35:13 +0000 (UTC)
Received: from eg.sd.rdtc.ru (localhost [127.0.0.1])
	by eg.sd.rdtc.ru (8.14.4/8.14.4) with ESMTP id p716ZBA6053623
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 1 Aug 2011 13:35:11 +0700 (NOVST)
	(envelope-from eugen@eg.sd.rdtc.ru)
Received: (from eugen@localhost)
	by eg.sd.rdtc.ru (8.14.4/8.14.4/Submit) id p716Z5ED053622;
	Mon, 1 Aug 2011 13:35:05 +0700 (NOVST)
	(envelope-from eugen)
Message-Id: <201108010635.p716Z5ED053622@eg.sd.rdtc.ru>
Date: Mon, 1 Aug 2011 13:35:05 +0700 (NOVST)
From: Eugene Grosbein <egrosbein@rdtc.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [if_lagg] [panic] kernel with if_lagg compiled in panices at start if if_lagg.ko is loaded
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         159345
>Category:       kern
>Synopsis:       [lagg] [panic] kernel with if_lagg compiled in panices at start if if_lagg.ko is loaded
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pluknet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 01 06:40:04 UTC 2011
>Closed-Date:    Mon Aug 08 12:22:03 UTC 2011
>Last-Modified:  Mon Aug  8 12:30:16 UTC 2011
>Originator:     Eugene Grosbein
>Release:        FreeBSD 8.2-STABLE amd64
>Organization:
RDTC JSC
>Environment:
FreeBSD 8.2-STABLE amd64

>Description:
	If kernel has both 'device lagg' compiled in and
	if_lagg_load="YES" in /boot/loader.conf, it panices before
	crashdump device configured:

atkbd0: [GIANT-LOCKED]
atkbd0: [ITHREAD]
coretemp0: <CPU On-Die Thermal Sensors> on cpu0
est0: <Enhanced SpeedStep Frequency Control> on cpu0
p4tcc0: <CPU Frequency Thermal Control> on cpu0
coretemp1: <CPU On-Die Thermal Sensors> on cpu1
est1: <Enhanced SpeedStep Frequency Control> on cpu1
p4tcc1: <CPU Frequency Thermal Control> on cpu1
coretemp2: <CPU On-Die Thermal Sensors> on cpu2
est2: <Enhanced SpeedStep Frequency Control> on cpu2
p4tcc2: <CPU Frequency Thermal Control> on cpu2
coretemp3: <CPU On-Die Thermal Sensors> on cpu3
est3: <Enhanced SpeedStep Frequency Control> on cpu3
p4tcc3: <CPU Frequency Thermal Control> on cpu3
Timecounters tick every 1.000 msec
panic: lock "if_lagg list" 0xffffffff808d6e00 already initialized
cpuid = 0
KDB: stack backtrace:
db_trace_self_wrapper() at 0xffffffff801a91da = db_trace_self_wrapper+0x2a
kdb_backtrace() at 0xffffffff8031e117 = kdb_backtrace+0x37
panic() at 0xffffffff802ec48e = panic+0x27e
lock_init() at 0xffffffff8031e99d = lock_init+0x5d
lagg_modevent() at 0xffffffff808d225f = lagg_modevent+0x1f
module_register_init() at 0xffffffff802dcb8d = module_register_init+0x7d
mi_startup() at 0xffffffff802a7fc7 = mi_startup+0x77
btext() at 0xffffffff801631fc = btext+0x2c
Uptime: 1s
Cannot dump. Device not defined or unavailable.
Automatic reboot in 15 seconds - press a key on the console to abort
Rebooting...

>How-To-Repeat:
	Boot kernel with device lagg compiled in and have
	if_lagg_load="YES" in /boot/loader.conf

>Fix:

	Unknown. Other modules do now behave so and instead of panic
	they just issue a warning.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Aug 1 07:00:37 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159345 
Responsible-Changed-From-To: freebsd-net->pluknet 
Responsible-Changed-By: pluknet 
Responsible-Changed-When: Mon Aug 1 10:29:53 UTC 2011 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159345 

From: Eugene Grosbein <egrosbein@rdtc.ru>
To: bug-followup@FreeBSD.ORG
Cc:  
Subject: Re: kern/159345: [lagg] [panic] kernel with if_lagg compiled in panices
 at start if if_lagg.ko is loaded
Date: Mon, 01 Aug 2011 17:20:02 +0700

 Hi!
 
 I've got a patch that converts this panic to harmless warning:
 
 --- sys/net/if_lagg.c.orig      2011-08-01 14:36:00.000000000 +0700
 +++ /sys/net/if_lagg.c   2011-08-01 14:36:17.000000000 +0700
 @@ -208,6 +208,7 @@
         0
  };
  
 +MODULE_VERSION(if_lagg, 1);
  DECLARE_MODULE(if_lagg, lagg_mod, SI_SUB_PSEUDO, SI_ORDER_ANY);
  
  #if __FreeBSD_version >= 800000
 
State-Changed-From-To: open->patched 
State-Changed-By: pluknet 
State-Changed-When: Mon Aug 1 11:26:49 UTC 2011 
State-Changed-Why:  
Fixed in HEAD. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159345 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/159345: commit references a PR
Date: Mon,  1 Aug 2011 11:25:13 +0000 (UTC)

 Author: pluknet
 Date: Mon Aug  1 11:24:55 2011
 New Revision: 224571
 URL: http://svn.freebsd.org/changeset/base/224571
 
 Log:
   Add missing MODULE_VERSION() definition to protect against duplicating
   module loads.
   
   PR:		kern/159345
   Reported by:	Eugene Grosbein <egrosbein att rdtc ru>
   Tested by:	Eugene Grosbein <egrosbein att rdtc ru>
   Approved by:	re (kib)
   MFC after:	1 week
 
 Modified:
   head/sys/net/if_lagg.c
 
 Modified: head/sys/net/if_lagg.c
 ==============================================================================
 --- head/sys/net/if_lagg.c	Mon Aug  1 10:57:54 2011	(r224570)
 +++ head/sys/net/if_lagg.c	Mon Aug  1 11:24:55 2011	(r224571)
 @@ -208,6 +208,7 @@ static moduledata_t lagg_mod = {
  };
  
  DECLARE_MODULE(if_lagg, lagg_mod, SI_SUB_PSEUDO, SI_ORDER_ANY);
 +MODULE_VERSION(if_lagg, 1);
  
  #if __FreeBSD_version >= 800000
  /*
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: pluknet 
State-Changed-When: Mon Aug 8 12:19:35 UTC 2011 
State-Changed-Why:  
Merged to 8-STABLE and 7-STABLE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159345 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/159345: commit references a PR
Date: Mon,  8 Aug 2011 12:16:56 +0000 (UTC)

 Author: pluknet
 Date: Mon Aug  8 12:16:42 2011
 New Revision: 224706
 URL: http://svn.freebsd.org/changeset/base/224706
 
 Log:
   MFC r224571:
    Add missing MODULE_VERSION() definition.
   
   PR:		kern/159345
 
 Modified:
   stable/8/sys/net/if_lagg.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
 
 Modified: stable/8/sys/net/if_lagg.c
 ==============================================================================
 --- stable/8/sys/net/if_lagg.c	Mon Aug  8 11:33:07 2011	(r224705)
 +++ stable/8/sys/net/if_lagg.c	Mon Aug  8 12:16:42 2011	(r224706)
 @@ -204,6 +204,7 @@ static moduledata_t lagg_mod = {
  };
  
  DECLARE_MODULE(if_lagg, lagg_mod, SI_SUB_PSEUDO, SI_ORDER_ANY);
 +MODULE_VERSION(if_lagg, 1);
  
  #if __FreeBSD_version >= 800000
  /*
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/159345: commit references a PR
Date: Mon,  8 Aug 2011 12:19:38 +0000 (UTC)

 Author: pluknet
 Date: Mon Aug  8 12:19:20 2011
 New Revision: 224707
 URL: http://svn.freebsd.org/changeset/base/224707
 
 Log:
   MFC r224571:
    Add missing MODULE_VERSION() definition.
   
   PR:		kern/159345
 
 Modified:
   stable/7/sys/net/if_lagg.c
 Directory Properties:
   stable/7/sys/   (props changed)
   stable/7/sys/cddl/contrib/opensolaris/   (props changed)
   stable/7/sys/contrib/dev/acpica/   (props changed)
   stable/7/sys/contrib/pf/   (props changed)
 
 Modified: stable/7/sys/net/if_lagg.c
 ==============================================================================
 --- stable/7/sys/net/if_lagg.c	Mon Aug  8 12:16:42 2011	(r224706)
 +++ stable/7/sys/net/if_lagg.c	Mon Aug  8 12:19:20 2011	(r224707)
 @@ -203,6 +203,7 @@ static moduledata_t lagg_mod = {
  };
  
  DECLARE_MODULE(if_lagg, lagg_mod, SI_SUB_PSEUDO, SI_ORDER_ANY);
 +MODULE_VERSION(if_lagg, 1);
  
  static int
  lagg_clone_create(struct if_clone *ifc, int unit, caddr_t params)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
