From nobody@FreeBSD.org  Thu Jul 28 20:23:59 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 90F85106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 28 Jul 2011 20:23:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8156F8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 28 Jul 2011 20:23:59 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p6SKNx3n010618
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 28 Jul 2011 20:23:59 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p6SKNxWE010598;
	Thu, 28 Jul 2011 20:23:59 GMT
	(envelope-from nobody)
Message-Id: <201107282023.p6SKNxWE010598@red.freebsd.org>
Date: Thu, 28 Jul 2011 20:23:59 GMT
From: Alexey Gulchenko <gulchenko_alexey@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: "pseudo-raid" controllers does not work in latest releases
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         159271
>Category:       kern
>Synopsis:       [ataraid] [patch] "pseudo-raid" controllers does not work in latest releases
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 28 20:30:10 UTC 2011
>Closed-Date:    Tue Jan 22 17:22:37 UTC 2013
>Last-Modified:  Tue Jan 22 17:30:01 UTC 2013
>Originator:     Alexey Gulchenko
>Release:        8.2-RELEASE
>Organization:
>Environment:
FreeBSD agserver.home 8.2-RELEASE-p2 FreeBSD 8.2-RELEASE-p2 #3: Thu Jul 28 15:32:49 EEST 2011     root@agserver.home:/usr/obj/usr/src/sys/agserver  amd64

>Description:
FreeBSD installed on mirror (RAID0). 
Controller based on JMicron (JMB363) chip. In some builds of FreeBSD
I've found little problem with pseudo-raid cards. After upgrading FreeBSD
from version RELEASE-8.0 up to RELEASE-8.2 my server stop boot. I'm tried
also 9.0-CURRENT.

From kernel log I see that problem in mounting of root file system which
placed on RAID0 array. Pseudo-RAID controller no more detected by kernel.
After short investigation was found root of problem. In new releases ATA
cards registered as "atapci" devices. So, "ata-raid" driver in function
'ata_raid_read_metadata' can't find pseudo-raid controller.
After short fix my server successfully booted.
>How-To-Repeat:
Install in server pseudo-raid card and try to find any (previously created)
raid arrays.
>Fix:
In file "ata-raid.c":

static int
ata_raid_read_metadata(device_t subdisk)
{
--    devclass_t pci_devclass = devclass_find("pci");
++    devclass_t pci_devclass = devclass_find("atapci");



>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/159271: commit references a PR
Date: Tue, 15 Jan 2013 02:18:12 +0000 (UTC)

 Author: mav
 Date: Tue Jan 15 02:18:04 2013
 New Revision: 245446
 URL: http://svnweb.freebsd.org/changeset/base/245446
 
 Log:
   In case somebody still use it, fix legacy ataraid(4) to work on combined
   PATA+AHCI controllers, such as JMicron JMB363.
   
   PR:		kern/159271
   MFC after:	1 week
 
 Modified:
   head/sys/dev/ata/ata-raid.c
 
 Modified: head/sys/dev/ata/ata-raid.c
 ==============================================================================
 --- head/sys/dev/ata/ata-raid.c	Tue Jan 15 01:33:19 2013	(r245445)
 +++ head/sys/dev/ata/ata-raid.c	Tue Jan 15 02:18:04 2013	(r245446)
 @@ -1351,10 +1351,11 @@ static int
  ata_raid_read_metadata(device_t subdisk)
  {
      devclass_t pci_devclass = devclass_find("pci");
 +    devclass_t atapci_devclass = devclass_find("atapci");
      devclass_t devclass=device_get_devclass(GRANDPARENT(GRANDPARENT(subdisk)));
  
      /* prioritize vendor native metadata layout if possible */
 -    if (devclass == pci_devclass) {
 +    if (devclass == pci_devclass || devclass == atapci_devclass) {
  	switch (pci_get_vendor(GRANDPARENT(device_get_parent(subdisk)))) {
  	case ATA_HIGHPOINT_ID: 
  	    if (ata_raid_hptv3_read_meta(subdisk, ata_raid_arrays))
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/159271: commit references a PR
Date: Tue, 22 Jan 2013 17:08:27 +0000 (UTC)

 Author: mav
 Date: Tue Jan 22 17:08:09 2013
 New Revision: 245798
 URL: http://svnweb.freebsd.org/changeset/base/245798
 
 Log:
   MFC r245446:
   In case somebody still use it, fix legacy ataraid(4) to work on combined
   PATA+AHCI controllers, such as JMicron JMB363.
   
   PR:		kern/159271
 
 Modified:
   stable/9/sys/dev/ata/ata-raid.c
 Directory Properties:
   stable/9/sys/   (props changed)
   stable/9/sys/dev/   (props changed)
 
 Modified: stable/9/sys/dev/ata/ata-raid.c
 ==============================================================================
 --- stable/9/sys/dev/ata/ata-raid.c	Tue Jan 22 17:06:42 2013	(r245797)
 +++ stable/9/sys/dev/ata/ata-raid.c	Tue Jan 22 17:08:09 2013	(r245798)
 @@ -1351,10 +1351,11 @@ static int
  ata_raid_read_metadata(device_t subdisk)
  {
      devclass_t pci_devclass = devclass_find("pci");
 +    devclass_t atapci_devclass = devclass_find("atapci");
      devclass_t devclass=device_get_devclass(GRANDPARENT(GRANDPARENT(subdisk)));
  
      /* prioritize vendor native metadata layout if possible */
 -    if (devclass == pci_devclass) {
 +    if (devclass == pci_devclass || devclass == atapci_devclass) {
  	switch (pci_get_vendor(GRANDPARENT(device_get_parent(subdisk)))) {
  	case ATA_HIGHPOINT_ID: 
  	    if (ata_raid_hptv3_read_meta(subdisk, ata_raid_arrays))
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: mav 
State-Changed-When: Tue Jan 22 17:22:00 UTC 2013 
State-Changed-Why:  
Fix committed and merged to 8/9-STABLE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159271 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/159271: commit references a PR
Date: Tue, 22 Jan 2013 17:21:21 +0000 (UTC)

 Author: mav
 Date: Tue Jan 22 17:21:08 2013
 New Revision: 245802
 URL: http://svnweb.freebsd.org/changeset/base/245802
 
 Log:
   MFC r245446:
   In case somebody still use it, fix legacy ataraid(4) to work on combined
   PATA+AHCI controllers, such as JMicron JMB363.
   
   PR:		kern/159271
 
 Modified:
   stable/8/sys/dev/ata/ata-raid.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/dev/   (props changed)
   stable/8/sys/dev/ata/   (props changed)
 
 Modified: stable/8/sys/dev/ata/ata-raid.c
 ==============================================================================
 --- stable/8/sys/dev/ata/ata-raid.c	Tue Jan 22 17:19:44 2013	(r245801)
 +++ stable/8/sys/dev/ata/ata-raid.c	Tue Jan 22 17:21:08 2013	(r245802)
 @@ -1351,10 +1351,11 @@ static int
  ata_raid_read_metadata(device_t subdisk)
  {
      devclass_t pci_devclass = devclass_find("pci");
 +    devclass_t atapci_devclass = devclass_find("atapci");
      devclass_t devclass=device_get_devclass(GRANDPARENT(GRANDPARENT(subdisk)));
  
      /* prioritize vendor native metadata layout if possible */
 -    if (devclass == pci_devclass) {
 +    if (devclass == pci_devclass || devclass == atapci_devclass) {
  	switch (pci_get_vendor(GRANDPARENT(device_get_parent(subdisk)))) {
  	case ATA_HIGHPOINT_ID: 
  	    if (ata_raid_hptv3_read_meta(subdisk, ata_raid_arrays))
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
