From nobody@FreeBSD.org  Mon Jul  4 14:05:17 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ACC711065696
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  4 Jul 2011 14:05:17 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id B57108FC1E
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  4 Jul 2011 14:05:16 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p64E5G4x045683
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 4 Jul 2011 14:05:16 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p64E5GwN045682;
	Mon, 4 Jul 2011 14:05:16 GMT
	(envelope-from nobody)
Message-Id: <201107041405.p64E5GwN045682@red.freebsd.org>
Date: Mon, 4 Jul 2011 14:05:16 GMT
From: Robert Millan <rmh@debian.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: if_pfsync.c fails to build when NBPFILTER == 0
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         158636
>Category:       kern
>Synopsis:       [pf] if_pfsync.c fails to build when NBPFILTER == 0
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 04 14:10:09 UTC 2011
>Closed-Date:    Wed Oct 19 14:50:39 UTC 2011
>Last-Modified:  Wed Oct 19 14:50:39 UTC 2011
>Originator:     Robert Millan
>Release:        Debian GNU/kFreeBSD "sid"
>Organization:
>Environment:
>Description:

if_pfsync.c fails to build when NBPFILTER == 0.  It seems that variable 'm' in pfsync_sendout() is only declared when NBPFILTER > 0, but later it is used unconditionally.

gcc-4.6 -c -O -pipe  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign   -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc  -I. -I../../.. -I../../../contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=10000 --param large-function-growth=100000 --param max-inline-insns-single=10000  -fno-pic -mno-abicalls -G0 -march=mips32 -mabi=32 -D__mips_o32 -msoft-float -ffreestanding   ../../../contrib/pf/net/if_pfsync.c -I../../../contrib/pf
In file included from ../../../net/if_var.h:82:0,
                 from ../../../net/if.h:472,
                 from ../../../contrib/pf/net/if_pfsync.c:102:
./../../sys/buf_ring.h: In function 'buf_ring_dequeue_sc':
./../../sys/buf_ring.h:189:33: warning: variable 'cons_next_next' set but not used [-Wunused-but-set-variable]
./../../contrib/pf/net/if_pfsync.c: In function 'pfsync_sendout':
./../../contrib/pf/net/if_pfsync.c:2163:2: error: 'm' undeclared (first use in this function)
./../../contrib/pf/net/if_pfsync.c:2163:2: note: each undeclared identifier is reported only once for each function it appears in
*** Error code 1

Full build log available in:

https://buildd.debian.org/status/fetch.php?pkg=kfreebsd-9&arch=mipsel&ver=9.0~svn223728-1&stamp=1309717094

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-pf 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Jul 5 21:16:49 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158636 
Responsible-Changed-From-To: freebsd-pf->bz 
Responsible-Changed-By: bz 
Responsible-Changed-When: Wed Oct 19 14:40:15 UTC 2011 
Responsible-Changed-Why:  
Take 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158636 
State-Changed-From-To: open->closed 
State-Changed-By: bz 
State-Changed-When: Wed Oct 19 14:50:10 UTC 2011 
State-Changed-Why:  
Seem this was fixed with r224936 already. 
http://svnweb.freebsd.org/base?view=revision&revision=224936 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158636 
>Unformatted:
