From nobody@FreeBSD.org  Tue Jun 28 16:01:17 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 88B49106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 28 Jun 2011 16:01:17 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 790DD8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 28 Jun 2011 16:01:17 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p5SG1Hql057770
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 28 Jun 2011 16:01:17 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p5SG1Hln057769;
	Tue, 28 Jun 2011 16:01:17 GMT
	(envelope-from nobody)
Message-Id: <201106281601.p5SG1Hln057769@red.freebsd.org>
Date: Tue, 28 Jun 2011 16:01:17 GMT
From: Robert Millan <rmh@debian.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: <geom/geom.h> includes <sys/sbuf.h> gratuitously
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         158398
>Category:       kern
>Synopsis:       [headers] [patch] <geom/geom.h> includes <sys/sbuf.h> gratuitously
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-geom
>State:          patched
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 28 16:10:09 UTC 2011
>Closed-Date:    
>Last-Modified:  Thu Jul 14 06:47:35 UTC 2011
>Originator:     Robert Millan
>Release:        Debian GNU/kFreeBSD "sid"
>Organization:
>Environment:
>Description:
<geom/geom.h> includes <sys/sbuf.h> but doesn't really need it, since struct sbuf s treated as an opaque struct in this file.

Please consider removing this include, in Debian this makes life easier since libsbuf is a separate package and may not be available to <geom/geom.h> users.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- a/sys/geom/geom.h
+++ b/sys/geom/geom.h
@@ -43,7 +43,6 @@
 #include <sys/sx.h>
 #include <sys/queue.h>
 #include <sys/ioccom.h>
-#include <sys/sbuf.h>
 #include <sys/module.h>
 
 struct g_class;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-geom 
Responsible-Changed-By: ae 
Responsible-Changed-When: Wed Jun 29 07:21:02 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158398 

From: "Andrey V. Elsukov" <bu7cher@yandex.ru>
To: bug-followup@FreeBSD.org, rmh@debian.org
Cc:  
Subject: Re: kern/158398: [headers] [patch] &lt;geom/geom.h&gt; includes &lt;sys/sbuf.h&gt;
 gratuitously
Date: Sat, 02 Jul 2011 20:52:22 +0400

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enig65B144ED5E03B8970219EADD
 Content-Type: text/plain; charset=KOI8-R
 Content-Transfer-Encoding: quoted-printable
 
 Hi, Robert
 
 I think it is not enough. Actually this patch breaks building of many
 geom kernel modules.
 
 --=20
 WBR, Andrey V. Elsukov
 
 
 --------------enig65B144ED5E03B8970219EADD
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.17 (FreeBSD)
 
 iQEcBAEBAgAGBQJOD0zMAAoJEAHF6gQQyKF6qvYH/03n7UjuMSUImEQ/7FYzjVW/
 cEEcAkZqGugXdV7wxJ5lG/G2AiFhTrdSXE4u8Pq9pYHwc64ta7w5pr6SUyd+lfO2
 PSKBvELRYVquFbhZjtLoHc5uika36jpap61kJ7EwQ3OZXUZ0G7xmk1aRnpN+4Wnd
 mhEJQc49c8vB+1F2g+lfcLvuVHX/bIZ5w716fUOimKl8ynuDpE7qktrgS1CfMjlW
 YMSa1LOzeLEwqbHDyq4V62Ls7ie3+Osggfl1tcZEZUhehRL3dr/RAk4XRKlpPBBW
 cDECTGyzG+cG/Nblex30JPRjty+OyRy5UaahyJpY7CUoP6nXY8D6sVmHvhJ5JZE=
 =R0ME
 -----END PGP SIGNATURE-----
 
 --------------enig65B144ED5E03B8970219EADD--

From: Robert Millan <rmh@debian.org>
To: "Andrey V. Elsukov" <bu7cher@yandex.ru>
Cc: bug-followup@freebsd.org
Subject: Re: kern/158398: [headers] [patch] &lt;geom/geom.h&gt; includes
 &lt;sys/sbuf.h&gt; gratuitously
Date: Sat, 2 Jul 2011 20:52:22 +0200

 2011/7/2 Andrey V. Elsukov <bu7cher@yandex.ru>:
 > Hi, Robert
 >
 > I think it is not enough. Actually this patch breaks building of many
 > geom kernel modules.
 
 Sorry for the oversight.  We test _KERNEL and non-_KERNEL mode with
 different patchsets, so I was only thinking on userland here.  I'll
 have a look at this.
 
 -- 
 Robert Millan

From: Robert Millan <rmh@debian.org>
To: "Andrey V. Elsukov" <bu7cher@yandex.ru>
Cc: bug-followup@freebsd.org
Subject: Re: kern/158398: [headers] [patch] &lt;geom/geom.h&gt; includes
 &lt;sys/sbuf.h&gt; gratuitously
Date: Sun, 3 Jul 2011 12:11:07 +0200

 2011/7/2 Robert Millan <rmh@debian.org>:
 > Sorry for the oversight. =C2=A0We test _KERNEL and non-_KERNEL mode with
 > different patchsets, so I was only thinking on userland here. =C2=A0I'll
 > have a look at this.
 
 Please disregard this request, my proposed change would be too
 intrusive for the benefit it provides.
 
 --=20
 Robert Millan

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/158398: commit references a PR
Date: Mon, 11 Jul 2011 10:02:40 +0000 (UTC)

 Author: ae
 Date: Mon Jul 11 10:02:27 2011
 New Revision: 223930
 URL: http://svn.freebsd.org/changeset/base/223930
 
 Log:
   Remove include of sys/sbuf.h from geom/geom.h.
   sbuf support is not always required for geom/geom.h users, and no need to
   depend from it.
   
   PR:		kern/158398
 
 Modified:
   head/sys/geom/geom.h
 
 Modified: head/sys/geom/geom.h
 ==============================================================================
 --- head/sys/geom/geom.h	Mon Jul 11 08:42:09 2011	(r223929)
 +++ head/sys/geom/geom.h	Mon Jul 11 10:02:27 2011	(r223930)
 @@ -44,7 +44,6 @@
  #include <sys/queue.h>
  #include <sys/ioccom.h>
  #include <sys/conf.h>
 -#include <sys/sbuf.h>
  #include <sys/module.h>
  
  struct g_class;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: ae 
State-Changed-When: Thu Jul 14 06:47:06 UTC 2011 
State-Changed-Why:  
Patched in head/. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=158398 
>Unformatted:
