From nobody@FreeBSD.org  Tue Jun 14 16:30:41 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A256A106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Jun 2011 16:30:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 927FF8FC18
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Jun 2011 16:30:41 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p5EGUfFi037910
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Jun 2011 16:30:41 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p5EGUfqh037909;
	Tue, 14 Jun 2011 16:30:41 GMT
	(envelope-from nobody)
Message-Id: <201106141630.p5EGUfqh037909@red.freebsd.org>
Date: Tue, 14 Jun 2011 16:30:41 GMT
From: Ben Kaduk <kaduk@mit.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: libgeom ABI change without version bump in 8.2
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         157879
>Category:       kern
>Synopsis:       [libgeom] [regression] ABI change without version bump in 8.2
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-geom
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 14 16:40:06 UTC 2011
>Closed-Date:    
>Last-Modified:  Tue Oct 25 11:12:25 UTC 2011
>Originator:     Ben Kaduk
>Release:        8.2
>Organization:
MIT SIPB
>Environment:
n/a
>Description:
The Debian/kFreeBSD folks discovered some issues with their grub breaking upon a move from 8.1 to 8.2; it seems to have been tracked down to an ABI change in libgeom that did not have an accompanying version bump, per
http://svnweb.freebsd.org/base/head/lib/libgeom/libgeom.h?r1=182843&r2=202454
and
http://lists.debian.org/debian-bsd/2011/06/msg00141.html
(and the rest of the traffic on debbug #630107).

I'm reporting it here so it doesn't get lost.
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-geom 
Responsible-Changed-By: ae 
Responsible-Changed-When: Tue Jun 14 17:08:16 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 


http://www.freebsd.org/cgi/query-pr.cgi?pr=157879 

From: Guillem Jover <guillem@debian.org>
To: bug-followup@FreeBSD.org, kaduk@mit.edu
Cc:  
Subject: Re: kern/157879: [libgeom] ABI change without version bump in 8.2
Date: Thu, 16 Jun 2011 11:25:34 +0200

 --mP3DRpeJDSE+ciuQ
 Content-Type: text/plain; charset=utf-8
 Content-Disposition: inline
 Content-Transfer-Encoding: 8bit
 
 Hi!
 
 The ‘struct gprovider’ got two new members in the middle of a public
 struct, so this might cause programs built against the old headers to
 access the wrong member with the new library or the other way around.
 That's exactly what happened to us at least with grub2.
 
 I'm attaching the trivial patch we are using in Debian GNU/kFreeBSD.
 
 thanks,
 guillem
 
 --mP3DRpeJDSE+ciuQ
 Content-Type: text/x-diff; charset=us-ascii
 Content-Disposition: attachment; filename="libgeom_abi_bump.patch"
 
 Index: lib/libgeom/Makefile
 ===================================================================
 --- lib/libgeom/Makefile	(revision 223144)
 +++ lib/libgeom/Makefile	(working copy)
 @@ -1,6 +1,7 @@
  # $FreeBSD$
  
  LIB=	geom
 +SHLIB_MAJOR=	1
  SHLIBDIR?= /lib
  SRCS+=	geom_getxml.c
  SRCS+=	geom_stats.c
 
 --mP3DRpeJDSE+ciuQ--
>Unformatted:
