From eugen@eg.sd.rdtc.ru  Thu Jun  2 16:08:25 2011
Return-Path: <eugen@eg.sd.rdtc.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4B3B9106566C;
	Thu,  2 Jun 2011 16:08:25 +0000 (UTC)
	(envelope-from eugen@eg.sd.rdtc.ru)
Received: from eg.sd.rdtc.ru (unknown [IPv6:2a03:3100:c:13::5])
	by mx1.freebsd.org (Postfix) with ESMTP id 60D468FC0A;
	Thu,  2 Jun 2011 16:08:23 +0000 (UTC)
Received: from eg.sd.rdtc.ru (localhost [127.0.0.1])
	by eg.sd.rdtc.ru (8.14.4/8.14.4) with ESMTP id p52G8Koh041513;
	Thu, 2 Jun 2011 23:08:20 +0700 (NOVST)
	(envelope-from eugen@eg.sd.rdtc.ru)
Received: (from eugen@localhost)
	by eg.sd.rdtc.ru (8.14.4/8.14.4/Submit) id p52G8FXG041512;
	Thu, 2 Jun 2011 23:08:15 +0700 (NOVST)
	(envelope-from eugen)
Message-Id: <201106021608.p52G8FXG041512@eg.sd.rdtc.ru>
Date: Thu, 2 Jun 2011 23:08:15 +0700 (NOVST)
From: Eugene Grosbein <eugen@eg.sd.rdtc.ru>
Reply-To: Eugene Grosbein <eugen@eg.sd.rdtc.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: art@freebsd.org, jhb@freebsd.org, avg@freebsd.org
Subject: [patch] [i386] r222557 broke buildworld with MODULES_WITH_WORLD=yes
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         157529
>Category:       kern
>Synopsis:       [modules] [patch] r222557 broke buildworld with MODULES_WITH_WORLD=yes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    art
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 02 16:10:11 UTC 2011
>Closed-Date:    Mon Aug 08 16:02:06 UTC 2011
>Last-Modified:  Mon Aug 08 16:02:06 UTC 2011
>Originator:     Eugene Grosbein
>Release:        FreeBSD 8.2-STABLE i386
>Organization:
RDTC JSC
>Environment:
System: FreeBSD eg.sd.rdtc.ru 8.2-STABLE FreeBSD 8.2-STABLE #23: Mon May 30 15:53:18 NOVST 2011 root@eg.sd.rdtc.ru:/usr/local/obj/usr/local/src/sys/EG i386

>Description:

	'make MODULES_WITH_WORLD=yes' was fixed in RELENG_8
13 May only with kern/138341 and now it's broken again for i386:

mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE -I/usr/src/sys/modules/dtrace/dtraceall/../../.. -I. -I@ -I@/contrib/altq /usr/src/sys/modules/dtrace/dtraceall/dtraceall.c
/usr/src/sys/modules/dtrace/dtraceall/dtraceall.c:35:24: error: opt_compat.h: No such file or directory

>How-To-Repeat:
	Use FreeBSD 8.2-STABLE/i386:

cd /usr/src && make MODULES_WITH_WORLD=yes buildworld

>Fix:

--- sys/modules/dtrace/dtraceall/Makefile.orig	2011-06-02 22:01:42.000000000 +0700
+++ sys/modules/dtrace/dtraceall/Makefile	2011-06-02 22:02:12.000000000 +0700
@@ -9,6 +9,8 @@
 opt_compat.h:
 .if ${MACHINE_ARCH} == "amd64"
 	echo "#define COMPAT_FREEBSD32 1" >> ${.TARGET}
+.else
+	echo -n >> ${.TARGET}
 .endif
 .endif


Eugene Grosbein
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-i386->art 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Jun 6 05:41:29 UTC 2011 
Responsible-Changed-Why:  
Refers to MFC in: 

http://svnweb.freebsd.org/base/stable/8/sys/modules/dtrace/dtraceall/Makefile?view=markup&pathrev=222557 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157529 

From: Eugene Grosbein <egrosbein@rdtc.ru>
To: bug-followup@FreeBSD.ORG, art@FreeBSD.ORG
Cc:  
Subject: Re: kern/157529: [modules] [patch] r222557 broke buildworld with
 MODULES_WITH_WORLD=yes
Date: Mon, 01 Aug 2011 00:07:03 +0700

 Hi!
 
 Do you plan to deal with this problem?
 If no, please change "Responsible" so this PR may be taken by someone else.
 
 Eugene Grosbein
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/157529: commit references a PR
Date: Mon,  1 Aug 2011 04:29:19 +0000 (UTC)

 Author: art
 Date: Mon Aug  1 04:29:04 2011
 New Revision: 224560
 URL: http://svn.freebsd.org/changeset/base/224560
 
 Log:
   Create dummy opt_compat.h for i386 build to fix buildworld breakage
   when MODULES_WITH_WORLD is set.
   
   PR: 157529
   Submitted by: Eugene Grosbein
   Approved by: avg (mentor)
 
 Modified:
   stable/8/sys/modules/dtrace/dtraceall/Makefile
 
 Modified: stable/8/sys/modules/dtrace/dtraceall/Makefile
 ==============================================================================
 --- stable/8/sys/modules/dtrace/dtraceall/Makefile	Mon Aug  1 02:57:46 2011	(r224559)
 +++ stable/8/sys/modules/dtrace/dtraceall/Makefile	Mon Aug  1 04:29:04 2011	(r224560)
 @@ -9,6 +9,8 @@ CFLAGS+=	-I${.CURDIR}/../../..
  opt_compat.h:
  .if ${MACHINE_ARCH} == "amd64"
  	echo "#define COMPAT_FREEBSD32 1" >> ${.TARGET}
 +.else
 +	echo -n >> ${.TARGET}
  .endif
  .endif
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: art 
State-Changed-When: Mon Aug 8 15:59:34 UTC 2011 
State-Changed-Why:  
Fix has been committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157529 
>Unformatted:
