From mark@trevor.cova-tech.com  Wed Sep  4 15:11:56 1996
Received: from trevor.cova-tech.com ([194.217.109.83])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id PAA05305
          for <FreeBSD-gnats-submit@freebsd.org>; Wed, 4 Sep 1996 15:11:47 -0700 (PDT)
Received: (from mark@localhost) by trevor.cova-tech.com (8.7.5/8.7.3) id XAA00834; Wed, 4 Sep 1996 23:11:03 +0100 (BST)
Message-Id: <199609042211.XAA00834@trevor.cova-tech.com>
Date: Wed, 4 Sep 1996 23:11:03 +0100 (BST)
From: mark@cova-tech.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: panic: ufs_ihashget: recursive lock not expected
X-Send-Pr-Version: 3.2

>Number:         1566
>Category:       kern
>Synopsis:       panic: ufs_ihashget: recursive lock not expected
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep  4 15:20:01 PDT 1996
>Closed-Date:    Thu Sep 5 00:59:41 PDT 1996
>Last-Modified:  Thu Sep  5 01:00:42 PDT 1996
>Originator:     Mark Valentine
>Release:        FreeBSD 2.2-CURRENT i386
>Organization:
Cova Technology
>Environment:

	FreeBSD 2.2-CURRENT, 133MHz Pentium, 256k cache, 32MB parity RAM,
	NCR810 SCSI, 4GB Hawk.

>Description:

	Easily reproducible panic (as synopsis) when listing a directory
	on a FreeBSD NFS server mounted on a Solaris 2.5 client with NFSv3.

>How-To-Repeat:

	I was using file name completion on the client to list the directory.

>Fix:
	
	I found a fix by Doug Rabson in the hackers archive (Subject: NFS
	crash), but it doesn't seem to have been applied.  John Fieber also
	reported on the list that the fix worked for an OSF/1 client.
	Several people reported the panic, but none have so far submitted
	it to GNATS as far as I can see.

	Doug's fix is against rev. 1.30 of sys/nfs/nfs_serv.c; here's a
	version of his fix against against 1.32:

--- nfs_serv.c.ctm	Mon Sep  2 23:44:18 1996
+++ nfs_serv.c	Wed Sep  4 22:55:23 1996
@@ -2899,6 +2899,7 @@
 		nfsm_srvpostop_attr(getret, &at);
 		return (0);
 	}
+	vput(nvp);
 	    
 	dirlen = len = NFSX_V3POSTOPATTR + NFSX_V3COOKIEVERF + 2 * NFSX_UNSIGNED;
 	nfsm_reply(cnt);

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: davidg 
State-Changed-When: Thu Sep 5 00:59:41 PDT 1996 
State-Changed-Why:  
Doug Rabson's patch was applied. Thanks for bringing the issue up 
again. 
>Unformatted:
