From david@catwhisker.org  Fri Apr 22 16:08:30 2011
Return-Path: <david@catwhisker.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 41A611065672
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 Apr 2011 16:08:30 +0000 (UTC)
	(envelope-from david@catwhisker.org)
Received: from albert.catwhisker.org (m209-73.dsl.rawbw.com [198.144.209.73])
	by mx1.freebsd.org (Postfix) with ESMTP id 1FDE48FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 Apr 2011 16:08:29 +0000 (UTC)
Received: from albert.catwhisker.org (localhost [127.0.0.1])
	by albert.catwhisker.org (8.14.4/8.14.4) with ESMTP id p3MG8TBc042831
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 Apr 2011 09:08:29 -0700 (PDT)
	(envelope-from david@albert.catwhisker.org)
Received: (from david@localhost)
	by albert.catwhisker.org (8.14.4/8.14.4/Submit) id p3MG8T6k042830;
	Fri, 22 Apr 2011 09:08:29 -0700 (PDT)
	(envelope-from david)
Message-Id: <201104221608.p3MG8T6k042830@albert.catwhisker.org>
Date: Fri, 22 Apr 2011 09:08:29 -0700 (PDT)
From: David Wolfskill <david@catwhisker.org>
Reply-To: David Wolfskill <david@catwhisker.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Tweak to Makefile.in to document which kernel is installed
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         156579
>Category:       kern
>Synopsis:       Tweak to Makefile.in to document which kernel is installed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    obrien
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 22 16:10:09 UTC 2011
>Closed-Date:    Mon May 09 23:47:58 UTC 2011
>Last-Modified:  Tue Nov 15 23:50:07 UTC 2011
>Originator:     David Wolfskill
>Release:        FreeBSD 9.0-CURRENT i386
>Organization:
Wolfskill & Dowlng Residence
>Environment:
System: FreeBSD g1-222.catwhisker.org. 9.0-CURRENT FreeBSD 9.0-CURRENT #208 r220945: Fri Apr 22 05:26:37 PDT 2011     root@g1-220.catwhisker.org.:/usr/obj/usr/src/sys/CANARY  i386

>Description:
	Performing "make kernel" (or "make buildkernel installkernel")
	causes various "progress messages" to be logged at certain
	"milestone" events in the course of the build/install.

	Some of them mention (for example) which kernel configuration
	file is being used for the kernel build, e.g.:

	>>> Kernel build for CANARY started on Fri Apr 22 05:16:35 PDT 2011
	...
	>>> Kernel build for CANARY completed on Fri Apr 22 05:38:52 PDT 2011

	This is sometimes useful, and at worst, nearly harmless.

	The corresponding message for the installation of the kernel,
	however, merely reads:

	>>> Installing kernel

	While that's better than nothing, and it's actually quite
	adequate for machines that build a single kernel image, for
	machines that are used to build other kernels, or for their
	"clients" -- machines that install kernels that they don't build
	-- I believe it would be a bit more useful to augment the above
	to read (e.g.):

	>>> Installing kernel CANARY

	(This could be augmented with a time stamp and/or the name of
	the directory in /boot where it is being installed, but I see
	those as not quite as important  -- so I've restricted the scope
	of this PR.)

>How-To-Repeat:
	Build & install some kernels.  Here are some excerpts from my
	build machine:

	>>> Kernel build for GENERIC started on Fri Apr 22 04:17:35 PDT 2011
	>>> Kernel build for GENERIC completed on Fri Apr 22 04:19:46 PDT 2011
	>>> Kernel build for ALBERT started on Fri Apr 22 04:19:46 PDT 2011
	>>> Kernel build for ALBERT completed on Fri Apr 22 04:21:45 PDT 2011
	>>> Kernel build for JANUS started on Fri Apr 22 04:21:45 PDT 2011
	>>> Kernel build for JANUS completed on Fri Apr 22 04:23:40 PDT 2011
	>>> Installing kernel

	And here's a corresponding excerpt from one of its clients:

	>>> Installing kernel


	And from the other of its clients:

	>>> Installing kernel

	I think that augmenting the "Installing kernel" to mention
	which kernel config was being installed on which machine might
	be useful for other folks, not just me.  :-}
>Fix:

	For the request being made:
Index: Makefile.inc1
===================================================================
--- Makefile.inc1	(revision 220945)
+++ Makefile.inc1	(working copy)
@@ -868,7 +868,7 @@
 	false
 .endif
 	@echo "--------------------------------------------------------------"
-	@echo ">>> Installing kernel"
+	@echo ">>> Installing kernel ${KERNCONF}"
 	@echo "--------------------------------------------------------------"
 	cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \
 	    ${CROSSENV} PATH=${TMPPATH} \

	For a rather more elaborate approach
Index: Makefile.inc1
===================================================================
--- Makefile.inc1	(revision 220945)
+++ Makefile.inc1	(working copy)
@@ -868,7 +868,7 @@
 	false
 .endif
 	@echo "--------------------------------------------------------------"
-	@echo ">>> Installing kernel"
+	@echo ">>> Installing kernel ${KERNCONF} as ${INSTALLKERNEL} on `LC_ALL=C date`"
 	@echo "--------------------------------------------------------------"
 	cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \
 	    ${CROSSENV} PATH=${TMPPATH} \

>Release-Note:
>Audit-Trail:

From: Alexander Best <arundel@freebsd.org>
To: David Wolfskill <david@catwhisker.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: kern/156579: Tweak to Makefile.in to document which kernel is installed
Date: Fri, 22 Apr 2011 16:18:28 +0000

 On Fri Apr 22 11, David Wolfskill wrote:
 > 
 > >Number:         156579
 > >Category:       kern
 > >Synopsis:       Tweak to Makefile.in to document which kernel is installed
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    freebsd-bugs
 > >State:          open
 > >Quarter:        
 > >Keywords:       
 > >Date-Required:
 > >Class:          change-request
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Fri Apr 22 16:10:09 UTC 2011
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     David Wolfskill
 > >Release:        FreeBSD 9.0-CURRENT i386
 > >Organization:
 > Wolfskill & Dowlng Residence
 > >Environment:
 > System: FreeBSD g1-222.catwhisker.org. 9.0-CURRENT FreeBSD 9.0-CURRENT #208 r220945: Fri Apr 22 05:26:37 PDT 2011     root@g1-220.catwhisker.org.:/usr/obj/usr/src/sys/CANARY  i386
 > 
 > >Description:
 > 	Performing "make kernel" (or "make buildkernel installkernel")
 > 	causes various "progress messages" to be logged at certain
 > 	"milestone" events in the course of the build/install.
 > 
 > 	Some of them mention (for example) which kernel configuration
 > 	file is being used for the kernel build, e.g.:
 > 
 > 	>>> Kernel build for CANARY started on Fri Apr 22 05:16:35 PDT 2011
 > 	...
 > 	>>> Kernel build for CANARY completed on Fri Apr 22 05:38:52 PDT 2011
 > 
 > 	This is sometimes useful, and at worst, nearly harmless.
 > 
 > 	The corresponding message for the installation of the kernel,
 > 	however, merely reads:
 > 
 > 	>>> Installing kernel
 > 
 > 	While that's better than nothing, and it's actually quite
 > 	adequate for machines that build a single kernel image, for
 > 	machines that are used to build other kernels, or for their
 > 	"clients" -- machines that install kernels that they don't build
 > 	-- I believe it would be a bit more useful to augment the above
 > 	to read (e.g.):
 > 
 > 	>>> Installing kernel CANARY
 > 
 > 	(This could be augmented with a time stamp and/or the name of
 > 	the directory in /boot where it is being installed, but I see
 > 	those as not quite as important  -- so I've restricted the scope
 > 	of this PR.)
 > 
 > >How-To-Repeat:
 > 	Build & install some kernels.  Here are some excerpts from my
 > 	build machine:
 > 
 > 	>>> Kernel build for GENERIC started on Fri Apr 22 04:17:35 PDT 2011
 > 	>>> Kernel build for GENERIC completed on Fri Apr 22 04:19:46 PDT 2011
 > 	>>> Kernel build for ALBERT started on Fri Apr 22 04:19:46 PDT 2011
 > 	>>> Kernel build for ALBERT completed on Fri Apr 22 04:21:45 PDT 2011
 > 	>>> Kernel build for JANUS started on Fri Apr 22 04:21:45 PDT 2011
 > 	>>> Kernel build for JANUS completed on Fri Apr 22 04:23:40 PDT 2011
 > 	>>> Installing kernel
 > 
 > 	And here's a corresponding excerpt from one of its clients:
 > 
 > 	>>> Installing kernel
 > 
 > 
 > 	And from the other of its clients:
 > 
 > 	>>> Installing kernel
 > 
 > 	I think that augmenting the "Installing kernel" to mention
 > 	which kernel config was being installed on which machine might
 > 	be useful for other folks, not just me.  :-}
 > >Fix:
 
 +1
 
 personally i favour the first patch. in order to be consistent with
 target buildkernel, we would have to introduce a
 
 installing kernel XXX as YYY started on $date
 installing kernel XXX as YYY completed on $date
 
 i think that's a bit overkill for target installkernel. also displaying the
 time and date when the kernel starts installing doesn't make that much sense,
 since it will be almost equal to the date/time target buildkernel completes.
 
 cheers.
 alex
 
 > 
 > 	For the request being made:
 > Index: Makefile.inc1
 > ===================================================================
 > --- Makefile.inc1	(revision 220945)
 > +++ Makefile.inc1	(working copy)
 > @@ -868,7 +868,7 @@
 >  	false
 >  .endif
 >  	@echo "--------------------------------------------------------------"
 > -	@echo ">>> Installing kernel"
 > +	@echo ">>> Installing kernel ${KERNCONF}"
 >  	@echo "--------------------------------------------------------------"
 >  	cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \
 >  	    ${CROSSENV} PATH=${TMPPATH} \
 > 
 > 	For a rather more elaborate approach
 > Index: Makefile.inc1
 > ===================================================================
 > --- Makefile.inc1	(revision 220945)
 > +++ Makefile.inc1	(working copy)
 > @@ -868,7 +868,7 @@
 >  	false
 >  .endif
 >  	@echo "--------------------------------------------------------------"
 > -	@echo ">>> Installing kernel"
 > +	@echo ">>> Installing kernel ${KERNCONF} as ${INSTALLKERNEL} on `LC_ALL=C date`"
 >  	@echo "--------------------------------------------------------------"
 >  	cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \
 >  	    ${CROSSENV} PATH=${TMPPATH} \
 > 
 > >Release-Note:
 > >Audit-Trail:
 > >Unformatted:
 
 -- 
 a13x
State-Changed-From-To: open->closed 
State-Changed-By: obrien 
State-Changed-When: Fri Apr 22 17:11:44 UTC 2011 
State-Changed-Why:  
Committed.  Thanks! 


Responsible-Changed-From-To: freebsd-bugs->obrien 
Responsible-Changed-By: obrien 
Responsible-Changed-When: Fri Apr 22 17:11:44 UTC 2011 
Responsible-Changed-Why:  
Committed.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156579 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/156579: commit references a PR
Date: Fri, 22 Apr 2011 17:11:13 +0000 (UTC)

 Author: obrien
 Date: Fri Apr 22 17:10:51 2011
 New Revision: 220954
 URL: http://svn.freebsd.org/changeset/base/220954
 
 Log:
   Note which of the built kernels is being installed.
   
   PR:		156579
   Submitted by:	dhw
 
 Modified:
   head/Makefile.inc1
 
 Modified: head/Makefile.inc1
 ==============================================================================
 --- head/Makefile.inc1	Fri Apr 22 14:42:42 2011	(r220953)
 +++ head/Makefile.inc1	Fri Apr 22 17:10:51 2011	(r220954)
 @@ -868,7 +868,7 @@ reinstallkernel reinstallkernel.debug: i
  	false
  .endif
  	@echo "--------------------------------------------------------------"
 -	@echo ">>> Installing kernel"
 +	@echo ">>> Installing kernel ${KERNCONF}"
  	@echo "--------------------------------------------------------------"
  	cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \
  	    ${CROSSENV} PATH=${TMPPATH} \
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: closed->open 
State-Changed-By: obrien 
State-Changed-When: Wed May 4 17:00:46 UTC 2011 
State-Changed-Why:  
David found a bug in his change. 


Responsible-Changed-From-To: obrien->dhw 
Responsible-Changed-By: obrien 
Responsible-Changed-When: Wed May 4 17:00:46 UTC 2011 
Responsible-Changed-Why:  
David found a bug in his change. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156579 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/156579: commit references a PR
Date: Thu,  5 May 2011 00:44:10 +0000 (UTC)

 Author: obrien
 Date: Thu May  5 00:43:55 2011
 New Revision: 221469
 URL: http://svn.freebsd.org/changeset/base/221469
 
 Log:
   Correct the kernel config name printed out during install.
   
   PR:		156579
   Submitted by:	dhw
 
 Modified:
   head/Makefile.inc1
 
 Modified: head/Makefile.inc1
 ==============================================================================
 --- head/Makefile.inc1	Thu May  5 00:43:40 2011	(r221468)
 +++ head/Makefile.inc1	Thu May  5 00:43:55 2011	(r221469)
 @@ -868,7 +868,7 @@ reinstallkernel reinstallkernel.debug: i
  	false
  .endif
  	@echo "--------------------------------------------------------------"
 -	@echo ">>> Installing kernel ${KERNCONF}"
 +	@echo ">>> Installing kernel ${INSTALLKERNEL}"
  	@echo "--------------------------------------------------------------"
  	cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \
  	    ${CROSSENV} PATH=${TMPPATH} \
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->feedback 
State-Changed-By: arundel 
State-Changed-When: Mon May 9 20:57:08 UTC 2011 
State-Changed-Why:  
Can this PR be closed now? Revision 221469 seems to have fixed the issue. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156579 
State-Changed-From-To: feedback->patched 
State-Changed-By: arundel 
State-Changed-When: Mon May 9 21:15:27 UTC 2011 
State-Changed-Why:  
Patched in HEAD (r221469). Keep the PR in patched state, since this is a good 
candidate to be MFC'ed to stable/8 (as discussed with dhw@). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156579 
State-Changed-From-To: patched->closed 
State-Changed-By: obrien 
State-Changed-When: Mon May 9 23:47:22 UTC 2011 
State-Changed-Why:  
mfc'ed 


Responsible-Changed-From-To: dhw->obrien 
Responsible-Changed-By: obrien 
Responsible-Changed-When: Mon May 9 23:47:22 UTC 2011 
Responsible-Changed-Why:  
mfc'ed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=156579 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/156579: commit references a PR
Date: Tue, 15 Nov 2011 23:46:45 +0000 (UTC)

 Author: obrien
 Date: Tue Nov 15 23:46:25 2011
 New Revision: 227545
 URL: http://svn.freebsd.org/changeset/base/227545
 
 Log:
   MFC: r220954 & r221469: Note which of the built kernels is being installed.
   PR: 156579
 
 Modified:
   stable/8/Makefile.inc1   (contents, props changed)
 Directory Properties:
   stable/8/   (props changed)
 
 Modified: stable/8/Makefile.inc1
 ==============================================================================
 --- stable/8/Makefile.inc1	Tue Nov 15 23:37:15 2011	(r227544)
 +++ stable/8/Makefile.inc1	Tue Nov 15 23:46:25 2011	(r227545)
 @@ -813,7 +813,7 @@ reinstallkernel reinstallkernel.debug: i
  	false
  .endif
  	@echo "--------------------------------------------------------------"
 -	@echo ">>> Installing kernel"
 +	@echo ">>> Installing kernel ${INSTALLKERNEL}"
  	@echo "--------------------------------------------------------------"
  	cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \
  	    ${CROSSENV} PATH=${TMPPATH} \
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
