From nobody@FreeBSD.org  Sat Mar 26 00:53:49 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 38F6E1065670
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 26 Mar 2011 00:53:49 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 2975C8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 26 Mar 2011 00:53:49 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p2Q0rmvK030683
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 26 Mar 2011 00:53:48 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p2Q0rm3T030681;
	Sat, 26 Mar 2011 00:53:48 GMT
	(envelope-from nobody)
Message-Id: <201103260053.p2Q0rm3T030681@red.freebsd.org>
Date: Sat, 26 Mar 2011 00:53:48 GMT
From: KOIE Hidetaka <koie@suri.co.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: zfs list /filesystem does not work.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         155940
>Category:       kern
>Synopsis:       [libzfs] [patch] zfs list /filesystem does not work.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pjd
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 26 01:00:23 UTC 2011
>Closed-Date:    Tue Apr 12 20:32:15 UTC 2011
>Last-Modified:  Tue Apr 12 20:40:10 UTC 2011
>Originator:     KOIE Hidetaka
>Release:        9.0-CURRENT
>Organization:
surigiken
>Environment:
FreeBSD guriandgura 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r219849+1716dd734afd,ver-hg,nice-powerd: Tue Mar 22 08:39:13 JST 2011     root@guriandgura:/usr/obj/usr/src/sys/GURIANDGURA  amd64
>Description:
zfs command does not accept abs path to filesystem.
>How-To-Repeat:
% zfs list tank
NAME   USED  AVAIL  REFER  MOUNTPOINT
tank   579G   721G  28.0K  /tank
% zfs list /tank
% echo $?
1
%
>Fix:
uninitialized variable is referred.


Patch attached with submission follows:

# HG changeset patch
# Parent a0c65997b71068c634e0d1730238aaa72fc1905e
diff --git a/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c b/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c
--- a/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c
+++ b/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c
@@ -734,6 +734,7 @@
 	{
 		struct statfs sfs;
 
+		ret = 0; // XXX KOIE
 		if (statfs(path, &sfs) != 0) {
 			(void) fprintf(stderr, "%s: %s\n", path,
 			    strerror(errno));


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Apr 9 19:34:06 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155940 
State-Changed-From-To: open->closed 
State-Changed-By: pjd 
State-Changed-When: wto 12 kwi 2011 20:31:13 UTC 
State-Changed-Why:  
Fix committed to HEAD, thanks! 


Responsible-Changed-From-To: freebsd-fs->pjd 
Responsible-Changed-By: pjd 
Responsible-Changed-When: wto 12 kwi 2011 20:31:13 UTC 
Responsible-Changed-Why:  
I'll take this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155940 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/155940: commit references a PR
Date: Tue, 12 Apr 2011 20:31:42 +0000 (UTC)

 Author: pjd
 Date: Tue Apr 12 20:31:33 2011
 New Revision: 220575
 URL: http://svn.freebsd.org/changeset/base/220575
 
 Log:
   Fix 'zfs list <path>' handling. If the path was found, the 'ret' variable was
   uninitialized.
   
   PR:		kern/155940
   Submitted by:	KOIE Hidetaka <koie@suri.co.jp>
   MFC after:	1 week
 
 Modified:
   head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c
 
 Modified: head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c
 ==============================================================================
 --- head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c	Tue Apr 12 20:10:15 2011	(r220574)
 +++ head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c	Tue Apr 12 20:31:33 2011	(r220575)
 @@ -734,12 +734,13 @@ zfs_path_to_zhandle(libzfs_handle_t *hdl
  	{
  		struct statfs sfs;
  
 -		if (statfs(path, &sfs) != 0) {
 +		ret = statfs(path, &sfs);
 +		if (ret == 0)
 +			statfs2mnttab(&sfs, &entry);
 +		else {
  			(void) fprintf(stderr, "%s: %s\n", path,
  			    strerror(errno));
 -			ret = -1;
  		}
 -		statfs2mnttab(&sfs, &entry);
  	}
  #endif	/* sun */
  	if (ret != 0) {
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
