From nobody@FreeBSD.org  Sat Mar 12 14:43:29 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 80E79106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Mar 2011 14:43:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 6EBEC8FC18
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Mar 2011 14:43:29 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p2CEhTS7099549
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Mar 2011 14:43:29 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p2CEhTrk099545;
	Sat, 12 Mar 2011 14:43:29 GMT
	(envelope-from nobody)
Message-Id: <201103121443.p2CEhTrk099545@red.freebsd.org>
Date: Sat, 12 Mar 2011 14:43:29 GMT
From: Galimov Albert <wtfcrap@mail.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [sysctl][patch] Document some sys/vm sysctls
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         155490
>Category:       kern
>Synopsis:       [sysctl][patch] Document some sys/vm sysctls
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 12 14:50:11 UTC 2011
>Closed-Date:    Thu Mar 22 03:40:59 UTC 2012
>Last-Modified:  Thu Mar 22 03:40:59 UTC 2012
>Originator:     Galimov Albert
>Release:        FreeBSD 9.0-CURRENT #0 r219510
>Organization:
>Environment:
>Description:
Working on documenting sysctls

>How-To-Repeat:

>Fix:
Patch included

Patch attached with submission follows:

Index: sys/vm/vm_meter.c
===================================================================
--- sys/vm/vm_meter.c	(revision 219510)
+++ sys/vm/vm_meter.c	(working copy)
@@ -55,21 +55,21 @@
 struct vmmeter cnt;
 
 SYSCTL_UINT(_vm, VM_V_FREE_MIN, v_free_min,
-	CTLFLAG_RW, &cnt.v_free_min, 0, "");
+	CTLFLAG_RW, &cnt.v_free_min, 0, "minimum low-free-pages threshold");
 SYSCTL_UINT(_vm, VM_V_FREE_TARGET, v_free_target,
-	CTLFLAG_RW, &cnt.v_free_target, 0, "");
+	CTLFLAG_RW, &cnt.v_free_target, 0, "pages desired free");
 SYSCTL_UINT(_vm, VM_V_FREE_RESERVED, v_free_reserved,
-	CTLFLAG_RW, &cnt.v_free_reserved, 0, "");
+	CTLFLAG_RW, &cnt.v_free_reserved, 0, "pages reserved for deadlock");
 SYSCTL_UINT(_vm, VM_V_INACTIVE_TARGET, v_inactive_target,
-	CTLFLAG_RW, &cnt.v_inactive_target, 0, "");
+	CTLFLAG_RW, &cnt.v_inactive_target, 0, "pages desired inactive");
 SYSCTL_UINT(_vm, VM_V_CACHE_MIN, v_cache_min,
-	CTLFLAG_RW, &cnt.v_cache_min, 0, "");
+	CTLFLAG_RW, &cnt.v_cache_min, 0, "min pages desired on cache queue");
 SYSCTL_UINT(_vm, VM_V_CACHE_MAX, v_cache_max,
-	CTLFLAG_RW, &cnt.v_cache_max, 0, "");
+	CTLFLAG_RW, &cnt.v_cache_max, 0, "max pages in cached obj");
 SYSCTL_UINT(_vm, VM_V_PAGEOUT_FREE_MIN, v_pageout_free_min,
-	CTLFLAG_RW, &cnt.v_pageout_free_min, 0, "");
+	CTLFLAG_RW, &cnt.v_pageout_free_min, 0, "min pages reserved for kernel");
 SYSCTL_UINT(_vm, OID_AUTO, v_free_severe,
-	CTLFLAG_RW, &cnt.v_free_severe, 0, "");
+	CTLFLAG_RW, &cnt.v_free_severe, 0, "severe page depletion point");
 
 static int
 sysctl_vm_loadavg(SYSCTL_HANDLER_ARGS)
@@ -320,41 +320,41 @@
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_tcached, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 	&cnt.v_tcached, 0, vcnt, "IU", "Total pages cached");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_dfree, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_dfree, 0, vcnt, "IU", "");
+	&cnt.v_dfree, 0, vcnt, "IU", "pages freed by daemon");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_pfree, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_pfree, 0, vcnt, "IU", "");
+	&cnt.v_pfree, 0, vcnt, "IU", "pages freed by exiting processes");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_tfree, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_tfree, 0, vcnt, "IU", "");
+	&cnt.v_tfree, 0, vcnt, "IU", "total pages freed");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_page_size, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_page_size, 0, vcnt, "IU", "");
+	&cnt.v_page_size, 0, vcnt, "IU", "page size in bytes");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_page_count, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_page_count, 0, vcnt, "IU", "");
+	&cnt.v_page_count, 0, vcnt, "IU", "total number of pages in system");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_free_reserved, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_free_reserved, 0, vcnt, "IU", "");
+	&cnt.v_free_reserved, 0, vcnt, "IU", "pages reserved for deadlock");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_free_target, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_free_target, 0, vcnt, "IU", "");
+	&cnt.v_free_target, 0, vcnt, "IU", "pages desired free");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_free_min, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_free_min, 0, vcnt, "IU", "");
+	&cnt.v_free_min, 0, vcnt, "IU", "minimum low-free-pages threshold");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_free_count, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_free_count, 0, vcnt, "IU", "");
+	&cnt.v_free_count, 0, vcnt, "IU", "pages free");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_wire_count, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_wire_count, 0, vcnt, "IU", "");
+	&cnt.v_wire_count, 0, vcnt, "IU", "pages wired down");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_active_count, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_active_count, 0, vcnt, "IU", "");
+	&cnt.v_active_count, 0, vcnt, "IU", "pages active");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_inactive_target, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_inactive_target, 0, vcnt, "IU", "");
+	&cnt.v_inactive_target, 0, vcnt, "IU", "pages desired inactive");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_inactive_count, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_inactive_count, 0, vcnt, "IU", "");
+	&cnt.v_inactive_count, 0, vcnt, "IU", "pages inactive");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_cache_count, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_cache_count, 0, vcnt, "IU", "");
+	&cnt.v_cache_count, 0, vcnt, "IU", "pages on cache queue");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_cache_min, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_cache_min, 0, vcnt, "IU", "");
+	&cnt.v_cache_min, 0, vcnt, "IU", "min pages desired on cache queue");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_cache_max, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_cache_max, 0, vcnt, "IU", "");
+	&cnt.v_cache_max, 0, vcnt, "IU", "max pages in cached obj");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_pageout_free_min, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_pageout_free_min, 0, vcnt, "IU", "");
+	&cnt.v_pageout_free_min, 0, vcnt, "IU", "min pages reserved for kernel");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_interrupt_free_min, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
-	&cnt.v_interrupt_free_min, 0, vcnt, "IU", "");
+	&cnt.v_interrupt_free_min, 0, vcnt, "IU", "reserved pages for interrupt code");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_forks, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 	&cnt.v_forks, 0, vcnt, "IU", "Number of fork() calls");
 SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_vforks, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
@@ -373,4 +373,4 @@
 	&cnt.v_kthreadpages, 0, vcnt, "IU", "VM pages affected by fork() by kernel");
 
 SYSCTL_INT(_vm_stats_misc, OID_AUTO,
-	zero_page_count, CTLFLAG_RD, &vm_page_zero_count, 0, "");
+	zero_page_count, CTLFLAG_RD, &vm_page_zero_count, 0, "Number of zero-ed free pages");


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Tue Dec 6 07:10:56 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155490 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/155490: commit references a PR
Date: Tue, 13 Dec 2011 00:39:06 +0000 (UTC)

 Author: eadler (ports committer)
 Date: Tue Dec 13 00:38:50 2011
 New Revision: 228449
 URL: http://svn.freebsd.org/changeset/base/228449
 
 Log:
   Document a large number of currently undocumented sysctls. While here
   fix some style(9) issues and reduce redundancy.
   
   PR:		kern/155491
   PR:		kern/155490
   PR:		kern/155489
   Submitted by:	Galimov Albert <wtfcrap@mail.ru>
   Approved by:	bde
   Reviewed by:	jhb
   MFC after:	1 week
 
 Modified:
   head/sys/dev/md/md.c
   head/sys/kern/kern_ntptime.c
   head/sys/kern/kern_shutdown.c
   head/sys/kern/kern_thr.c
   head/sys/kern/uipc_sockbuf.c
   head/sys/kern/vfs_syscalls.c
   head/sys/vm/vm_meter.c
 
 Modified: head/sys/dev/md/md.c
 ==============================================================================
 --- head/sys/dev/md/md.c	Mon Dec 12 23:29:32 2011	(r228448)
 +++ head/sys/dev/md/md.c	Tue Dec 13 00:38:50 2011	(r228449)
 @@ -105,9 +105,11 @@ static MALLOC_DEFINE(M_MD, "md_disk", "M
  static MALLOC_DEFINE(M_MDSECT, "md_sectors", "Memory Disk Sectors");
  
  static int md_debug;
 -SYSCTL_INT(_debug, OID_AUTO, mddebug, CTLFLAG_RW, &md_debug, 0, "");
 +SYSCTL_INT(_debug, OID_AUTO, mddebug, CTLFLAG_RW, &md_debug, 0,
 +    "Enable md(4) debug messages");
  static int md_malloc_wait;
 -SYSCTL_INT(_vm, OID_AUTO, md_malloc_wait, CTLFLAG_RW, &md_malloc_wait, 0, "");
 +SYSCTL_INT(_vm, OID_AUTO, md_malloc_wait, CTLFLAG_RW, &md_malloc_wait, 0,
 +    "Allow malloc to wait for memory allocations");
  
  #if defined(MD_ROOT) && defined(MD_ROOT_SIZE)
  /*
 
 Modified: head/sys/kern/kern_ntptime.c
 ==============================================================================
 --- head/sys/kern/kern_ntptime.c	Mon Dec 12 23:29:32 2011	(r228448)
 +++ head/sys/kern/kern_ntptime.c	Tue Dec 13 00:38:50 2011	(r228449)
 @@ -301,13 +301,17 @@ SYSCTL_PROC(_kern_ntp_pll, OID_AUTO, get
  	0, sizeof(struct ntptimeval) , ntp_sysctl, "S,ntptimeval", "");
  
  #ifdef PPS_SYNC
 -SYSCTL_INT(_kern_ntp_pll, OID_AUTO, pps_shiftmax, CTLFLAG_RW, &pps_shiftmax, 0, "");
 -SYSCTL_INT(_kern_ntp_pll, OID_AUTO, pps_shift, CTLFLAG_RW, &pps_shift, 0, "");
 +SYSCTL_INT(_kern_ntp_pll, OID_AUTO, pps_shiftmax, CTLFLAG_RW,
 +    &pps_shiftmax, 0, "Max interval duration (sec) (shift)");
 +SYSCTL_INT(_kern_ntp_pll, OID_AUTO, pps_shift, CTLFLAG_RW,
 +    &pps_shift, 0, "Interval duration (sec) (shift)");
  SYSCTL_LONG(_kern_ntp_pll, OID_AUTO, time_monitor, CTLFLAG_RD,
 -    &time_monitor, 0, "");
 +    &time_monitor, 0, "Last time offset scaled (ns)");
  
 -SYSCTL_OPAQUE(_kern_ntp_pll, OID_AUTO, pps_freq, CTLFLAG_RD, &pps_freq, sizeof(pps_freq), "I", "");
 -SYSCTL_OPAQUE(_kern_ntp_pll, OID_AUTO, time_freq, CTLFLAG_RD, &time_freq, sizeof(time_freq), "I", "");
 +SYSCTL_OPAQUE(_kern_ntp_pll, OID_AUTO, pps_freq, CTLFLAG_RD,
 +    &pps_freq, sizeof(pps_freq), "I", "Scaled frequency offset (ns/sec)");
 +SYSCTL_OPAQUE(_kern_ntp_pll, OID_AUTO, time_freq, CTLFLAG_RD,
 +    &time_freq, sizeof(time_freq), "I", "Frequency offset (ns/sec)");
  #endif
  
  /*
 
 Modified: head/sys/kern/kern_shutdown.c
 ==============================================================================
 --- head/sys/kern/kern_shutdown.c	Mon Dec 12 23:29:32 2011	(r228448)
 +++ head/sys/kern/kern_shutdown.c	Tue Dec 13 00:38:50 2011	(r228449)
 @@ -651,7 +651,7 @@ panic(const char *fmt, ...)
  static int poweroff_delay = POWEROFF_DELAY;
  
  SYSCTL_INT(_kern_shutdown, OID_AUTO, poweroff_delay, CTLFLAG_RW,
 -	&poweroff_delay, 0, "");
 +    &poweroff_delay, 0, "Delay before poweroff to write disk caches (msec)");
  
  static void
  poweroff_wait(void *junk, int howto)
 @@ -671,7 +671,7 @@ poweroff_wait(void *junk, int howto)
   */
  static int kproc_shutdown_wait = 60;
  SYSCTL_INT(_kern_shutdown, OID_AUTO, kproc_shutdown_wait, CTLFLAG_RW,
 -    &kproc_shutdown_wait, 0, "");
 +    &kproc_shutdown_wait, 0, "Max wait time (sec) to stop for each process");
  
  void
  kproc_shutdown(void *arg, int howto)
 
 Modified: head/sys/kern/kern_thr.c
 ==============================================================================
 --- head/sys/kern/kern_thr.c	Mon Dec 12 23:29:32 2011	(r228448)
 +++ head/sys/kern/kern_thr.c	Tue Dec 13 00:38:50 2011	(r228449)
 @@ -63,11 +63,11 @@ static SYSCTL_NODE(_kern, OID_AUTO, thre
  
  static int max_threads_per_proc = 1500;
  SYSCTL_INT(_kern_threads, OID_AUTO, max_threads_per_proc, CTLFLAG_RW,
 -	&max_threads_per_proc, 0, "Limit on threads per proc");
 +    &max_threads_per_proc, 0, "Limit on threads per proc");
  
  static int max_threads_hits;
  SYSCTL_INT(_kern_threads, OID_AUTO, max_threads_hits, CTLFLAG_RD,
 -	&max_threads_hits, 0, "");
 +    &max_threads_hits, 0, "kern.threads.max_threads_per_proc hit count");
  
  #ifdef COMPAT_FREEBSD32
  
 
 Modified: head/sys/kern/uipc_sockbuf.c
 ==============================================================================
 --- head/sys/kern/uipc_sockbuf.c	Mon Dec 12 23:29:32 2011	(r228448)
 +++ head/sys/kern/uipc_sockbuf.c	Tue Dec 13 00:38:50 2011	(r228449)
 @@ -1048,4 +1048,4 @@ SYSCTL_INT(_kern, KERN_DUMMY, dummy, CTL
  SYSCTL_OID(_kern_ipc, KIPC_MAXSOCKBUF, maxsockbuf, CTLTYPE_ULONG|CTLFLAG_RW,
      &sb_max, 0, sysctl_handle_sb_max, "LU", "Maximum socket buffer size");
  SYSCTL_ULONG(_kern_ipc, KIPC_SOCKBUF_WASTE, sockbuf_waste_factor, CTLFLAG_RW,
 -    &sb_efficiency, 0, "");
 +    &sb_efficiency, 0, "Socket buffer size waste factor");
 
 Modified: head/sys/kern/vfs_syscalls.c
 ==============================================================================
 --- head/sys/kern/vfs_syscalls.c	Mon Dec 12 23:29:32 2011	(r228448)
 +++ head/sys/kern/vfs_syscalls.c	Tue Dec 13 00:38:50 2011	(r228449)
 @@ -880,7 +880,8 @@ chroot_refuse_vdir_fds(fdp)
  static int chroot_allow_open_directories = 1;
  
  SYSCTL_INT(_kern, OID_AUTO, chroot_allow_open_directories, CTLFLAG_RW,
 -     &chroot_allow_open_directories, 0, "");
 +     &chroot_allow_open_directories, 0,
 +     "Allow a process to chroot(2) if it has a directory open");
  
  /*
   * Change notion of root (``/'') directory.
 
 Modified: head/sys/vm/vm_meter.c
 ==============================================================================
 --- head/sys/vm/vm_meter.c	Mon Dec 12 23:29:32 2011	(r228448)
 +++ head/sys/vm/vm_meter.c	Tue Dec 13 00:38:50 2011	(r228449)
 @@ -55,21 +55,21 @@ __FBSDID("$FreeBSD$");
  struct vmmeter cnt;
  
  SYSCTL_UINT(_vm, VM_V_FREE_MIN, v_free_min,
 -	CTLFLAG_RW, &cnt.v_free_min, 0, "");
 +	CTLFLAG_RW, &cnt.v_free_min, 0, "Minimum low-free-pages threshold");
  SYSCTL_UINT(_vm, VM_V_FREE_TARGET, v_free_target,
 -	CTLFLAG_RW, &cnt.v_free_target, 0, "");
 +	CTLFLAG_RW, &cnt.v_free_target, 0, "Desired free pages");
  SYSCTL_UINT(_vm, VM_V_FREE_RESERVED, v_free_reserved,
 -	CTLFLAG_RW, &cnt.v_free_reserved, 0, "");
 +	CTLFLAG_RW, &cnt.v_free_reserved, 0, "Pages reserved for deadlock");
  SYSCTL_UINT(_vm, VM_V_INACTIVE_TARGET, v_inactive_target,
 -	CTLFLAG_RW, &cnt.v_inactive_target, 0, "");
 +	CTLFLAG_RW, &cnt.v_inactive_target, 0, "Pages desired inactive");
  SYSCTL_UINT(_vm, VM_V_CACHE_MIN, v_cache_min,
 -	CTLFLAG_RW, &cnt.v_cache_min, 0, "");
 +	CTLFLAG_RW, &cnt.v_cache_min, 0, "Min pages on cache queue");
  SYSCTL_UINT(_vm, VM_V_CACHE_MAX, v_cache_max,
 -	CTLFLAG_RW, &cnt.v_cache_max, 0, "");
 +	CTLFLAG_RW, &cnt.v_cache_max, 0, "Max pages on cache queue");
  SYSCTL_UINT(_vm, VM_V_PAGEOUT_FREE_MIN, v_pageout_free_min,
 -	CTLFLAG_RW, &cnt.v_pageout_free_min, 0, "");
 +	CTLFLAG_RW, &cnt.v_pageout_free_min, 0, "Min pages reserved for kernel");
  SYSCTL_UINT(_vm, OID_AUTO, v_free_severe,
 -	CTLFLAG_RW, &cnt.v_free_severe, 0, "");
 +	CTLFLAG_RW, &cnt.v_free_severe, 0, "Severe page depletion point");
  
  static int
  sysctl_vm_loadavg(SYSCTL_HANDLER_ARGS)
 @@ -270,104 +270,59 @@ static SYSCTL_NODE(_vm_stats, OID_AUTO, 
  	"VM meter vm stats");
  SYSCTL_NODE(_vm_stats, OID_AUTO, misc, CTLFLAG_RW, 0, "VM meter misc stats");
  
 -SYSCTL_PROC(_vm_stats_sys, OID_AUTO, v_swtch, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_swtch, 0, vcnt, "IU", "Context switches");
 -SYSCTL_PROC(_vm_stats_sys, OID_AUTO, v_trap, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_trap, 0, vcnt, "IU", "Traps");
 -SYSCTL_PROC(_vm_stats_sys, OID_AUTO, v_syscall, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_syscall, 0, vcnt, "IU", "Syscalls");
 -SYSCTL_PROC(_vm_stats_sys, OID_AUTO, v_intr, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_intr, 0, vcnt, "IU", "Hardware interrupts");
 -SYSCTL_PROC(_vm_stats_sys, OID_AUTO, v_soft, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_soft, 0, vcnt, "IU", "Software interrupts");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_vm_faults, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_vm_faults, 0, vcnt, "IU", "VM faults");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_cow_faults, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_cow_faults, 0, vcnt, "IU", "COW faults");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_cow_optim, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_cow_optim, 0, vcnt, "IU", "Optimized COW faults");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_zfod, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_zfod, 0, vcnt, "IU", "Zero fill");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_ozfod, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_ozfod, 0, vcnt, "IU", "Optimized zero fill");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_swapin, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_swapin, 0, vcnt, "IU", "Swapin operations");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_swapout, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_swapout, 0, vcnt, "IU", "Swapout operations");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_swappgsin, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_swappgsin, 0, vcnt, "IU", "Swapin pages");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_swappgsout, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_swappgsout, 0, vcnt, "IU", "Swapout pages");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_vnodein, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_vnodein, 0, vcnt, "IU", "Vnodein operations");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_vnodeout, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_vnodeout, 0, vcnt, "IU", "Vnodeout operations");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_vnodepgsin, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_vnodepgsin, 0, vcnt, "IU", "Vnodein pages");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_vnodepgsout, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_vnodepgsout, 0, vcnt, "IU", "Vnodeout pages");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_intrans, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_intrans, 0, vcnt, "IU", "In transit page blocking");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_reactivated, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_reactivated, 0, vcnt, "IU", "Reactivated pages");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_pdwakeups, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_pdwakeups, 0, vcnt, "IU", "Pagedaemon wakeups");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_pdpages, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_pdpages, 0, vcnt, "IU", "Pagedaemon page scans");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_tcached, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_tcached, 0, vcnt, "IU", "Total pages cached");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_dfree, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_dfree, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_pfree, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_pfree, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_tfree, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_tfree, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_page_size, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_page_size, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_page_count, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_page_count, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_free_reserved, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_free_reserved, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_free_target, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_free_target, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_free_min, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_free_min, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_free_count, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_free_count, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_wire_count, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_wire_count, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_active_count, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_active_count, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_inactive_target, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_inactive_target, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_inactive_count, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_inactive_count, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_cache_count, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_cache_count, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_cache_min, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_cache_min, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_cache_max, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_cache_max, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_pageout_free_min, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_pageout_free_min, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_interrupt_free_min, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_interrupt_free_min, 0, vcnt, "IU", "");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_forks, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_forks, 0, vcnt, "IU", "Number of fork() calls");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_vforks, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_vforks, 0, vcnt, "IU", "Number of vfork() calls");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_rforks, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_rforks, 0, vcnt, "IU", "Number of rfork() calls");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_kthreads, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_kthreads, 0, vcnt, "IU", "Number of fork() calls by kernel");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_forkpages, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_forkpages, 0, vcnt, "IU", "VM pages affected by fork()");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_vforkpages, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_vforkpages, 0, vcnt, "IU", "VM pages affected by vfork()");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_rforkpages, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_rforkpages, 0, vcnt, "IU", "VM pages affected by rfork()");
 -SYSCTL_PROC(_vm_stats_vm, OID_AUTO, v_kthreadpages, CTLTYPE_UINT|CTLFLAG_RD|CTLFLAG_MPSAFE,
 -	&cnt.v_kthreadpages, 0, vcnt, "IU", "VM pages affected by fork() by kernel");
 +#define VM_STATS_SYS(var, descr) SYSCTL_PROC(_vm_stats_sys, OID_AUTO, var, \
 +    (CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_MPSAFE), &cnt.v_swtch, 0, vcnt, \
 +    "IU", descr);
 +
 +VM_STATS_SYS(v_swtch, "Context switches");
 +VM_STATS_SYS(v_trap, "Traps");
 +VM_STATS_SYS(v_syscall, "System calls");
 +VM_STATS_SYS(v_intr, "Device interrupts");
 +VM_STATS_SYS(v_soft, "Software interrupts");
 +VM_STATS_SYS(v_vm_faults, "Address memory faults");
 +VM_STATS_SYS(v_cow_faults, "Copy-on-write faults");
 +VM_STATS_SYS(v_cow_optim, "Optimized COW faults")
 +VM_STATS_SYS(v_zfod, "Pages zero-filled on demand")
 +VM_STATS_SYS(v_ozfod, "Optimized zero fill pages")
 +VM_STATS_SYS(v_swapin, "Swap pager pageins")
 +VM_STATS_SYS(v_swapout, "Swap pager pageouts")
 +VM_STATS_SYS(v_swappgsin, "Swap pages swapped in")
 +VM_STATS_SYS(v_swappgsout, "Swap pages swapped out")
 +VM_STATS_SYS(v_vnodein, "Vnode pager pageins")
 +VM_STATS_SYS(v_vnodeout, "Vnode pager pageouts")
 +VM_STATS_SYS(v_vnodepgsin, "Vnode pages paged in")
 +VM_STATS_SYS(v_vnodepgsout, "Vnode pages paged out")
 +VM_STATS_SYS(v_intrans, "In transit page faults")
 +VM_STATS_SYS(v_reactivated, "Pages reactivated from free list")
 +VM_STATS_SYS(v_pdwakeups, "Pagedaemon wakeups")
 +VM_STATS_SYS(v_pdpages, "Pages analyzed by pagedaemon")
 +VM_STATS_SYS(v_tcached, "Total pages cached")
 +VM_STATS_SYS(v_dfree, "Pages freed by pagedaemon")
 +VM_STATS_SYS(v_pfree, "Pages freed by exiting processes")
 +VM_STATS_SYS(v_tfree, "Total pages freed")
 +VM_STATS_SYS(v_page_size, "Page size in bytes")
 +VM_STATS_SYS(v_page_count, "Total number of pages in system")
 +VM_STATS_SYS(v_free_reserved, "Pages reserved for deadlock")
 +VM_STATS_SYS(v_free_target, "Pages desired free")
 +VM_STATS_SYS(v_free_min, "Minimum low-free-pages threshold")
 +VM_STATS_SYS(v_free_count, "Free pages")
 +VM_STATS_SYS(v_wire_count, "Wired pages")
 +VM_STATS_SYS(v_active_count, "Active pages")
 +VM_STATS_SYS(v_inactive_target, "Desired inactive pages")
 +VM_STATS_SYS(v_inactive_count, "Inactive pages")
 +VM_STATS_SYS(v_cache_count, "Pages on cache queue")
 +VM_STATS_SYS(v_cache_min, "Min pages on cache queue")
 +VM_STATS_SYS(v_cache_max, "Max pages on cached queue")
 +VM_STATS_SYS(v_pageout_free_min, "Min pages reserved for kernel")
 +VM_STATS_SYS(v_interrupt_free_min, "Reserved pages for interrupt code")
 +VM_STATS_SYS(v_forks, "Number of fork() calls")
 +VM_STATS_SYS(v_vforks, "Number of vfork() calls")
 +VM_STATS_SYS(v_rforks, "Number of rfork() calls")
 +VM_STATS_SYS(v_kthreads, "Number of fork() calls by kernel")
 +VM_STATS_SYS(v_forkpages, "VM pages affected by fork()")
 +VM_STATS_SYS(v_vforkpages, "VM pages affected by vfork()")
 +VM_STATS_SYS(v_rforkpages, "VM pages affected by rfork()")
 +VM_STATS_SYS(v_kthreadpages, "VM pages affected by fork() by kernel")
  
 -SYSCTL_INT(_vm_stats_misc, OID_AUTO,
 -	zero_page_count, CTLFLAG_RD, &vm_page_zero_count, 0, "");
 +SYSCTL_INT(_vm_stats_misc, OID_AUTO, zero_page_count, CTLFLAG_RD,
 +	&vm_page_zero_count, 0, "Number of zero-ed free pages");
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: eadler 
State-Changed-When: Tue Dec 13 00:44:06 UTC 2011 
State-Changed-Why:  
This pr and related ones have been committed in in r228449 in a very 
differernt form (additional cleanups were made to the source at the same 
time) kern/155491 kern/155490 kern/155489 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155490 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Thu Mar 22 03:40:57 UTC 2012 
State-Changed-Why:  
no plans to MFC 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155490 
>Unformatted:
