From nobody@FreeBSD.org  Sat Feb 19 13:47:12 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 50E571065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 19 Feb 2011 13:47:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 40D298FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 19 Feb 2011 13:47:12 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p1JDlCvD013835
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 19 Feb 2011 13:47:12 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p1JDlCZm013834;
	Sat, 19 Feb 2011 13:47:12 GMT
	(envelope-from nobody)
Message-Id: <201102191347.p1JDlCZm013834@red.freebsd.org>
Date: Sat, 19 Feb 2011 13:47:12 GMT
From: Alexander Best <arundel@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc: <pjd@FreeBSD.org>
Subject: [patch] gpart(8): sys/boot/i386/gptboot/ leaves behind several *.o files
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         154888
>Category:       kern
>Synopsis:       [patch] sys/boot/i386/gptboot/ leaves behind several *.o files
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 19 13:50:09 UTC 2011
>Closed-Date:    Fri Mar 11 13:11:38 UTC 2011
>Last-Modified:  Fri Mar 11 13:20:08 UTC 2011
>Originator:     Alexander Best
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD otaku 9.0-CURRENT FreeBSD 9.0-CURRENT #2 r218710=b1b7068-dirty: Wed Feb 16 15:00:20 CET 2011     arundel@otaku:/usr/obj/usr/git-freebsd-head/sys/ARUNDEL  amd64
>Description:
after building world and cleaning up the whole source tree i realised, some *.o files are being left behind in sys/boot/i386/gptboot and not cleaned up by neither TARGET=clean, nor TARGET=cleandir.

the following patch should fix that.

cheers.
alex
>How-To-Repeat:
cd /usr/src && make buildworld && make clean clean cleandir cleandir && svn status . --no-ignore
>Fix:


Patch attached with submission follows:

diff --git a/sys/boot/i386/gptboot/Makefile b/sys/boot/i386/gptboot/Makefile
index 452b100..d42cf54 100644
--- a/sys/boot/i386/gptboot/Makefile
+++ b/sys/boot/i386/gptboot/Makefile
@@ -60,7 +60,8 @@ gptldr.bin: gptldr.out
 gptldr.out: gptldr.o
 	${LD} ${LDFLAGS} -e start -Ttext ${ORG1} -o ${.TARGET} gptldr.o
 
-CLEANFILES+=	gptboot.bin gptboot.out gptboot.o sio.o ufsread.o
+CLEANFILES+=	cons.o crc32.o drv.o gpt.o gptboot.bin gptboot.out \
+		gptboot.o sio.o ufsread.o util.o
 
 gptboot.bin: gptboot.out
 	objcopy -S -O binary gptboot.out ${.TARGET}


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-geom 
Responsible-Changed-By: arundel 
Responsible-Changed-When: Sat Feb 19 13:51:36 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154888 
Responsible-Changed-From-To: freebsd-geom->freebsd-bugs 
Responsible-Changed-By: ae 
Responsible-Changed-When: Sat Feb 19 23:55:56 UTC 2011 
Responsible-Changed-Why:  
It is not GEOM-related.  

http://www.freebsd.org/cgi/query-pr.cgi?pr=154888 
State-Changed-From-To: open->closed 
State-Changed-By: jhb 
State-Changed-When: Fri Mar 11 13:11:25 UTC 2011 
State-Changed-Why:  
Fix applied, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154888 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/154888: commit references a PR
Date: Fri, 11 Mar 2011 13:11:29 +0000 (UTC)

 Author: jhb
 Date: Fri Mar 11 13:11:15 2011
 New Revision: 219483
 URL: http://svn.freebsd.org/changeset/base/219483
 
 Log:
   Remove all object files during 'make clean'.
   
   PR:		kern/154888
   Submitted by:	arundel
   MFC after:	1 week
 
 Modified:
   head/sys/boot/i386/gptboot/Makefile
 
 Modified: head/sys/boot/i386/gptboot/Makefile
 ==============================================================================
 --- head/sys/boot/i386/gptboot/Makefile	Fri Mar 11 12:12:35 2011	(r219482)
 +++ head/sys/boot/i386/gptboot/Makefile	Fri Mar 11 13:11:15 2011	(r219483)
 @@ -65,7 +65,8 @@ gptldr.bin: gptldr.out
  gptldr.out: gptldr.o
  	${LD} ${LDFLAGS} -e start -Ttext ${ORG1} -o ${.TARGET} gptldr.o
  
 -CLEANFILES+=	gptboot.bin gptboot.out gptboot.o sio.o ufsread.o
 +CLEANFILES+=	gptboot.bin gptboot.out gptboot.o sio.o gpt.o crc32.o drv.o \
 +		cons.o util.o
  
  gptboot.bin: gptboot.out
  	objcopy -S -O binary gptboot.out ${.TARGET}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
