From wollman@khavrinen.lcs.mit.edu  Mon Dec 13 13:11:37 1999
Return-Path: <wollman@khavrinen.lcs.mit.edu>
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
	by hub.freebsd.org (Postfix) with ESMTP id 1C29015223
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 13 Dec 1999 13:11:37 -0800 (PST)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: (from wollman@localhost)
	by khavrinen.lcs.mit.edu (8.9.3/8.9.3) id QAA93209;
	Mon, 13 Dec 1999 16:11:33 -0500 (EST)
	(envelope-from wollman)
Message-Id: <199912132111.QAA93209@khavrinen.lcs.mit.edu>
Date: Mon, 13 Dec 1999 16:11:33 -0500 (EST)
From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Reply-To: wollman@khavrinen.lcs.mit.edu
To: FreeBSD-gnats-submit@freebsd.org
Subject: bug in in_cksum_finalize
X-Send-Pr-Version: 3.2

>Number:         15472
>Category:       kern
>Synopsis:       bug in in_cksum_finalize
>Confidential:   no
>Severity:       critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 13 13:20:00 PST 1999
>Closed-Date:    Tue May 29 10:48:01 PDT 2001
>Last-Modified:  Tue May 29 10:48:18 PDT 2001
>Originator:     Garrett Wollman
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
MIT Laboratory for Computer Science
>Environment:

	irrelevant.

>Description:

	Brad Karp identified a deficiency in the in_cksum_finalize
	routine; it does not complement the sum as required.

>How-To-Repeat:

	Attempt to use in_cksum_partial()/in_cksum_finalize()

>Fix:

(beware cut-and-paste-os)

Index: in_cksum.c
===================================================================
RCS file: /home/cvs/src/sys/i386/i386/in_cksum.c,v
retrieving revision 1.16
diff -u -r1.16 in_cksum.c
--- in_cksum.c  1999/08/28 00:43:44     1.16
+++ in_cksum.c  1999/12/13 21:07:20
@@ -411,5 +411,5 @@
 {
        in_psum_t sum = psum;
        REDUCE;
-       return (sum & 0xffff);
+       return (~sum & 0xffff);
 }


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->suspended 
State-Changed-By: sheldonh 
State-Changed-When: Mon Dec 20 04:12:42 PST 1999 
State-Changed-Why:  
Committed as rev 1.17 of in_cksum.c . 
MFC candidate. 
State-Changed-From-To: suspended->closed 
State-Changed-By: phk 
State-Changed-When: Tue May 29 10:48:01 PDT 2001 
State-Changed-Why:  
timed out. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=15472 
>Unformatted:
