From nobody@FreeBSD.org  Sat Jan 15 10:00:03 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 691AE106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 Jan 2011 10:00:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 495B88FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 Jan 2011 10:00:03 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p0FA03UH043948
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 15 Jan 2011 10:00:03 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p0FA03BM043947;
	Sat, 15 Jan 2011 10:00:03 GMT
	(envelope-from nobody)
Message-Id: <201101151000.p0FA03BM043947@red.freebsd.org>
Date: Sat, 15 Jan 2011 10:00:03 GMT
From: Alexander Best <arundel@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [zfs] broken include path in kern.pre
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         154024
>Category:       kern
>Synopsis:       [zfs] [patch] broken include path in kern.pre
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pluknet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 15 10:00:23 UTC 2011
>Closed-Date:    Mon Feb 14 12:42:48 UTC 2011
>Last-Modified:  Mon Feb 14 12:42:48 UTC 2011
>Originator:     Alexander Best
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD otaku 9.0-CURRENT FreeBSD 9.0-CURRENT #2 r216931: Mon Jan  3 21:51:08 CET 2011     arundel@otaku:/usr/obj/usr/subversion-src/sys/ARUNDEL  amd64
>Description:
"INCLUDES+= -I$S/contrib/opensolaris/compat" points to a non-existing directory. Sergey Kandaurov noticed that this is a leftover from //depot/projects/dtrace/src/sys/contrib/opensolaris/compat/sys. Warner Losh reccommended to remove the include line from kern.pre completely. the attached patch will correct the path, however: since target 'buildworld' suceeds with the broken include, Warner Losh is probably right. simply removing it won't do any harm.

the discussion took place on freebsd-hackers@ [1].

cheers.
alex

[1] http://www.mail-archive.com/freebsd-hackers@freebsd.org/msg159002.html
>How-To-Repeat:
when using "CC=clang -v" and "CXX=clang++ -v" as base compiler the problem becomes obvious. simply look for these lines:

ignoring nonexistent directory "/usr/src/sys/contrib/opensolaris/compat"
>Fix:


Patch attached with submission follows:

Index: sys/conf/kern.pre.mk
===================================================================
--- sys/conf/kern.pre.mk	(revision 217444)
+++ sys/conf/kern.pre.mk	(working copy)
@@ -83,7 +83,7 @@
 INCLUDES+= -I$S/gnu/fs/xfs/FreeBSD -I$S/gnu/fs/xfs/FreeBSD/support -I$S/gnu/fs/xfs
 
 # ...  and OpenSolaris
-INCLUDES+= -I$S/contrib/opensolaris/compat
+INCLUDES+= -I$S/cddl/compat/opensolaris
 
 # ... and the same for cxgb
 INCLUDES+= -I$S/dev/cxgb


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->imp 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Jan 15 18:36:10 UTC 2011 
Responsible-Changed-Why:  
imp, since you recommended this fix, does the patch look correct to you? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154024 
State-Changed-From-To: open->patched 
State-Changed-By: arundel 
State-Changed-When: Wed Feb 2 17:16:24 UTC 2011 
State-Changed-Why:  
Patched in HEAD (r218189). 


Responsible-Changed-From-To: imp->pluknet 
Responsible-Changed-By: arundel 
Responsible-Changed-When: Wed Feb 2 17:16:24 UTC 2011 
Responsible-Changed-Why:  
Over to committer as MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154024 
State-Changed-From-To: patched->closed 
State-Changed-By: pluknet 
State-Changed-When: Mon Feb 14 12:41:14 UTC 2011 
State-Changed-Why:  
Merged to stable/8 (r218484) and stable/7 (r218487). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154024 
>Unformatted:
