From nobody@FreeBSD.org  Thu Jan 13 08:46:06 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0CBC91065670
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 13 Jan 2011 08:46:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id F0F8B8FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 13 Jan 2011 08:46:05 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p0D8k5Wp014512
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 13 Jan 2011 08:46:05 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p0D8k5UD014511;
	Thu, 13 Jan 2011 08:46:05 GMT
	(envelope-from nobody)
Message-Id: <201101130846.p0D8k5UD014511@red.freebsd.org>
Date: Thu, 13 Jan 2011 08:46:05 GMT
From: Pavel Polyakov <bsd@kobyla.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: panic after "ifconfig age0 up" in r216925
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         153948
>Category:       kern
>Synopsis:       [panic] panic after "ifconfig age0 up" in r216925
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 13 08:50:07 UTC 2011
>Closed-Date:    Thu Jan 13 13:05:22 UTC 2011
>Last-Modified:  Thu Jan 13 13:10:08 UTC 2011
>Originator:     Pavel Polyakov
>Release:        9.0-CURRENT Revision: 217222
>Organization:
>Environment:
FreeBSD pp.fss.sunpp 9.0-CURRENT FreeBSD 9.0-CURRENT #2 r217222: Mon Jan 10 15:49:36 EET 2011     root@:/usr/obj/usr/src/sys/WORK8SMP  amd64

>Description:
panic after "ifconfig age0 up" + ~3 seconds
panic: lock (sleep mutex) age0 not locked @ sys/dev/age/if_age.c:1714

Problem appeared after this change
r216925 | jhb | 2011-01-03 20:28:30 +0200

Downgrading sys/dev/age to the previous revision (r213893 | marius | 2010-10-15 17:52:11 +0300) and recompiling sys/modules/age "solves" this problem -
age(4) works like before last commit

----

Problem proved to appear on amd64 r217222 and i386 r217258.

age0@pci0:2:0:0:        class=0x020000 card=0x82261043 chip=0x10481969 rev=0xb0 hdr=0x00
    vendor     = 'Attansic (Now owned by Atheros)'
    device     = 'Gigabit Ethernet 10/100/1000 Base-T Controller (Atheros L1)'
    class      = network
    subclass   = ethernet

>How-To-Repeat:
ifconfig age0 up
Using 9.0-C since r216925
>Fix:
downgrade sys/dev/age to r213893

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: jhb 
State-Changed-When: Thu Jan 13 13:04:59 UTC 2011 
State-Changed-Why:  
Ooops, should be fixed now. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153948 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/153948: commit references a PR
Date: Thu, 13 Jan 2011 13:04:55 +0000 (UTC)

 Author: jhb
 Date: Thu Jan 13 13:04:49 2011
 New Revision: 217349
 URL: http://svn.freebsd.org/changeset/base/217349
 
 Log:
   Forgot to remove unlock of the driver lock from age_start_locked() when
   converting it to a locked variant.
   
   PR:		kern/153948
 
 Modified:
   head/sys/dev/age/if_age.c
 
 Modified: head/sys/dev/age/if_age.c
 ==============================================================================
 --- head/sys/dev/age/if_age.c	Thu Jan 13 12:26:39 2011	(r217348)
 +++ head/sys/dev/age/if_age.c	Thu Jan 13 13:04:49 2011	(r217349)
 @@ -1760,8 +1760,6 @@ age_start_locked(struct ifnet *ifp)
  		/* Set a timeout in case the chip goes out to lunch. */
  		sc->age_watchdog_timer = AGE_TX_TIMEOUT;
  	}
 -
 -	AGE_UNLOCK(sc);
  }
  
  static void
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
