From nobody@FreeBSD.org  Fri Jan  7 19:40:46 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7C232106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  7 Jan 2011 19:40:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 6C06C8FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  7 Jan 2011 19:40:46 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p07JeklW060922
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 7 Jan 2011 19:40:46 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p07JekOu060921;
	Fri, 7 Jan 2011 19:40:46 GMT
	(envelope-from nobody)
Message-Id: <201101071940.p07JekOu060921@red.freebsd.org>
Date: Fri, 7 Jan 2011 19:40:46 GMT
From: Andrew Boyer <aboyer@averesystems.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [ixgbe] [patch] sysctls reference wrong XON/XOFF variables
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         153772
>Category:       kern
>Synopsis:       [ixgbe] [patch] sysctls reference wrong XON/XOFF variables
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-net
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 07 19:50:02 UTC 2011
>Closed-Date:    Thu Feb 06 21:55:03 CET 2014
>Last-Modified:  Thu Feb 06 21:55:03 CET 2014
>Originator:     Andrew Boyer
>Release:        -current
>Organization:
Avere Systems
>Environment:
N/A
>Description:
ixgbe.c creates sysctls called 'link_xon_rcvd' and 'link_xoff_rcvd', but they display the transmit statistics instead of the receive statistics.  It's a copy-and-paste error.
>How-To-Repeat:
Found by inspection
>Fix:


Patch attached with submission follows:

--- src/sys/dev/ixgbe/ixgbe.c	2011-01-07 14:29:37.000000000 -0500
+++ src/sys/dev/ixgbe/ixgbe.c	2011-01-07 14:29:17.000000000 -0500
@@ -5460,13 +5460,13 @@
 			CTLFLAG_RD, &stats->lxontxc,
 			"Link XON Transmitted");
 	SYSCTL_ADD_QUAD(ctx, stat_list, OID_AUTO, "link_xon_rcvd",
-			CTLFLAG_RD, &stats->lxontxc,
+			CTLFLAG_RD, &stats->lxonrxc,
 			"Link XON Received");
 	SYSCTL_ADD_QUAD(ctx, stat_list, OID_AUTO, "link_xoff_txd",
 			CTLFLAG_RD, &stats->lxofftxc,
 			"Link XOFF Transmitted");
 	SYSCTL_ADD_QUAD(ctx, stat_list, OID_AUTO, "link_xoff_rcvd",
-			CTLFLAG_RD, &stats->lxofftxc,
+			CTLFLAG_RD, &stats->lxoffrxc,
 			"Link XOFF Received");
 
 	/* Packet Reception Stats */


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Jan 7 21:55:46 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153772 
State-Changed-From-To: open->closed 
State-Changed-By: brueffer 
State-Changed-When: Thu Feb 6 21:53:56 CET 2014 
State-Changed-Why:  
This was fixed in r217127 three years ago, might as well close this PR now :-) 
Thanks for the patch! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153772 
>Unformatted:
