From nobody@FreeBSD.org  Tue Aug 10 15:01:35 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 02A3B106568A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Aug 2010 15:01:35 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id CB0CA8FC21
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Aug 2010 15:01:34 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o7AF1YDH044479
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Aug 2010 15:01:34 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o7AF1YxE044478;
	Tue, 10 Aug 2010 15:01:34 GMT
	(envelope-from nobody)
Message-Id: <201008101501.o7AF1YxE044478@www.freebsd.org>
Date: Tue, 10 Aug 2010 15:01:34 GMT
From: Andrew Boyer <aboyer@averesystems.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [mpt] Latent buglet in debug print code
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         149502
>Category:       kern
>Synopsis:       [mpt] Latent buglet in debug print code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-scsi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 10 15:10:03 UTC 2010
>Closed-Date:    Sun Nov 21 00:54:18 UTC 2010
>Last-Modified:  Sun Nov 21 01:00:22 UTC 2010
>Originator:     Andrew Boyer
>Release:        -CURRENT
>Organization:
Avere Systems Inc.
>Environment:
N/A
>Description:
In src/sys/dev/mpt/mpt.h, there's a macro to define an mpt_lprtc() function.  On line 1117 it references (mpt)->debug_level, which doesn't exist.  It should refer to (mpt)->verbose instead.
>How-To-Repeat:
Add debugging calls to mpt_lprtc() and try to build.
>Fix:
Replace (mpt)->debug_level with (mpt)->verbose on line 1117.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-scsi 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Aug 10 15:14:55 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149502 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/149502: commit references a PR
Date: Sun, 14 Nov 2010 22:34:41 +0000 (UTC)

 Author: marius
 Date: Sun Nov 14 22:34:33 2010
 New Revision: 215325
 URL: http://svn.freebsd.org/changeset/base/215325
 
 Log:
   Use the correct variable for determining the verbosity level in mpt_lprtc().
   While at it, fix the whitespace of that macro.
   
   PR:		149502
   Submitted by:	Andrew Boyer
   MFC after:	1 week
 
 Modified:
   head/sys/dev/mpt/mpt.h
 
 Modified: head/sys/dev/mpt/mpt.h
 ==============================================================================
 --- head/sys/dev/mpt/mpt.h	Sun Nov 14 22:17:12 2010	(r215324)
 +++ head/sys/dev/mpt/mpt.h	Sun Nov 14 22:34:33 2010	(r215325)
 @@ -1112,10 +1112,10 @@ do {						\
  		mpt_prt(mpt, __VA_ARGS__);	\
  } while (0)
  
 -#define mpt_lprtc(mpt, level, ...)		 \
 -do {						 \
 -	if (level <= (mpt)->debug_level)	 \
 -		mpt_prtc(mpt, __VA_ARGS__);	 \
 +#define mpt_lprtc(mpt, level, ...)		\
 +do {						\
 +	if (level <= (mpt)->verbose)		\
 +		mpt_prtc(mpt, __VA_ARGS__);	\
  } while (0)
  #else
  void mpt_lprt(struct mpt_softc *, int, const char *, ...)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: marius 
State-Changed-When: Sun Nov 21 00:54:00 UTC 2010 
State-Changed-Why:  
close 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149502 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/149502: commit references a PR
Date: Sun, 21 Nov 2010 00:53:26 +0000 (UTC)

 Author: marius
 Date: Sun Nov 21 00:53:19 2010
 New Revision: 215602
 URL: http://svn.freebsd.org/changeset/base/215602
 
 Log:
   MFC: r215325
   
   Use the correct variable for determining the verbosity level in mpt_lprtc().
   While at it, fix the whitespace of that macro.
   
   PR:		149502
   Submitted by:	Andrew Boyer
 
 Modified:
   stable/8/sys/dev/mpt/mpt.h
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
 
 Modified: stable/8/sys/dev/mpt/mpt.h
 ==============================================================================
 --- stable/8/sys/dev/mpt/mpt.h	Sun Nov 21 00:50:31 2010	(r215601)
 +++ stable/8/sys/dev/mpt/mpt.h	Sun Nov 21 00:53:19 2010	(r215602)
 @@ -1112,10 +1112,10 @@ do {						\
  		mpt_prt(mpt, __VA_ARGS__);	\
  } while (0)
  
 -#define mpt_lprtc(mpt, level, ...)		 \
 -do {						 \
 -	if (level <= (mpt)->debug_level)	 \
 -		mpt_prtc(mpt, __VA_ARGS__);	 \
 +#define mpt_lprtc(mpt, level, ...)		\
 +do {						\
 +	if (level <= (mpt)->verbose)		\
 +		mpt_prtc(mpt, __VA_ARGS__);	\
  } while (0)
  #else
  void mpt_lprt(struct mpt_softc *, int, const char *, ...)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/149502: commit references a PR
Date: Sun, 21 Nov 2010 00:53:33 +0000 (UTC)

 Author: marius
 Date: Sun Nov 21 00:53:27 2010
 New Revision: 215603
 URL: http://svn.freebsd.org/changeset/base/215603
 
 Log:
   MFC: r215325
   
   Use the correct variable for determining the verbosity level in mpt_lprtc().
   While at it, fix the whitespace of that macro.
   
   PR:		149502
   Submitted by:	Andrew Boyer
 
 Modified:
   stable/7/sys/dev/mpt/mpt.h
 Directory Properties:
   stable/7/sys/   (props changed)
   stable/7/sys/cddl/contrib/opensolaris/   (props changed)
   stable/7/sys/contrib/dev/acpica/   (props changed)
   stable/7/sys/contrib/pf/   (props changed)
 
 Modified: stable/7/sys/dev/mpt/mpt.h
 ==============================================================================
 --- stable/7/sys/dev/mpt/mpt.h	Sun Nov 21 00:53:19 2010	(r215602)
 +++ stable/7/sys/dev/mpt/mpt.h	Sun Nov 21 00:53:27 2010	(r215603)
 @@ -1110,10 +1110,10 @@ do {						\
  		mpt_prt(mpt, __VA_ARGS__);	\
  } while (0)
  
 -#define mpt_lprtc(mpt, level, ...)		 \
 -do {						 \
 -	if (level <= (mpt)->debug_level)	 \
 -		mpt_prtc(mpt, __VA_ARGS__);	 \
 +#define mpt_lprtc(mpt, level, ...)		\
 +do {						\
 +	if (level <= (mpt)->verbose)		\
 +		mpt_prtc(mpt, __VA_ARGS__);	\
  } while (0)
  #else
  void mpt_lprt(struct mpt_softc *, int, const char *, ...)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
