From nobody@FreeBSD.org  Wed Jul 21 14:16:33 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 89436106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 21 Jul 2010 14:16:33 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 785B58FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 21 Jul 2010 14:16:33 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o6LEGXcV090062
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 21 Jul 2010 14:16:33 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o6LEGXDW090061;
	Wed, 21 Jul 2010 14:16:33 GMT
	(envelope-from nobody)
Message-Id: <201007211416.o6LEGXDW090061@www.freebsd.org>
Date: Wed, 21 Jul 2010 14:16:33 GMT
From: pluknet <pluknet@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] [ext2fs] duplicated comment block cleanup
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         148820
>Category:       kern
>Synopsis:       [patch] [ext2fs] duplicated comment block cleanup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lulf
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 21 14:20:01 UTC 2010
>Closed-Date:    Wed Sep 01 06:00:58 UTC 2010
>Last-Modified:  Wed Sep 01 06:00:58 UTC 2010
>Originator:     pluknet
>Release:        HEAD r209037
>Organization:
>Environment:
>Description:
ext2_alloc() has a leading duplicated comment.
This patch removes the second copy.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: sys/fs/ext2fs/ext2_alloc.c
===================================================================
--- sys/fs/ext2fs/ext2_alloc.c	(revision 209037)
+++ sys/fs/ext2fs/ext2_alloc.c	(working copy)
@@ -75,20 +75,6 @@
  *        inode for the file.
  *   2) quadradically rehash into other cylinder groups, until an
  *        available block is located.
- *
- * A preference may be optionally specified. If a preference is given
- * the following hierarchy is used to allocate a block:
- *   1) allocate the requested block.
- *   2) allocate a rotationally optimal block in the same cylinder.
- *   3) allocate a block in the same cylinder group.
- *   4) quadradically rehash into other cylinder groups, until an
- *        available block is located.
- * If no block preference is given the following hierarchy is used
- * to allocate a block:
- *   1) allocate a block in the cylinder group that contains the
- *        inode for the file.
- *   2) quadradically rehash into other cylinder groups, until an
- *        available block is located.
  */
 
 int


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->lulf 
Responsible-Changed-By: vwe 
Responsible-Changed-When: Sun Aug 15 22:37:43 UTC 2010 
Responsible-Changed-Why:  
Ulf, please review and fix. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148820 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/148820: commit references a PR
Date: Wed,  1 Sep 2010 05:34:28 +0000 (UTC)

 Author: lulf
 Date: Wed Sep  1 05:34:17 2010
 New Revision: 212079
 URL: http://svn.freebsd.org/changeset/base/212079
 
 Log:
   - Remove duplicate comment.
   
   PR:		kern/148820
   Submitted by:	pluknet <pluknet - at - gmail.com>
 
 Modified:
   head/sys/fs/ext2fs/ext2_alloc.c
 
 Modified: head/sys/fs/ext2fs/ext2_alloc.c
 ==============================================================================
 --- head/sys/fs/ext2fs/ext2_alloc.c	Wed Sep  1 03:55:10 2010	(r212078)
 +++ head/sys/fs/ext2fs/ext2_alloc.c	Wed Sep  1 05:34:17 2010	(r212079)
 @@ -75,20 +75,6 @@ static daddr_t  ext2_mapsearch(struct m_
   *        inode for the file.
   *   2) quadradically rehash into other cylinder groups, until an
   *        available block is located.
 - *
 - * A preference may be optionally specified. If a preference is given
 - * the following hierarchy is used to allocate a block:
 - *   1) allocate the requested block.
 - *   2) allocate a rotationally optimal block in the same cylinder.
 - *   3) allocate a block in the same cylinder group.
 - *   4) quadradically rehash into other cylinder groups, until an
 - *        available block is located.
 - * If no block preference is given the following hierarchy is used
 - * to allocate a block:
 - *   1) allocate a block in the cylinder group that contains the
 - *        inode for the file.
 - *   2) quadradically rehash into other cylinder groups, until an
 - *        available block is located.
   */
  
  int
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: lulf 
State-Changed-When: Wed Sep 1 06:00:31 UTC 2010 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148820 
>Unformatted:
