From nobody@FreeBSD.org  Tue Jul 20 19:52:17 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 84E65106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 20 Jul 2010 19:52:17 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 73B628FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 20 Jul 2010 19:52:17 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o6KJqHXS050225
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 20 Jul 2010 19:52:17 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o6KJqHCd050224;
	Tue, 20 Jul 2010 19:52:17 GMT
	(envelope-from nobody)
Message-Id: <201007201952.o6KJqHCd050224@www.freebsd.org>
Date: Tue, 20 Jul 2010 19:52:17 GMT
From: pluknet <pluknet@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] obsolete CAPABILITIES comment after suser(9) -> priv(9)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         148801
>Category:       kern
>Synopsis:       [kernel] [patch] obsolete CAPABILITIES comment after suser(9) -> priv(9)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jonathan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 20 20:00:03 UTC 2010
>Closed-Date:    Tue Jul 05 21:13:40 UTC 2011
>Last-Modified:  Tue Jul 05 21:13:40 UTC 2011
>Originator:     pluknet
>Release:        HEAD r209989
>Organization:
>Environment:
>Description:
This comment was left after "Sweep kernel replacing suser(9) calls with priv(9)
calls" (svn r164033 by rwatson@) in which the exp. CAPABILITIES facility was 
moved to current operating priv(9).
After that the comment has lost its relevance. May be applied down to 7.x.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: sys/kern/vfs_subr.c
===================================================================
--- sys/kern/vfs_subr.c	(revision 209989)
+++ sys/kern/vfs_subr.c	(working copy)
@@ -3515,9 +3515,6 @@
  * and optional call-by-reference privused argument allowing vaccess()
  * to indicate to the caller whether privilege was used to satisfy the
  * request (obsoleted).  Returns 0 on success, or an errno on failure.
- *
- * The ifdef'd CAPABILITIES version is here for reference, but is not
- * actually used.
  */
 int
 vaccess(enum vtype type, mode_t file_mode, uid_t file_uid, gid_t file_gid,


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: pluknet 
State-Changed-When: Fri Jul 1 15:17:09 UTC 2011 
State-Changed-Why:  
Patched in HEAD (in r223505 by jonathan). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148801 
Responsible-Changed-From-To: freebsd-bugs->jonathan 
Responsible-Changed-By: jonathan 
Responsible-Changed-When: Tue Jul 5 15:04:32 UTC 2011 
Responsible-Changed-Why:  
Take ownership (after fixing) 


http://www.freebsd.org/cgi/query-pr.cgi?pr=148801 

From: Jonathan Anderson <jonathan@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: kern/148801: [patch] obsolete CAPABILITIES comment after suser(9) -> priv(9)
Date: Tue, 5 Jul 2011 16:01:35 +0100

 This commit is believed to fix this problem, and has been merged to
 stable/7 and stable/8.
 
 
 ---------- Forwarded message ----------
 From: Jonathan Anderson <jonathan@freebsd.org>
 Date: 5 July 2011 15:54
 Subject: svn commit: r223789 - stable/8/sys/kern
 To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
 
 
 Author: jonathan
 Date: Tue Jul =C2=A05 14:54:33 2011
 New Revision: 223789
 URL: http://svn.freebsd.org/changeset/base/223789
 
 Log:
 =C2=A0Merge r223505 from HEAD to stable/8:
 =C2=A0--
 =C2=A0Tidy up a capabilities-related comment.
 
 =C2=A0This commit refers to an #ifdef that hasn't been merged [yet?]; remov=
 e it.
 
 =C2=A0Approved by: rwatson
 =C2=A0--
 
 Modified:
 =C2=A0stable/8/sys/kern/vfs_subr.c
 Directory Properties:
 =C2=A0stable/8/sys/ =C2=A0 (props changed)
 =C2=A0stable/8/sys/amd64/include/xen/ =C2=A0 (props changed)
 =C2=A0stable/8/sys/cddl/contrib/opensolaris/ =C2=A0 (props changed)
 =C2=A0stable/8/sys/contrib/dev/acpica/ =C2=A0 (props changed)
 =C2=A0stable/8/sys/contrib/pf/ =C2=A0 (props changed)
 
 Modified: stable/8/sys/kern/vfs_subr.c
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D
 --- stable/8/sys/kern/vfs_subr.c =C2=A0 =C2=A0 =C2=A0 =C2=A0Tue Jul =C2=A05=
  14:50:06 2011
 =C2=A0(r223788)
 +++ stable/8/sys/kern/vfs_subr.c =C2=A0 =C2=A0 =C2=A0 =C2=A0Tue Jul =C2=A05=
  14:54:33 2011
 =C2=A0(r223789)
 @@ -3567,9 +3567,6 @@ vn_isdisk(struct vnode *vp, int *errp)
 =C2=A0* and optional call-by-reference privused argument allowing vaccess()
 =C2=A0* to indicate to the caller whether privilege was used to satisfy the
 =C2=A0* request (obsoleted). =C2=A0Returns 0 on success, or an errno on fai=
 lure.
 - *
 - * The ifdef'd CAPABILITIES version is here for reference, but is not
 - * actually used.
 =C2=A0*/
 =C2=A0int
 =C2=A0vaccess(enum vtype type, mode_t file_mode, uid_t file_uid, gid_t file=
 _gid,
State-Changed-From-To: patched->closed 
State-Changed-By: jonathan 
State-Changed-When: Tue Jul 5 21:09:44 UTC 2011 
State-Changed-Why:  
Fixed by r223785, which has been merged to stable/8 (r223789) and stable/8 (r148801). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148801 
>Unformatted:
